From patchwork Sun Mar 28 22:45:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 11746 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 40AB2C32EA for ; Sun, 28 Mar 2021 22:45:37 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B1EC16877F; Mon, 29 Mar 2021 00:45:36 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="YD/Qnk8N"; dkim-atps=neutral Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1CB26602D7 for ; Mon, 29 Mar 2021 00:45:36 +0200 (CEST) Received: by mail-pj1-x102a.google.com with SMTP id nh23-20020a17090b3657b02900c0d5e235a8so5043911pjb.0 for ; Sun, 28 Mar 2021 15:45:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=S9uuhnAqlyfG6lrRz5jo2e52VU2vH10LP61n9Km4VtI=; b=YD/Qnk8NvB6uLiFw4/Yay68ZwRE09wbQWLo+UOohjv3WHUqWRfWC7gzPdGAAOJYdOZ uDklGiU8xmoJTBtYhFMHb06NVuBrnoJ2Kz0avYQyJ4fw+O5dQmgrq9IyxbTmGuLYn5uO 1takpaKgF/35qzzpirnLkFKZ+bNpyNzwSnMJ0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=S9uuhnAqlyfG6lrRz5jo2e52VU2vH10LP61n9Km4VtI=; b=C7iW5jJbhW5mkwPWbWu/pS4iRpRwp26lDlvPGH8yHOZ6SNNb2+78XrAsGnQvPMiRx8 JODg3Wj0U+LKkePG3XCV6fnbxe/fOO4R4JvmrGvW4CX9Tp8Kb4C8VAE5MPztGBCwAWQv lDzbEtmMsHmfiqd7mECNLFcnyzfnfUXvyLcX98F/Y5Ry0ow0ySIWrcq04mF6kftA6vpe l40e9jJKwemBRJALfyqxeGrgLAp5ZbJn2hIVdFwTqcQFOGEbduGN25KK4C1MaHmQ2zKm b7uhdsxsByIO+Qua7fGymwzdVsXO8e9CIOXA0yPiGivNgC9mccjpvdn6wRJfTCDBudgE MUmA== X-Gm-Message-State: AOAM533k7vvFv2ZaJIbj77fji4J5iaXdavX/IBrH0EJYA9vmdRlu1MUK PLk70hYI+ckt33iSdH012KhcFManZVxrzA== X-Google-Smtp-Source: ABdhPJynFl1o/KyqIIJNlihIecNOoI7Gs85iJlc49oAMRK74oGo/SD1hZyBbcxQXGqG/gdsmUt2iRg== X-Received: by 2002:a17:90a:f40f:: with SMTP id ch15mr24012257pjb.128.1616971534488; Sun, 28 Mar 2021 15:45:34 -0700 (PDT) Received: from hiroh2.tok.corp.google.com ([2401:fa00:8f:2:1db7:ae60:9288:b906]) by smtp.gmail.com with ESMTPSA id q25sm14814244pff.104.2021.03.28.15.45.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Mar 2021 15:45:34 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Mon, 29 Mar 2021 07:45:25 +0900 Message-Id: <20210328224528.55468-1-hiroh@chromium.org> X-Mailer: git-send-email 2.31.0.291.g576ba9dcdaf-goog MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/3] Regard crop_rotate_scale_degrees in configuration X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" A HAL client requests the demanded rotation by |crop_rotate_scale_degrees| in camera3_stream in configuration. Libcamera ignores it and doesn't handle the rotation request at all. This patch series still don't support it, but add the validation check to the rotation values and deny if a rotation is requested. Change in v2: - Address Jacopo's comments. Hirokazu Honda (3): android: CameraDevice: Validate crop_rotate_scale_degrees in configuration android: CameraDevice: Log rotation variables in camera3_stream android: CameraDevice: Deny non ROTATION_0 stream configuration src/android/camera_device.cpp | 63 +++++++++++++++++++++++++++++++++++ 1 file changed, 63 insertions(+) --- 2.31.0.291.g576ba9dcdaf-goog