From patchwork Fri Mar 26 12:43:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 11729 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 36FF9C32EA for ; Fri, 26 Mar 2021 12:43:26 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 889E468D6E; Fri, 26 Mar 2021 13:43:25 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="FU5DsJnp"; dkim-atps=neutral Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 39E51602D7 for ; Fri, 26 Mar 2021 13:43:24 +0100 (CET) Received: by mail-ej1-x634.google.com with SMTP id u5so8196848ejn.8 for ; Fri, 26 Mar 2021 05:43:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jmy6Gh3L5XPV+0fAr1IAO4hSYlMxHf64U3HLFVqAPEY=; b=FU5DsJnpk3qujsdwosA9AMqg4Aum3QfVLPpybwdt3+35GC9Yevm05BMi2wFVgy5L0D rvFRkHdbGmuUhlFJbDfPjRsLzrEqelNT1BS9RuaI/7cD5j/qAL2YIZsFq0bdKAhH6FmD aDWrc/lOwSqAZSPb6TNkKfeA71LxuZYwBqxrQvNXnBv1sRnFv43/PXoGl7y6TcGeZKGd +4BFm47yin8PidXbfLq+RTPisiKU6g2TWPreFlCVYiBy6qYInUJ8SX7uBi9TJGztbEw9 lk8pPm+yKFSe4USGAioFj9Qdu3s+ivp706ojMNNbHbvNZq1YnrySNv0dgSLWllFjd92c BvXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jmy6Gh3L5XPV+0fAr1IAO4hSYlMxHf64U3HLFVqAPEY=; b=sdykuVExggtrxiltCeD8uivZ/TK/2QTgUxj30TfBE4pLvSz+SVMN3NnGljdGggkALq u0ABy7xaXkaSKaQA3hLqGXtLvsbtMsnlalAQURkFM4OUSTNTnK9dHC3dKlxxdDh7Q1qo S4nlgg4/lFLKhXVN65iiOEOmNpKD0xM20hnlJ33jpKB3W78Fu1O2xr9JhR6aShS72adD 7ewf8cXffmNIFnIWJVZQr+9fIKgh/FvcUVnqmeWaqXkMRXhiMy1UWoAePf+EhAtgb3hZ dQ47Uss7CMZfRzSi8OEIjN42GQnv1zbsciWZuNmzi6CVgFTp3xU0EI1j+g04PMBwog4d mDnA== X-Gm-Message-State: AOAM531VmYafA3FNFD08p7mRRxgD/c0Nkl7Hk+5qPx+Ojb/2EQHOGdwU i2S2zpqZqXvmkBpmEmFDrZlryMm2FXI+HA== X-Google-Smtp-Source: ABdhPJybdp2h5rAIzXj3G2F0JSHjW/D4PRF6IGIXD+/VobGx+8b19g87XM0Zg6fN06AMffhrs3m/4g== X-Received: by 2002:a17:906:8147:: with SMTP id z7mr14659115ejw.436.1616762603502; Fri, 26 Mar 2021 05:43:23 -0700 (PDT) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id hy13sm3825296ejc.32.2021.03.26.05.43.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 05:43:23 -0700 (PDT) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Fri, 26 Mar 2021 12:43:20 +0000 Message-Id: <20210326124321.28617-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/1] Raspberry Pi generalised sensor metadata parsing X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi Here's a slightly revised version of this patch, following some conversations with Naush. The only significant difference is that we always get the exposure/gain values from the controls and post these into the RPi metadata as the "device.status".CamHelper::Prepare() is free to use these values, or to update them if it knows better. Thanks and best regards David David Plowman (1): ipa: raspberrypi: Use CamHelpers to generalise sensor metadata parsing src/ipa/raspberrypi/cam_helper.cpp | 51 ++++++++++++++++++ src/ipa/raspberrypi/cam_helper.hpp | 11 +++- src/ipa/raspberrypi/raspberrypi.cpp | 80 ++++++++++------------------- 3 files changed, 87 insertions(+), 55 deletions(-)