From patchwork Thu Mar 25 05:19:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 11702 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8FEFDC32E9 for ; Thu, 25 Mar 2021 05:19:44 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id DA15868D61; Thu, 25 Mar 2021 06:19:43 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="GBTUWx1x"; dkim-atps=neutral Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 139FE602D5 for ; Thu, 25 Mar 2021 06:19:42 +0100 (CET) Received: by mail-pj1-x102d.google.com with SMTP id kr3-20020a17090b4903b02900c096fc01deso432696pjb.4 for ; Wed, 24 Mar 2021 22:19:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7DVve7uN3/22l2/TEI2/V6w3gp4Nx9V1R9uEStnCBBs=; b=GBTUWx1xeMWFFP/Nos1plN9xM5xczoPuouKkum8CWWZFXF8mZNAlzs8VNusyxVvxnq UgFjXTs0a5V3HCJ3Y3zrdnd1Rr6R+w2FBTdJxRQ6JJqn6Gy4COjekSLk9xQxIURh9A6o Yb28bhdwUsPdEjTX1R4LUeiBeBW1+uDT7Vxk4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7DVve7uN3/22l2/TEI2/V6w3gp4Nx9V1R9uEStnCBBs=; b=TukBtaoBEsJm0xiwBdVrvWg0ipYVJX9GyRu+sleSAK8djiaCnWG3D+OyKFPQTA01Fz wHbsqMngX5eYHENIFnfYon2MMo6eM+YBSIEeVgrICRSIUEKIh6OwJLJDC5UYJIeApBio QQYK4X4n4f3/NYJCWoROPNrN4YX7CtNPbAncL0FtrWsjF8Dx0uD0Kk+qzJrlU84IrxLT IjmZY3dMhWbpCTlITh1OMTliEILhsBgYAzNsWrZfh1OkpKpywte43sr3EaydznDvgbOt EzLvLYKJ7nkzJHNa4n9WtEhZ5Blmpn41QImkd04T2SkGEx3fYNZm7dATCn9W+h1gvHwo fT0g== X-Gm-Message-State: AOAM532/tfjLCZ3X6zei0GAIOodswo8WSC+GDfxf/vAzPrLhXDSH9aDh Ml+iRiugdYkeU0+kDsDlt+z86glq9CqyfA== X-Google-Smtp-Source: ABdhPJxRR86kV/y7ImzG56MRg4819m6CfgYwiZNL9gbgwwwXwXnb2FoACuBuuKtvKNeY521glc0dLg== X-Received: by 2002:a17:90b:1047:: with SMTP id gq7mr4505526pjb.159.1616649580002; Wed, 24 Mar 2021 22:19:40 -0700 (PDT) Received: from hiroh2.tok.corp.google.com ([2401:fa00:8f:2:7c07:24cd:c637:7fab]) by smtp.gmail.com with ESMTPSA id fs9sm3999250pjb.40.2021.03.24.22.19.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 22:19:39 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Thu, 25 Mar 2021 14:19:28 +0900 Message-Id: <20210325051931.3748204-1-hiroh@chromium.org> X-Mailer: git-send-email 2.31.0.291.g576ba9dcdaf-goog MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/3] Regard crop_rotate_scale_degrees in configuration X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" A HAL client requests the demanded rotation by |crop_rotate_scale_degrees| in camera3_stream in configuration. Libcamera ignores it and doesn't handle the rotation request at all. This patch series still don't support it, but add the validation check to the rotation values and deny if a rotation is requested. Hirokazu Honda (3): android: CameraDevice: Validate crop_rotate_scale_degrees in configuration android: CameraDevice: Log rotation variables in camera3_stream android: CameraDevice: Deny non ROTATION_0 stream configuration src/android/camera_device.cpp | 59 +++++++++++++++++++++++++++++++++++ 1 file changed, 59 insertions(+) --- 2.31.0.291.g576ba9dcdaf-goog