From patchwork Wed Mar 24 15:01:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 11694 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 2F7C0C32E5 for ; Wed, 24 Mar 2021 15:01:34 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1CA4868D6C; Wed, 24 Mar 2021 16:01:33 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="KLg6KWkS"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id F37A5602E3 for ; Wed, 24 Mar 2021 16:01:30 +0100 (CET) Received: from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E989A580; Wed, 24 Mar 2021 16:01:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1616598090; bh=cgTKT3OuEpwiBKvIO92ouC6/3zQIKx28btdykUTBBMw=; h=From:To:Cc:Subject:Date:From; b=KLg6KWkSXEZrjUkOIpuCz5wUJKyCCJnhqH65Oqfjn4ixmNkWBmct3u0d7BPnD4ftW uHsGtRV2U260cIz8FV2vFXOYlYYmBDEEzwpqoxks+2F77DTCUlIzgecrKJKdIbonI4 6ca8P7S/9eficEcxn4iRF8LKSASoKZwODfif4Qr4= From: Kieran Bingham To: libcamera devel Date: Wed, 24 Mar 2021 15:01:19 +0000 Message-Id: <20210324150125.1318325-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/6] IPU3 Stability X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" A reduced set of patches from the previous iteration of the IPU3 Stability developments. Patches [1/6] and [2/6] are split from a test patch provided to me by Laurent, where I have added the commit messages. These ensure that messages sent by the IPA are handled correctly and do not race at stop() time Patch [3/6] was identified by valgrind and fixes an issue related to uninitialised accesses on the buffers. It has been reworked since v2. Patch [4/6] fixes the ordering of stopping the IPA and video devices, with [5/6] fixing an issue which previously completed requests (and associated frame info) before all buffers had completed. Finally patch [6/6] moves an asynchronous callback out of the synchronous configure() call, and into start(). This is not expected to be a substantial change in functionality currently, but should be considered in follow on developments with the IPA. Kieran Bingham (4): libcamera: buffer: Initialise status libcamera: pipeline: ipu3: Stop IPA before stopping devices libcamera: pipeline: ipu3: Do not mark metadata complete early ipa: ipu3: Do not set controls during configure Laurent Pinchart (2): utils: ipc: proxy: Assert asynchronous calls execute in the running state utils: ipc: proxy: Process pending messages include/libcamera/buffer.h | 2 +- src/ipa/ipu3/ipu3.cpp | 11 ++++++++--- src/libcamera/pipeline/ipu3/ipu3.cpp | 7 ++----- src/libcamera/request.cpp | 9 +++++++-- .../libcamera_templates/module_ipa_proxy.cpp.tmpl | 2 ++ .../libcamera_templates/proxy_functions.tmpl | 6 ++++-- 6 files changed, 24 insertions(+), 13 deletions(-)