From patchwork Wed Mar 24 07:07:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 11676 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7B887C32E7 for ; Wed, 24 Mar 2021 07:08:15 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6EC6A68D58; Wed, 24 Mar 2021 08:08:14 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="WNHYBZpj"; dkim-atps=neutral Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0865B68D58 for ; Wed, 24 Mar 2021 08:08:12 +0100 (CET) Received: by mail-pl1-x632.google.com with SMTP id v23so7423290ple.9 for ; Wed, 24 Mar 2021 00:08:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kGOIpyVb8rLtevdPcAnClUbOQz6sMO+W84Zf7wBl4hw=; b=WNHYBZpj/Yi6aK6qaEFB5EUU8fGogkBG+ZPCqVYcSaEMJn8fGqPdpPJZYmiPcNi3ip T+L6UHHcIuYgiTy+w4P0n+1xxBFdj6/H/JRIrXl6bRrd9rFcxcqhdBh20Y/Y9WHVjUFm gRugSvXt4paSjrLCR/NTJdSWDQgw/t26ziPQM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kGOIpyVb8rLtevdPcAnClUbOQz6sMO+W84Zf7wBl4hw=; b=Rlyu0g1ebtnYULKtNLssMTHNJiMvCI3uN/WVPvUlw1Y9RAyPVzV3ANn14lZ8SmP4N8 fUYWQCYIbyv5DrDujH2aqvglEZl+8l2z08SD7nC6Mum8gvliS9euVUf32j8gR+OiQn7v MHFK3dRiUNNsW0LxFXT6ZQR7QE1J03xXXiUBrCoQdpPQJOXUFS9xIG4pLeHx3cStaXmw 1M+HLKm5k927dgp9LkMmrdzdJUWhL4OSz3AhG+orPrZpAYLU6PhdfkjVaYAv04m8O0s1 SMI0Rf5yT65pHAM6D+Or/zYgb0rH23oovbTHp4tJeBqlB1ZRAd6KDPwoca8qgtgLxPPO Zjsg== X-Gm-Message-State: AOAM5302cXmylNfYHBLObPhhWVpfvBls+Hbv+8o/XUAb2w0FE4AQe8Ge Rpy7h+ubXlU2l0vhuj5T9xOTNxMV855FEw== X-Google-Smtp-Source: ABdhPJz6WrNfAMXo+2QyM164XZczoJTbUNFlbF2Hn75ldHjPZHaVB4d8kjJShJral74B76maU5O5Pg== X-Received: by 2002:a17:90b:3909:: with SMTP id ob9mr2063382pjb.181.1616569684584; Wed, 24 Mar 2021 00:08:04 -0700 (PDT) Received: from hiroh2.tok.corp.google.com ([2401:fa00:8f:2:7c07:24cd:c637:7fab]) by smtp.gmail.com with ESMTPSA id e63sm1246860pfe.208.2021.03.24.00.08.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Mar 2021 00:08:04 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Wed, 24 Mar 2021 16:07:49 +0900 Message-Id: <20210324070757.3530377-1-hiroh@chromium.org> X-Mailer: git-send-email 2.31.0.291.g576ba9dcdaf-goog MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/8] Improve pointer types in android HAL adaptation layer X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This patch series is intended to clarify the ownership of objects and omit manual new/delete code by improving pointer types in android HAL adaptation layer. The changes in v2: - Address Laurent's review comments. Hirokazu Honda (8): android: CameraHalManager: Hold CameraDevice with std::unique_ptr android: CameraHalManager: Hold CameraManager with std::unique_ptr android: CameraHalManager: Fix a function call of a moved Camera android: CameraDevice: Take shared_ptr in constructor android: CameraDevice: Return const shared_ptr& by camera() android: Camera3RequestDescriptor: Manage buffers with std::vector android: CameraDevice: Manage staticMetadata_ with std::unique_ptr android: CameraDevice: Manage requestTemplates_ with std::unique_ptr src/android/camera_device.cpp | 92 ++++++++++++------------------ src/android/camera_device.h | 19 +++--- src/android/camera_hal_manager.cpp | 25 +++----- src/android/camera_hal_manager.h | 4 +- 4 files changed, 57 insertions(+), 83 deletions(-) --- 2.31.0.291.g576ba9dcdaf-goog