From patchwork Tue Mar 23 14:36:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 11666 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B9937C32E5 for ; Tue, 23 Mar 2021 14:36:17 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1ECD768D66; Tue, 23 Mar 2021 15:36:17 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="cUdlu6KB"; dkim-atps=neutral Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 254F368D58 for ; Tue, 23 Mar 2021 15:36:16 +0100 (CET) Received: by mail-ed1-x52b.google.com with SMTP id x21so23711869eds.4 for ; Tue, 23 Mar 2021 07:36:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bygD49XaiNZehg9Z5HuoO8Y0qFE65Hqzqdsll/VNnBM=; b=cUdlu6KBW1zdVY7aBtJZA03AmYvDli39P7UxmisX1zlEQDibifkd5f9N4LN3BOIDTM eTvz9zxRrVx/spL3uW2CcLrRNp9pcCBv5UgLjF1QoCqV3k4AaTojxl7e0Lniju7bVqh/ 04g/6uO+3XwJPuXsxEiYpZh/ynrKcT5QORsjuo7GiYtEx8VgvKaPliUpmlM4RxH10Unw mfVYaQAcpmG7AhaQQB2WjEWCeemVhSyYPhJtP9dNC1JdVYw5DmBofsgPxBljFAh8L0cP WantaJCciJa77DN6u3YQ9E3YWQkOa9dpsydHbL7exK7Ue5uVA79BvE3xqu2JTlA7/VZc k2+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=bygD49XaiNZehg9Z5HuoO8Y0qFE65Hqzqdsll/VNnBM=; b=awU1x598ifgH//GdDyQfTmaHiy9pPamx/KNT1xQNZqJp+x6Yk2c+V2aBr1FRm2qGBB slLjqKZUvh3xOh+VzGI/IZlFM7ZJr2owk/f+YS6AdPsArW5KBFdrY4qWijyGtehbeBmA nbg9MsAmFtkfGsl/1ZEvYEo2jl2vAFFzDs5/PN7s8RQp2YPdVELIPOr+lXEkrewsrL+E 2F2I52YLKAqvm2GrwEqMSlEEFJ23XHfW5hdEK6hcwazEW2is4YioqPmQowpLG5950Ywj ZovIhoMZAGCcj0h6g83nwUDNZMBOBtUT8fCTJsb93Oly4UtfAlEUDMdqD2eOiP4x+17U HTiA== X-Gm-Message-State: AOAM531grqIyogcbHFinr6Bk63gl7eG3Uiqc8fgsN08512/ekf9u31Hh 4XuTQspmOsMYFK1rAdcX6Iozr05hxLNVXw== X-Google-Smtp-Source: ABdhPJz9hb03plm9w0D7Ug8IMtq3LFUfo3o3BKdywObapZ/xdhzG2rWBNScZQstk3mk2+zGgPl79Jw== X-Received: by 2002:a05:6402:35c8:: with SMTP id z8mr4860969edc.341.1616510175388; Tue, 23 Mar 2021 07:36:15 -0700 (PDT) Received: from naush-laptop.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id n6sm11282430eji.37.2021.03.23.07.36.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 07:36:14 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Tue, 23 Mar 2021 14:36:03 +0000 Message-Id: <20210323143610.787760-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/7] Raspberry Pi: ipa::init() restructuring X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, This version 3 of the series fixes the error introduced in v2 where the Unicam device nodes were not opened. Thanks, Naush Naushir Patuck (7): ipa: Add sensor model string to IPASettings pipeline: ipa: raspberrypi: Open the CamHelper on ipa::init() pipeline: raspberrypi: Conditionally open the embedded data node ipa: raspberrypi: Move the controller initialise to ipa::init() ipa: raspberrypi: Remove unused member variable ipa: raspberrypi: Rationalise parameters to ipa::start() ipa: raspberrypi: Rationalise parameters to ipa::configure() include/libcamera/ipa/core.mojom | 8 ++ include/libcamera/ipa/raspberrypi.mojom | 27 ++-- src/ipa/raspberrypi/raspberrypi.cpp | 110 +++++++-------- src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +- .../pipeline/raspberrypi/raspberrypi.cpp | 126 ++++++++---------- src/libcamera/pipeline/vimc/vimc.cpp | 2 +- test/ipa/ipa_interface_test.cpp | 2 +- 7 files changed, 118 insertions(+), 160 deletions(-)