From patchwork Thu Mar 18 12:55:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 11621 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D4301C32E1 for ; Thu, 18 Mar 2021 12:54:55 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2317468D60; Thu, 18 Mar 2021 13:54:55 +0100 (CET) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C649B602DB for ; Thu, 18 Mar 2021 13:54:53 +0100 (CET) X-Originating-IP: 79.22.58.175 Received: from uno.homenet.telecomitalia.it (host-79-22-58-175.retail.telecomitalia.it [79.22.58.175]) (Authenticated sender: jacopo@jmondi.org) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 1C7221BF204; Thu, 18 Mar 2021 12:54:52 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Thu, 18 Mar 2021 13:55:19 +0100 Message-Id: <20210318125521.43278-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/2] libcamera: Do not default the location property X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, we've been discussion about how to handle the camera location properly in libcamera and Android HAL. The current setup - defaults location to External in libcamera if the fw does not provide that - sets FRONT if location is External in Android Camera HAL This will make very complex to discern in future if a camera is actually external once the camera HAL will support the EXTERNAL HW level. To simplify this and make it easier to fallback to a getting location from a configuration file in the Camera HAL: - Do not report property::Location in libcamera if not available in fw - Do not default External to FRONT in HAL - To maintain compatibility with Android set location to FRONT if not available from the library in the Camera HAL. No regressions in CTS testing. Thanks j Jacopo Mondi (2): libcamera: camera_sensor: Do not register Location if not available android: camera_device: Do not default External to Front src/android/camera_device.cpp | 6 +----- src/libcamera/camera_sensor.cpp | 6 ++---- 2 files changed, 3 insertions(+), 9 deletions(-) --- 2.30.0