From patchwork Thu Mar 18 10:39:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 11613 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 9D5E4BD80C for ; Thu, 18 Mar 2021 10:39:18 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5836568D68; Thu, 18 Mar 2021 11:39:17 +0100 (CET) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8ABC86051E for ; Thu, 18 Mar 2021 11:39:15 +0100 (CET) X-Originating-IP: 79.22.58.175 Received: from uno.homenet.telecomitalia.it (host-79-22-58-175.retail.telecomitalia.it [79.22.58.175]) (Authenticated sender: jacopo@jmondi.org) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id AFD25C0003; Thu, 18 Mar 2021 10:39:14 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Thu, 18 Mar 2021 11:39:34 +0100 Message-Id: <20210318103941.18837-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/7] ipu3: imgu: Improve ImgU calculation procedure X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This series applies https://github.com/intel/intel-ipu3-pipecfg/commit/243d13446e44646c92118c0f0cb7fdc89b91f85c To the ImgU pipeline calculation. To recap: the current ImgU calculation procedure doesn't work if we select a sensor resolution smaller than the full frame size, and result in a stall in the ImgU producing frames, or in an error in finding any configuration at all. This set of improvements fixes some of the issues we had. In example, on Soraka $ cam -swidth=1280,height=720 -swidth=640,height=480 -c1 -C now works with a 2112x1188 frame input. Unfortunately other resolution remain broken, as in example main=1920x1080,vf=320x240. This can also be verified by running the python tool: $ python pipe_config.py input=2112x1188 main=1920x1080 vf=320x240 fatal IndexError: list index out of range So yes, some improvements, but commit Fixes: 7208e70211a6 ("libcamera: ipu3: Always use sensor full frame size") cannot be revereted yet. No regressions detected when running CTS. Thanks j Dave Olsthoorn (1): libcamera: ipu3: imgu: Change IF_CROP_MAX to 40 Jacopo Mondi (6): libcamera: ipu3: imgu: Update BDS calculation process libcamera: ipu3: imgu: Filter BDS by height libcamera: ipu3: imgu: Fix BDS height calculation libcamera: ipu3: imgu: Fix IF height selection libcamera: ipu3: imgu: Fix BSD height size comparison libcamera: ipu3: imgu: Add pipe calculation debug src/libcamera/pipeline/ipu3/imgu.cpp | 97 ++++++++++++++++++++++------ 1 file changed, 79 insertions(+), 18 deletions(-) --- 2.30.0