From patchwork Wed Mar 17 10:02:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 11600 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 372A9BD80C for ; Wed, 17 Mar 2021 10:02:23 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C31FA6084D; Wed, 17 Mar 2021 11:02:22 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="Iql9HoVv"; dkim-atps=neutral Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9AE8268D60 for ; Wed, 17 Mar 2021 11:02:20 +0100 (CET) Received: by mail-ej1-x636.google.com with SMTP id mm21so1559837ejb.12 for ; Wed, 17 Mar 2021 03:02:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=mfZ0d23pe5IarOaf9BIvzhVc0gMs567KtpB958J/pyI=; b=Iql9HoVvDfO/6jq9gjHc10tSk7Pr2RD+nDm9O3jPvVMFhzjddIKysgmjuzgoGQ/nQX UDNxQu2INkkg9dBESrU6S9VCHaQq9hdMPM4TwUWplUlK7noKFV4sBiN4JtmmFVQad90W snvPxyvfuAXiu++1+Suhb9dOg8udo9k/1Sm0cHO53+j2VV7H+zMdFjwcjeWcO1UwTtuq I9A13N9bcfwVqchbwNjdt7uRhZJa4GsnfrA+5+RdSHLo7gOlyKHavANNVuK3BPNujT3P ysaunGS0NgnBJToHmxGbSIRcaMKHPvgqtbiC4IZwYf3cfotAuC4BnhIuhNptaxkforFI KAHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=mfZ0d23pe5IarOaf9BIvzhVc0gMs567KtpB958J/pyI=; b=g453aYv9HnhetTZLg4mlLLDYqjQeCC1cJqwE+IvEplvQSnf3lak+tjjyfDExLejm7k tvmWHgmd+offjQyk4rYKMXbeBR3NqRI1WupBREI8v3JWF5W+RUg8rtemPY46kfhAUKhV q7WHmWdwCJYhD7384yZsHslTU+VhMPOdkXcZCloSwu9HQ6PQBlCBB0tOc5oOCwcquxK8 ajO9q9c2zb79OkvMPr0uBcrMvfbhQJCmYXLqTLMizlAwORXPNAsIxr9vikP4VBQb8ief A5rXRe3wORiefEzCmV0/yy0fOR7A2h4xj5fEGyVFXC+MzLlfZg6KNl6jTN4OQpQOQ6P5 KdZQ== X-Gm-Message-State: AOAM533CX1Iyr+Snc6oau43A1wut4mTKU1vuSVmpK+qFGyj/RlNj71Rd TANx75Ca2eUqC+J7aGDTiokq3L+2rKrliA== X-Google-Smtp-Source: ABdhPJysw2kQZ/ik6ckGyEUUIU3/qOI3MIZNRHWppn1NXOTkQdMiCWcdRMdMC6gcBzQIsgHzuxjYMw== X-Received: by 2002:a17:906:35cf:: with SMTP id p15mr34203641ejb.379.1615975337214; Wed, 17 Mar 2021 03:02:17 -0700 (PDT) Received: from naush-laptop.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id p24sm12061179edt.5.2021.03.17.03.02.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 03:02:16 -0700 (PDT) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Wed, 17 Mar 2021 10:02:04 +0000 Message-Id: <20210317100211.1067585-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/7] Raspberry Pi: ipa::init() restructuring X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, This series uses Paul's recent work and moves some initialisation code from ipa::configure() into ipa::init(). As a consequence, the pipeline handler is now able to selectively open the Unicam embedded data node in pipeline_handler::match(), removing some of the existing ugliness in dealing with opening this node. Brief patch breakdown: Patch 1/7: Adds the sensor model string to IPASettings. Patch 2/7: Moves the CamHelper initialise to ipa::init(). Patch 3/7: Conditionally open the embedded data node in pipeline_handler::match(). Patch 4/7: Move controller initialise to ipa::init(). Patches 5/7 - 7/7: Some tidy-ups (remove unused member variables, some renaming) after the above refactoring. Thanks, Naush Naushir Patuck (7): ipa: Add sensor model string to IPASettings pipeline: ipa: raspberrypi: Open the CamHelper on ipa::init() pipeline: raspberrypi: Conditionally open the embedded data node ipa: raspberrypi: Move the controller initialise to ipa::init() ipa: raspberrypi: Remove unused member variables ipa: raspberrypi: Rationalise parameters to ipa::start() ipa: raspberrypi: Rationalise parameters to ipa::configure() include/libcamera/ipa/core.mojom | 8 ++ include/libcamera/ipa/raspberrypi.mojom | 27 ++-- src/ipa/raspberrypi/raspberrypi.cpp | 110 +++++++-------- .../pipeline/raspberrypi/raspberrypi.cpp | 128 ++++++++---------- src/libcamera/pipeline/vimc/vimc.cpp | 2 +- test/ipa/ipa_interface_test.cpp | 2 +- 6 files changed, 119 insertions(+), 158 deletions(-) Tested-by: David Plowman