From patchwork Tue Mar 16 15:40:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 11589 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 325F1C32E1 for ; Tue, 16 Mar 2021 15:40:28 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 89FF168D4E; Tue, 16 Mar 2021 16:40:27 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Q5GZ8qI1"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 69C7F68D48 for ; Tue, 16 Mar 2021 16:40:26 +0100 (CET) Received: from localhost.localdomain (unknown [IPv6:2a01:e0a:169:7140:f840:1816:ba68:a009]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E9EE68C8; Tue, 16 Mar 2021 16:40:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1615909226; bh=/gYIweVsYfXzXqvNIgBg3sXrJnKJB+zUPjsJPRs2jIc=; h=From:To:Cc:Subject:Date:From; b=Q5GZ8qI1ptg9bxGdyOPkmvH+1xskMrk9zEAdgBFaA/PrykmW2VKyZRWvRuYjD7yq0 buXE3NRhvzh+LTOr1xYZPedBHKpZ/DlZZW6tihNGq59vxkAjuTgYYf4+E7oErAdPkf a9IPjoBSmD6ezb0ug331CwrOLOVEGn8PrVG1S+VI= From: Jean-Michel Hautbois To: libcamera-devel@lists.libcamera.org Date: Tue, 16 Mar 2021 16:40:21 +0100 Message-Id: <20210316154023.46033-1-jeanmichel.hautbois@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 0/2] Prepare IPU3 pipeline to pass BDS to IPA X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The IPA will need to use the BDS configuration because it configures a grid to get AWB statistics from the firmware. Those statistics are then used to apply a bunch of parameters. The ipa was configured at start(), configuring it when all the pipeline is configured sounds better. Jean-Michel Hautbois (2): libcamera: ipu3: Move ipa configuration from start() to configure() libcamera: ipu3: Pass the BDS rectangle at IPA configure call include/libcamera/ipa/ipu3.mojom | 2 +- src/ipa/ipu3/ipu3.cpp | 7 +++++-- src/libcamera/pipeline/ipu3/ipu3.cpp | 8 ++++---- 3 files changed, 10 insertions(+), 7 deletions(-)