From patchwork Tue Mar 16 14:47:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 11585 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 659F3BD80C for ; Tue, 16 Mar 2021 14:47:20 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8DF6168D49; Tue, 16 Mar 2021 15:47:19 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="mfCuWddp"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 2DAB56084F for ; Tue, 16 Mar 2021 15:47:18 +0100 (CET) Received: from localhost.localdomain (unknown [IPv6:2a01:e0a:169:7140:f840:1816:ba68:a009]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A0B4E8C8; Tue, 16 Mar 2021 15:47:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1615906037; bh=5KGlIea5fiG7J9ig4c2LboUavOCqGihVgqsHDX7JFo4=; h=From:To:Cc:Subject:Date:From; b=mfCuWddpCtToLfGK7JO0TG1TxMzFE1ZH6sZ7Hi3FthVN1twNVHMcRu43IylVvplMy B6h7f8LWgEtUr6+9GusslkwceVkmDQd6o0EIiVh6jQdJlhjU3i+8YTmeLnAsxsfL8g dlxj/0aZ3gGIJWUbowJHefTmXJu6YgTJTb947XZ0= From: Jean-Michel Hautbois To: libcamera-devel@lists.libcamera.org Date: Tue, 16 Mar 2021 15:47:08 +0100 Message-Id: <20210316144711.40778-1-jeanmichel.hautbois@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/3] Prepare IPU3 pipeline to pass BDS to IPA X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" As said in patch [1/2] the IPA will need to use the BDS configuration because it configures a grid to get AWB statistics from the firmware. Those statistics are then used to apply a bunch of parameters. The IPU3 pipe configuration was done in validate(), so moved it to configure(). And the ipa was configured at start(), configuring when all the pipeline is configured sounds better. Jean-Michel Hautbois (3): libcamera: ipu3: Move Imgu configuration to IPU3CameraData libcamera: ipu3: Move ipa configuration from start() to configure() libcamera: ipu3: Pass the BDS rectangle at IPA configure call include/libcamera/ipa/ipu3.mojom | 2 +- src/ipa/ipu3/ipu3.cpp | 7 +++-- src/libcamera/pipeline/ipu3/ipu3.cpp | 46 +++++++++++++--------------- 3 files changed, 28 insertions(+), 27 deletions(-)