From patchwork Tue Mar 16 10:18:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 11580 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 85A5FBD80C for ; Tue, 16 Mar 2021 10:18:46 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3D21A68D48; Tue, 16 Mar 2021 11:18:46 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="BB+p5IzP"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B4CB7602E8 for ; Tue, 16 Mar 2021 11:18:44 +0100 (CET) Received: from localhost.localdomain (unknown [IPv6:2a01:e0a:169:7140:f840:1816:ba68:a009]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 59456D8B; Tue, 16 Mar 2021 11:18:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1615889924; bh=VdKmdfqc2Stxcm50y2CSO546uxh9z15AxPdXCBv9MUE=; h=From:To:Cc:Subject:Date:From; b=BB+p5IzPhc1gu9p8wwU66hidIA9Zdr+2oLPZYuS+q6ZTNRNS0sk4w6werQKzjc0N9 dpolxEfX3043XecRzULSCW+WmNDcLfjNQRo4D06HBvqp9Noo559xbMFajjw9Bsui45 3WhNLh57A1vR+uDZD2PzLBmBS0jQjm72hE7W76YE= From: Jean-Michel Hautbois To: libcamera-devel@lists.libcamera.org Date: Tue, 16 Mar 2021 11:18:37 +0100 Message-Id: <20210316101842.18674-1-jeanmichel.hautbois@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/2] Prepare IPU3 pipeline to pass BDS to IPA X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" As said in patch [1/2] the IPA will need to use the BDS configuration because it configures a grid to get AWB statistics from the firmware. Those statistics are then used to apply a bunch of parameters. The IPU3 pipe configuration was done in validate(), so moved it to configure(). And the ipa was configured at start(), configuring when all the pipeline is configured sounds better. Jean-Michel Hautbois (2): libcamera: ipu3: Move Imgu configuration to IPU3CameraData libcamera: ipu3: Pass the BDS rectangle at IPA configure call include/libcamera/ipa/ipu3.mojom | 2 +- src/ipa/ipu3/ipu3.cpp | 7 +++-- src/libcamera/pipeline/ipu3/ipu3.cpp | 46 +++++++++++++--------------- 3 files changed, 27 insertions(+), 28 deletions(-)