From patchwork Fri Mar 12 13:03:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean-Michel Hautbois X-Patchwork-Id: 11569 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C51F5BD1F1 for ; Fri, 12 Mar 2021 13:03:10 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id BFE1868C69; Fri, 12 Mar 2021 14:03:09 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="q8kro43W"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B11668AA1 for ; Fri, 12 Mar 2021 14:03:08 +0100 (CET) Received: from localhost.localdomain (unknown [IPv6:2a01:e0a:169:7140:ddbd:a3a3:e47b:e390]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2ECCEA2A; Fri, 12 Mar 2021 14:03:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1615554188; bh=mqh+5ZAmLbQ19lAzu8PPxPNq7T8HcfKg7xelx8AsLbY=; h=From:To:Cc:Subject:Date:From; b=q8kro43WBI/f1YmQzTqcINO0lr+VXCihj8HDRnTTQQeA5kNIRpa5PBhaAaf7m/bhL ydw/DkyIVU+9XGuiJXkrp7dME3RFuCSfhGlOD+ZD5EldlY4zPmdLYLZZKKfdDy5swD 5JiydGqIeHN+Oyin7BiATGtGkz9Vo84bXMJ0xrqU= From: Jean-Michel Hautbois To: libcamera-devel@lists.libcamera.org Date: Fri, 12 Mar 2021 14:03:02 +0100 Message-Id: <20210312130304.34698-1-jeanmichel.hautbois@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/2] Prepare IPU3 pipeline to pass BDS to IPA X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" As said in patch [1/2] the IPA will need to use the BDS configuration because it configures a grid to get AWB statistics from the firmware. Those statistics are then used to apply a bunch of parameters. This is one fast and easy way to do it, but probably not the best call. The main issue is probably removing the 'const' from data_ in IPU3CameraConfiguration. As I need the BDS to continue my AWB/AGC implementation, and don't want to be blocked for too long, I am using this for the moment :-). Jean-Michel Hautbois (2): libcamera: ipu3: Move Imgu configuration to IPU3CameraData libcamera: ipu3: Pass the BDS rectangle at IPA configure call include/libcamera/ipa/ipu3.mojom | 2 +- src/ipa/ipu3/ipu3.cpp | 7 +++++-- src/libcamera/pipeline/ipu3/ipu3.cpp | 17 ++++++++++------- 3 files changed, 16 insertions(+), 10 deletions(-)