From patchwork Tue Mar 9 08:52:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 11531 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8ED50BD1F1 for ; Tue, 9 Mar 2021 08:52:48 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id EA7EA68A92; Tue, 9 Mar 2021 09:52:47 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="W0iLndt5"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 2E1386051F for ; Tue, 9 Mar 2021 09:52:46 +0100 (CET) Received: from pyrite.rasen.tech (unknown [IPv6:2400:4051:61:600:2c71:1b79:d06d:5032]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 77928E9; Tue, 9 Mar 2021 09:52:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1615279965; bh=RHOjN9jdcQGyMUmgDlZj6c6w0pu50vlQe/6DlfQFci4=; h=From:To:Cc:Subject:Date:From; b=W0iLndt5tXgV0Qr8YjyfQIrIHjqE+sa791P18oT6x7F1Fl6KVO1Zl4Pl/HDpoZp3X jYpSF0x0ezu67T27TVuPb2xRPMys31xwacIvA9PhzsXcMMpyeqwE2wQ81FguSBirus rFmIaGho5NuTjos9tvZ5Pk1Ppblh2ZZDSoE/tYVw= From: Paul Elder To: libcamera-devel@lists.libcamera.org Date: Tue, 9 Mar 2021 17:52:31 +0900 Message-Id: <20210309085235.106691-1-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/4] android: jpeg: exif: Fix GPS altitude X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This patch series fixes the following CTS test: - android.hardware.cts.CameraTest#testJpegExif Patch 1/4 fixes setRational(), which was causing setting the GPS altitude to fail. Patches 3/4 and 4/4 also contribute fixes to get the above test to pass. Patch 2/4 is a cleanup patch that is enabled by expanding setRational() in patch 1/4. Changes in v2: - use Span - keep undefined format type in GPS method Paul Elder (4): android: jpeg: exif: Fix and expand setRational android: jpeg: exif: Simplify setGPSDateTimestamp and setGPSDMS android: jpeg: exif: Fix setGPSLocation longitude android: jpeg: exif: change GPS method encoding from ASCII to NoEncoding src/android/jpeg/exif.cpp | 44 ++++++++++++++++----------------------- src/android/jpeg/exif.h | 2 ++ 2 files changed, 20 insertions(+), 26 deletions(-)