From patchwork Mon Mar 8 22:39:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 11521 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5081DBD1F1 for ; Mon, 8 Mar 2021 22:39:47 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id BAE0B602ED; Mon, 8 Mar 2021 23:39:46 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="Swu426NM"; dkim-atps=neutral Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8C1F0602ED for ; Mon, 8 Mar 2021 23:39:45 +0100 (CET) Received: by mail-wm1-x334.google.com with SMTP id u187so433516wmg.4 for ; Mon, 08 Mar 2021 14:39:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BOL3EybAnPMaF02qyBHRwaZ1MxOVKeIC5RqirpE6n9c=; b=Swu426NMKWx/Lc2Oxy5RYNM1FqIxA5kbqsOBmCD0VUpLRLI+G1ojOj90MeDPV/u43t 9VwA2HEk1QoT+dz+p5Mv9I0rpaeBFgNPqHtRdGyLW4gUvL/oclnipss8yBKnzpNbO6CN i/gwkibUmMGdPDCX39ypTnq7Pk0aZpSzxdf88et8HyrcIjo7rQMzhvtXMuo01uEEXQGX O9WlvINH7rvt+RK2FEpMGtdipJyEiMN+RiWBrwq8aYz+ghnrgx2Z/wpBhc31lMWqaBQZ n6wesjXTqgz5l4w+Nwwn12ENey5iUGYjdzn9jvN2qe0D9+lGJNaS/wnpVmRW4mZiVP0C LtbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BOL3EybAnPMaF02qyBHRwaZ1MxOVKeIC5RqirpE6n9c=; b=YsdH68aOPNFOAO9UcsK8BLq7rsmGdOoP2Mui2mI7qPYq0Rgw/Frvg2V/MljWGHHGfZ FXTcdMB1PB6h8wYucK4UjBRZQD2KvcvkPd+Cp8oQjcvkCtpCTNNYmGZWPSv+A8GdnqTE 4C4tsBPQ8A27zuZeb+YbyPcdTsxqHsqBjqJ3jsrY/sd2urs9fn9Hu0U4HHxnyc2wItyR ljxWhzYPavd/LwuDcmVt66VecNlcSP+sMxgMh6iKJSlrIYRUHMAcRZVGj3Qe3rCs1ipH 01Xp9hKuNjAp29pikL8QZojC8lKQBUIC35Or0EO1KDpmGao2aaPnGd6Ik765C4E8CMkv Aj+g== X-Gm-Message-State: AOAM533QNYMTiRsvF2/RsnWS+ErFCvNj5uuncF4cxm7zUDXcKiqjrSKx stGBu5GanqgGV8XyOTkYkyfmx/r+mtRlYw== X-Google-Smtp-Source: ABdhPJxiBlWYESVc+SW5P/p7ek7uqHrKf7hIUdzqUeirOzh0R1U4Y5p2jGmg9dJLTdFgH+cRn/wOOA== X-Received: by 2002:a05:600c:35cd:: with SMTP id r13mr892679wmq.186.1615243185000; Mon, 08 Mar 2021 14:39:45 -0800 (PST) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id f17sm19811322wru.31.2021.03.08.14.39.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 14:39:44 -0800 (PST) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Mon, 8 Mar 2021 22:39:36 +0000 Message-Id: <20210308223939.2088-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/3] Raspberry Pi support for new sensors X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi again everyone Thanks to Laurent for reviewing the previous version of this set. Here's a version 2, taking account of his comments. The differences are: 1. In the first patch some stray comment lines have been deleted. 2. In the second patch, files have been ordered alphabetically. 3. There's a new 3rd patch, which edits the raspberrypi.mojom file so that the vblank field in the SensorConfig is more accurately named vblankDelay. Thanks and best regards David David Plowman (3): ipa: raspberrypi: Make CamHelpers return the frame delay for vblanking ipa: raspberrypi: Add support for imx290/imx327 sensors ipa: raspberrypi: Rename vblank field in SensorConfig to vblankDelay include/libcamera/ipa/raspberrypi.mojom | 2 +- src/ipa/raspberrypi/cam_helper.cpp | 4 +- src/ipa/raspberrypi/cam_helper.hpp | 11 +- src/ipa/raspberrypi/cam_helper_imx290.cpp | 67 +++++++ src/ipa/raspberrypi/cam_helper_imx477.cpp | 7 +- src/ipa/raspberrypi/cam_helper_ov5647.cpp | 7 +- src/ipa/raspberrypi/data/imx290.json | 165 ++++++++++++++++++ src/ipa/raspberrypi/data/meson.build | 1 + src/ipa/raspberrypi/meson.build | 1 + src/ipa/raspberrypi/raspberrypi.cpp | 6 +- .../pipeline/raspberrypi/raspberrypi.cpp | 2 +- 11 files changed, 258 insertions(+), 15 deletions(-) create mode 100644 src/ipa/raspberrypi/cam_helper_imx290.cpp create mode 100644 src/ipa/raspberrypi/data/imx290.json Reviewed-by: Laurent Pinchart Reviewed-by: Naushir Patuck