From patchwork Thu Mar 4 08:17:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 11486 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D2152BD1F1 for ; Thu, 4 Mar 2021 08:17:38 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2EDF268A91; Thu, 4 Mar 2021 09:17:38 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="ekzu/+V4"; dkim-atps=neutral Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 092DC602EC for ; Thu, 4 Mar 2021 09:17:36 +0100 (CET) Received: by mail-wr1-x432.google.com with SMTP id e10so26348121wro.12 for ; Thu, 04 Mar 2021 00:17:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pac/QsOM8/taIbYsIjRK5rzzPFKOpOs2V4LFZ0P0+IM=; b=ekzu/+V46iLg162iiUG5gJbd6psXS8CMmTxAyM6lp76T4uB7y93Owcbzyfc1DsHWbf pRMokHVuR+4Vjq7fINMxmgvh+hr+qqtiPw6/eDNjNZsYTUGIe7gfH/e6+2YyJmn8lEmr AN1Te2V5lCruHUwOG3lvtE0a7rH26e1MA/kFbZqs2GNhtbB4Pt50txla+9v521wdfQTG OH0BY3DFtIiZUAf5Z2YW2p1laDk5A6zdhIiRMxPIVRPAO61GorK1Zor3u2m2UVKqjZzt q5EWz9dQGT1jTWMDOVAtiOdceQMRdztLd8il9QTkF+pO6hjcdvio8W2fd+XE5hbRLKZM R8CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pac/QsOM8/taIbYsIjRK5rzzPFKOpOs2V4LFZ0P0+IM=; b=Yvw6cLuNPXEdWjE0askOt1mfQiBKaSeY1wq+k7EdyT7Qjby/J8PyNXheXyi2AXpAgm SCmyeKo/w+ors+yePLnoF3Hbyj0TzkL6Py7EpWwdzPYKXPK7VptFS3glsvDS3xpPkioG 8DDO1JbikYuGnYphrmEK72Uc2/UAPPZ2Dq+FwJGLF2M1EZJ0ZCgo9yuqnOLowsrwz6P9 7I8IVVbT9P/5AysQrguUfkPDaTe7PDXJ/1kLzWuvPyq/uxh0upZH3WWPivo8K68TK4aQ 9CJdtcTLNRLTr/4uO6OlezW1QN6xWF4xM+UfViJAWAJPakrfyoc3hPZl2myWSQe6m6h3 0QpA== X-Gm-Message-State: AOAM5302nh2s2vpahkhZOU/Nx357TM9NbVAaDA/5gc900uuwS0ISZjIs jJrexW87P50xwq1GlYX9m4OrejPBkmPwNgRV X-Google-Smtp-Source: ABdhPJydI1z11EqtT4uVz9h2hLyoVr9MIY4gtY4m+qgBiZhEZYr1mFI7lFU164ltgMPCQXteByjzZw== X-Received: by 2002:a5d:548c:: with SMTP id h12mr2773091wrv.46.1614845855265; Thu, 04 Mar 2021 00:17:35 -0800 (PST) Received: from naush-laptop.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id b186sm6997926wmc.44.2021.03.04.00.17.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Mar 2021 00:17:34 -0800 (PST) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Thu, 4 Mar 2021 08:17:21 +0000 Message-Id: <20210304081728.1058394-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 0/7] DelayedControls updates and fixes X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, This version (v4) of the patch series adds two further commits to v3. Patches 1 to 5 are identical to v3, except that I have added a line to the commit messages saying the change would break the unit tests because of a change in the logic of the helper. Patch 6 updates the unit tests with the correct behavior. Unfortunately, my attempts to get vimc working on my platform did not end well, so I made a local mod to run the tests with a physical camera device. All tests do pass, but I would appreciate if somebody else could run this again with the vimc device to verify everything is passing. Patch 7 simply fixes a typo in the unit test filename. Thanks, Naush Naushir Patuck (7): libcamera: delayed_controls: Add notion of priority write utils: raspberrypi: Add a DelayedControls log parser libcamera: delayed_controls: Remove unneeded write when starting up libcamera: delayed_controls: Remove spurious no-op queued controls libcamera: delayed_controls: Fix off-by-one error in get() test: delayed_controls: Fixup tests after recent DelayedControls changes test: delayed_controls: Rename delayed_contols.cpp to delayed_controls.cpp include/libcamera/internal/delayed_controls.h | 13 +- src/libcamera/delayed_controls.cpp | 74 ++++++++---- src/libcamera/pipeline/ipu3/ipu3.cpp | 8 +- .../pipeline/raspberrypi/raspberrypi.cpp | 13 +- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 8 +- ...layed_contols.cpp => delayed_controls.cpp} | 51 +++++--- test/meson.build | 2 +- utils/raspberrypi/delayedctrls_parse.py | 111 ++++++++++++++++++ 8 files changed, 219 insertions(+), 61 deletions(-) rename test/{delayed_contols.cpp => delayed_controls.cpp} (84%) create mode 100644 utils/raspberrypi/delayedctrls_parse.py Reviewed-by: Paul Elder Reviewed-by: Kieran Bingham