From patchwork Thu Feb 25 17:12:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dafna Hirschfeld X-Patchwork-Id: 11383 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id EBF0FBD808 for ; Thu, 25 Feb 2021 17:12:14 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 11E8A68A56; Thu, 25 Feb 2021 18:12:14 +0100 (CET) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D5B0368A48 for ; Thu, 25 Feb 2021 18:12:12 +0100 (CET) Received: from guri.fritz.box (p200300c7cf1cce00c495f7eb403f1d15.dip0.t-ipconnect.de [IPv6:2003:c7:cf1c:ce00:c495:f7eb:403f:1d15]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dafna) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 2F7E11F46356; Thu, 25 Feb 2021 17:12:12 +0000 (GMT) From: Dafna Hirschfeld To: libcamera-devel@lists.libcamera.org Date: Thu, 25 Feb 2021 18:12:02 +0100 Message-Id: <20210225171205.23341-1-dafna.hirschfeld@collabora.com> X-Mailer: git-send-email 2.17.1 Subject: [libcamera-devel] [PATCH v2 0/3] rkisp1: add an initial support to different hw revision X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel@collabora.com MIME-Version: 1.0 Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" In kernel v5.11 the rkisp1 uapi had changed to support different hardware versions. See [1] This patchsets updates the uapi header and adds support to hardware version 10 only. In the future we want to add support to version V12. See revisions documentation at [2]. The patchset is based on v8 of the 3 IPA isolation patchsets. [1] https://patchwork.kernel.org/project/linux-media/list/?series=419197 [2] https://www.kernel.org/doc/html/latest/admin-guide/media/rkisp1.html?highlight=revisions#revisions Changes from v1: - compilation fix in patch 3 that I forgot to update in first version - typo fixes - in patch 2, if 'configure' of the rkisp1 IPA fails return -EINVAL - in patch 3, if hw revision is not supported, return -ENODEV Dafna Hirschfeld (3): libcamera: media_device: add hwRevision method src: rkisp1: return error from ipa's configure method if it fails ipa: rkisp1: update the uapi to the latest kernel version include/libcamera/internal/media_device.h | 2 + include/libcamera/ipa/rkisp1.mojom | 4 +- include/linux/rkisp1-config.h | 88 ++++++++++++++++++++--- src/ipa/rkisp1/rkisp1.cpp | 23 ++++-- src/libcamera/media_device.cpp | 1 + src/libcamera/pipeline/rkisp1/rkisp1.cpp | 8 ++- 6 files changed, 104 insertions(+), 22 deletions(-)