From patchwork Wed Feb 24 09:48:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 11370 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 03D4ABD808 for ; Wed, 24 Feb 2021 09:48:49 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 40B8C68A33; Wed, 24 Feb 2021 10:48:49 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Pz7N2Ag0"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F4796040F for ; Wed, 24 Feb 2021 10:48:47 +0100 (CET) Received: from pyrite.rasen.tech (unknown [IPv6:2400:4051:61:600:2c71:1b79:d06d:5032]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0C72C8A1; Wed, 24 Feb 2021 10:48:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1614160127; bh=HeNOBuQ+2FVi3QzJNGuQ5nSH7S9TKwQC2ZSSriyFzTg=; h=From:To:Cc:Subject:Date:From; b=Pz7N2Ag0VTa4nCja9VO3btdNcfHnD+OpPJT0SK86eHT5LCO3igJ+A3ccXq3Qh7fH2 QdxGjGCbykqCZ8NGI+ybqd5s35Kns6s67BcLyFhb8zku0EAKzS77ITO+JqG19/3ty5 cOT9s0iCQWIgOSuKpmt4cAHO3u2teIYs4bAImQG8= From: Paul Elder To: libcamera-devel@lists.libcamera.org Date: Wed, 24 Feb 2021 18:48:30 +0900 Message-Id: <20210224094833.24219-1-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/2] Fix camera location X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" libcamera defaults the location of cameras with no V4L2 camera orientation control to external. Our android HAL implementation currently doesn't support external cameras, so the CTS test "android.hardware.camera2.cts.CameraManagerTest#testCameraManagerGetDeviceIdList" will fail when cameras have a location of external. The long-term solution is to make sure that the orientation is declared in the firmware. In the meantime, this patch series makes libcamera print a warning when the location is defaulted to external, and makes the HAL implementation change it to front. Paul Elder (2): libcamera: camera_sensor: Print warning when orientation is unknown android: camera_device: Set the camera location to Front if External src/android/camera_device.cpp | 6 +++++- src/libcamera/camera_sensor.cpp | 23 +++++++++++++++++++++-- 2 files changed, 26 insertions(+), 3 deletions(-)