From patchwork Mon Feb 22 08:01:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 11351 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D0EB8BD1F6 for ; Mon, 22 Feb 2021 08:01:31 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2E246689F9; Mon, 22 Feb 2021 09:01:31 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="aI3SxTWo"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5AE41689EA for ; Mon, 22 Feb 2021 09:01:30 +0100 (CET) Received: from pyrite.rasen.tech (unknown [IPv6:2400:4051:61:600:2c71:1b79:d06d:5032]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C012C344; Mon, 22 Feb 2021 09:01:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1613980890; bh=KhD+xQZVfBUc04sF7JtRzdoTt8bBDez5DTwfL5KgwT4=; h=From:To:Cc:Subject:Date:From; b=aI3SxTWohbUv1axg11teiwWBWzkDrmXYsnRdsebWbMs/2NoEdwqlOTfEpGgYR7FUk SuB4vvfpkrALyPoL27RUZBaFNz6vC8DESrBHP8A6dqfoKOzHW5ET/S0p7GK0g7vsJD GFMQ0hHb9Ec270qSNW/UceNvdM+MS6C/xXHol8lQ= From: Paul Elder To: libcamera-devel@lists.libcamera.org Date: Mon, 22 Feb 2021 17:01:10 +0900 Message-Id: <20210222080112.72521-1-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/2] Fix camera location X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" libcamera defaults the location of cameras with no V4L2 camera orientation control to external. Our android HAL implementation currently doesn't support external cameras, so the CTS test "android.hardware.camera2.cts.CameraManagerTest#testCameraManagerGetDeviceIdList" will fail when cameras have a location of external. The long-term solution is to make sure that the orientation is declared in the firmware. In the meantime, this patch series makes libcamera print a warning when the location is defaulted to external, and makes the HAL implementation change it to front. Paul Elder (2): libcamera: camera_sensor: Print warning when orientation is unknown android: camera_device: Set the camera location to Front if External src/android/camera_device.cpp | 6 +++++- src/libcamera/camera_sensor.cpp | 6 ++++++ 2 files changed, 11 insertions(+), 1 deletion(-)