From patchwork Mon Feb 15 10:11:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 11294 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id EECF9BD162 for ; Mon, 15 Feb 2021 10:12:13 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 56070637BE; Mon, 15 Feb 2021 11:12:13 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="r2E0m0iR"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 603586375F for ; Mon, 15 Feb 2021 11:12:12 +0100 (CET) Received: from pyrite.rasen.tech (unknown [IPv6:2400:4051:61:600:2c71:1b79:d06d:5032]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BEFE3743; Mon, 15 Feb 2021 11:12:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1613383932; bh=csJP6ii1v+cENXSptZrMhhXHIyms2n9a91HTih1qaxQ=; h=From:To:Cc:Subject:Date:From; b=r2E0m0iRmlPmdXP1+otiReU9zyU8CQIctFy6YZSh0maaCzEIAK3URVTnP1hDrrUsW yd/dWOcrxOulgrTztlP71AcSg6CluORZ8SW4yg6jNW2PtiQ6/IiRTtyRSOhZEdGcXQ fNtbhyNxRxGGfugK6AYYJp1Nuv8lrT0ANHBvThoU= From: Paul Elder To: libcamera-devel@lists.libcamera.org Date: Mon, 15 Feb 2021 19:11:56 +0900 Message-Id: <20210215101200.149457-1-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/4] Add Unknown camera location X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add Unknown camera location to libcamera, set it to default, and set the android camera location to Front in this case. This allows the following CTS test to pass: - android.hardware.camera2.cts.CameraManagerTest#testCameraManagerGetDeviceIdList Changes in v3: - report the location as unknown in cam - print warning in hal when defaulting to front from unknown Changes in v2: - change Unknown to 0 in the num, and shift the others by one - handle Unknown location in cam Paul Elder (4): libcamera: properties: Add Unknown value to camera Location libcamera: camera_sensor: Set default sensor location to Unknown android: camera_device: Default the camera location to Front cam: Print unknown location src/android/camera_device.cpp | 5 +++++ src/cam/main.cpp | 8 ++++++-- src/libcamera/camera_sensor.cpp | 2 +- src/libcamera/property_ids.yaml | 10 +++++++--- 4 files changed, 19 insertions(+), 6 deletions(-)