From patchwork Wed Feb 10 11:17:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 11206 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1DB5EBD160 for ; Wed, 10 Feb 2021 11:17:50 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6D9E26162A; Wed, 10 Feb 2021 12:17:49 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="kY1yg+c4"; dkim-atps=neutral Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5C703602FE for ; Wed, 10 Feb 2021 12:17:48 +0100 (CET) Received: by mail-ed1-x534.google.com with SMTP id df22so2498338edb.1 for ; Wed, 10 Feb 2021 03:17:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=59DlWgZCm6Y29OEG2yLUZWG39HVBLJ4AkFpWrJlhEto=; b=kY1yg+c4xLbDeGM6b7iLU+4/o6Y5EYo00d0Q79PJG2+h9V2U+KwVz0TtSwz25vbKpC WqXoYzx3Aj3tHtyqwrxLXBPU84dEbQ8mea6K9k8Lt/BmFHa4alcgWNjz3t160lllis5G 8OHWuNs/4S1iZOuUkPolSfzsYS5GZT9hIHlKKugTOIwdWRIv8lvkekNleSsTumcP6N+A jf/J+3Gh2CsIGOG5ZTiZblQpxh1JYm/WZOq2eS7jv2F8qM9H35KA1xs+EcFiWJs0d7gk 9E6JLG6PkHzg6mD4P6xpPXTaSVwUwpmCpnAiwztEG72uy5ggvjaJ3Na1UDRi/vH1CKY1 PHqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=59DlWgZCm6Y29OEG2yLUZWG39HVBLJ4AkFpWrJlhEto=; b=HeRfaN2STrf72/CpIuB7b5la/Nfj6tf1BiNU7TRjcZlT6DBM9R3CZByzKT6yZv7FKu JgTf7TsH0L36tVRO78UyI++iTFmdstoU/2gYn51+QsHrTl8k1tG0JmNharQS1m9u1EnI hzCuR/JiaY/LIWw5vHLPwONpP+vd3eLWtvS46qdErceEeREP84MKuRseUIBx6BHxeHww wZr64IOwkXtIUkTk9vKWEZagszgN5saoJUNRCyvImFgxXJK55yY1ISnztIveMVZDYfIV oVPqppu8wTXGKTr3MvHpcbFhDy4RIZW89Ij40E0TCzFM+JyzpSqTqb4asXw5c+2/Vm85 4X+w== X-Gm-Message-State: AOAM533xrVX1ijjTzR0rHOjaox8kq/zAk9MTo7ioXZR9p7QtvrUTXsR+ e7z4gFC8qEY34+I2JxWTUd5KQ23kOiqRiVwS X-Google-Smtp-Source: ABdhPJyQYagkw54re3S6Hc3mQocs8qCODXJwpJTCO1iVnl5XfxnSF0aSiK37ZO4wY13XubYJ5ESEAw== X-Received: by 2002:aa7:c685:: with SMTP id n5mr2791851edq.150.1612955867706; Wed, 10 Feb 2021 03:17:47 -0800 (PST) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id dt17sm892659ejb.70.2021.02.10.03.17.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 03:17:47 -0800 (PST) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Wed, 10 Feb 2021 11:17:41 +0000 Message-Id: <20210210111743.14374-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/2] Raspberry Pi AWB race condition and maintenance X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi everyone Really I just wanted to fix the race condition that Laurent pointed out a few days ago, but as I looked through the code I also felt I should remove another unnecessary variable which was just a hangover from a previous time. Hopefully this is the last set of small-ish AWB fix-ups for now! Thanks David David Plowman (2): ipa: raspberrypi: AWB: Remove unecessary frame count variable ipa: raspberrypi: AWB: Fix race condition setting manual gains src/ipa/raspberrypi/controller/rpi/awb.cpp | 82 ++++++++++------------ src/ipa/raspberrypi/controller/rpi/awb.hpp | 1 - 2 files changed, 38 insertions(+), 45 deletions(-)