From patchwork Mon Feb 8 23:47:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Niklas_S=C3=B6derlund?= X-Patchwork-Id: 11200 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0B3AABD162 for ; Mon, 8 Feb 2021 23:47:56 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4E5D56148F; Tue, 9 Feb 2021 00:47:55 +0100 (CET) Received: from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net [195.74.38.227]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C4BD3601AB for ; Tue, 9 Feb 2021 00:47:53 +0100 (CET) X-Halon-ID: 0c9dd88b-6a68-11eb-a076-005056917f90 Authorized-sender: niklas.soderlund@fsdn.se Received: from bismarck.berto.se (p4fca2458.dip0.t-ipconnect.de [79.202.36.88]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA id 0c9dd88b-6a68-11eb-a076-005056917f90; Tue, 09 Feb 2021 00:47:51 +0100 (CET) From: =?utf-8?q?Niklas_S=C3=B6derlund?= To: Paul Elder Date: Tue, 9 Feb 2021 00:47:31 +0100 Message-Id: <20210208234733.2637061-1-niklas.soderlund@ragnatech.se> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Subject: [libcamera-devel] [RFC 0/2] ipu3: Translate IPA protocol to new mojo interface X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: libcamera-devel@lists.libcamera.org Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi Paul, This is based on-top of your ipc7 branch and it enables me to run the IPU3 IPA on CrOS Soraka. The first patch is a compile fix found with gcc7 while the last patch is the real meat. Feel free to pick and choose what you wish and squash it into your existing patches. I really like the new mojo interface, nice work! Niklas Söderlund (2): libcamera: IPCPipeUnixSocket: Check that insertion succeeds ipu3: Translate IPA protocol to new mojo interface include/libcamera/ipa/ipu3.h | 23 ------- include/libcamera/ipa/ipu3.mojom | 43 ++++++++++++ include/libcamera/ipa/meson.build | 1 + src/ipa/ipu3/ipu3.cpp | 74 ++++++++------------- src/ipa/ipu3/meson.build | 6 +- src/libcamera/ipc_pipe_unixsocket.cpp | 5 ++ src/libcamera/pipeline/ipu3/ipu3.cpp | 96 +++++++++++---------------- 7 files changed, 118 insertions(+), 130 deletions(-) delete mode 100644 include/libcamera/ipa/ipu3.h create mode 100644 include/libcamera/ipa/ipu3.mojom Reviewed-by: Paul Elder