From patchwork Mon Feb 8 15:07:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 11189 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0E6B6BD160 for ; Mon, 8 Feb 2021 15:07:46 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 87DB960D23; Mon, 8 Feb 2021 16:07:45 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="BgfeHbLL"; dkim-atps=neutral Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7058E60D18 for ; Mon, 8 Feb 2021 16:07:44 +0100 (CET) Received: by mail-wr1-x42e.google.com with SMTP id m13so17478581wro.12 for ; Mon, 08 Feb 2021 07:07:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=sz0fPag4iWtKHqh+YkJDCH/Tg5MHO9PAhbt6PedlUtc=; b=BgfeHbLLncbUS8sGhfmigobue2go+yviLQXfSAN4Z1GITzgk4zOzLeE0IHTCZ7vPvO jbo3Nvwud70I8nmituLVlG1wwRuF9aivNr9mzYPKDqLgSvBFrMtubqVvXZwbetpahXCP L0YgLxtp8VIDNAwg7EJ5cDrm1Fl2hhu0Fr1WcCfOvBySdxXzS1xBcOlpBETSp0w64+sw HgxAMRCLGHZXiYnPmr13cPp7tOe1s8tkSt+xfOGRcg87kXsu5z/UZ5gUZ8HTMlFA8pmo wePrwhqjeAKbSt0pkjICBrSuJC93N/YXH0d5mVBibs6omElpsm4Uk2pUK6YWUiUwr9I3 Rg7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=sz0fPag4iWtKHqh+YkJDCH/Tg5MHO9PAhbt6PedlUtc=; b=k7Ho5bq0OAHgiNA1zhZedPGEEgZWWSgyEQ19s6Q7Oh7Sg6MK5Du8aYL36zSkhMsq3E EoWYKHJM1NjNftGXVd8N4MGx/xzWagg4BrcFEmRTeOZY3MbMdzZUhxdSHNeRUo/FrYuF Fc8pbYv4bqAbRrjuTP2h1+i8Hi+biV5OkyxSSa3r2m9ufIrF3W7JK4xS+Zx7OOUbpTGp n2cthU6GvFumIHkG3IFHHNBE2Fp5yT8bn6H/1Io0GXvo3nwFt2NDa/RAWIghxfYr6zV0 94ST7jPfcWxqK0eKFia1nVIwxVD82eRYkqB3keALEamuj8MZMa1mExyE4mLUOtKNXVkW gEcg== X-Gm-Message-State: AOAM530ECHCtFbw7lLBDeEqMpk3Rgzx1nko89asMfCLt1qxuSmtXrMm1 jOtDYBS1+f0oyCrX3Eg9nfdCsnS2/lAfNkDO X-Google-Smtp-Source: ABdhPJztSY7EWXlln8PFTh0GUS4FifVd46oqjvDNnlF0/TUTMhq2/fgSUQzkngwaJylbMDLG2aijzA== X-Received: by 2002:adf:c6c1:: with SMTP id c1mr20515038wrh.326.1612796863382; Mon, 08 Feb 2021 07:07:43 -0800 (PST) Received: from naush-laptop.pitowers.org (cust51-dsl50.idnet.net. [212.69.50.51]) by smtp.gmail.com with ESMTPSA id a17sm31261389wrx.63.2021.02.08.07.07.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Feb 2021 07:07:42 -0800 (PST) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Mon, 8 Feb 2021 15:07:32 +0000 Message-Id: <20210208150738.2293520-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v6 0/6] Raspberry Pi: Colour denoise X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi all, Here is the next revision of the colour denoise work. This version includes all of the small typos pointed out in the last round of reviews. I've also added a \todo for the following items: 1) Disable ISP output 1 if we know colour denoise will not be running due to a resolution/format mismatch. 2) Return out the correct metadata status for CDN if it is not running. Regards, Naush Naushir Patuck (6): pipeline: raspberrypi: Refactor stream configuration routine pipeline: raspberrypi: Set the ISP Output1 to 1/4 resolution if unused uapi: raspberrypi: Update the bcm2835-isp header definition ipa: raspberrypi: Rename SdnStatus to DenoiseStatus ipa: raspberrypi: Add a DenoiseAlgorithm class to the Controller ipa: raspberrypi: Handle control::NoiseReductionMode in the controller include/libcamera/ipa/raspberrypi.h | 1 + include/linux/bcm2835-isp.h | 32 +++++- .../controller/denoise_algorithm.hpp | 23 +++++ .../raspberrypi/controller/denoise_status.h | 24 +++++ src/ipa/raspberrypi/controller/rpi/sdn.cpp | 15 ++- src/ipa/raspberrypi/controller/rpi/sdn.hpp | 5 +- src/ipa/raspberrypi/controller/sdn_status.h | 23 ----- src/ipa/raspberrypi/raspberrypi.cpp | 65 ++++++++++++- .../pipeline/raspberrypi/raspberrypi.cpp | 97 +++++++++++-------- 9 files changed, 210 insertions(+), 75 deletions(-) create mode 100644 src/ipa/raspberrypi/controller/denoise_algorithm.hpp create mode 100644 src/ipa/raspberrypi/controller/denoise_status.h delete mode 100644 src/ipa/raspberrypi/controller/sdn_status.h