From patchwork Thu Feb 4 09:34:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 11130 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6BA63BD162 for ; Thu, 4 Feb 2021 09:35:04 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B2AEF6140D; Thu, 4 Feb 2021 10:35:03 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="iuFXJX58"; dkim-atps=neutral Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B817D60107 for ; Thu, 4 Feb 2021 10:35:01 +0100 (CET) Received: by mail-wr1-x42f.google.com with SMTP id d16so2608063wro.11 for ; Thu, 04 Feb 2021 01:35:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KIlRrrv68qXuPM2zjbUh0Y+ApqTf7OHub950ZOQhO4w=; b=iuFXJX58deB4I0iNT3Vk/Bb70MSHxhyikY0FFLmPRCGKToqyZXPtimiIFQXScsaWiP EbY0ajQk2k97L+Iq6eOa2PsGasfg8RjxwBhDb0RIGv3554S0LG8hPLmfpHc6IIh9xKTm qm0dC27QtbX/p1IoOT0+x7e9xPyNcMbJsDsC1mRltlATe/58TGDe0IKjcX6uJqd0jLUa GCKTpowNVSTqInKz51Zff0s7ByC1rlDGEh4TRGk9Opdu8UIMrXwdeIMNHtL+90sapLSf WumnZSnUl/+Yo6sh130gzlTFmy51ce82MFz77MZcYZaqCv6P/ZWH49wOXAPQur8Dzg+Y XMdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KIlRrrv68qXuPM2zjbUh0Y+ApqTf7OHub950ZOQhO4w=; b=Jq3oLyl0H0JorvDiZcBpmki7eX3ijHJAX84xxjYezhbB+Krxj6SGqFXFB3ndQGCxgF nqQLmmubxg2+/jUsuRcZD/PO9QrFq5Iif4LWgQahott3u8M9UrU0Pw/pFhi+IURpqnIc JsAxlpI9dFU4VGl5uV9TayYESNBX/3iNeDbkB4iQK1r1dPqslRbNyGEQxLGPfPyUbXW5 jFx7NSP34zitGwZESTWJ23O6f4RHLmNfcON+cOJp8fUiMimKLldlhCY3Ru2niSiDu9iA Qj6Hax1Ug7Hm8I+xaEgiEN5dJ+FEPQAXgub5XQFeHRfBtHB4RQ4Kn5Emq0sm/4acGG4N 29zQ== X-Gm-Message-State: AOAM533BWfBILQVRnMGQ0h8pG2R8hL1FjDMoReuAuwOYJtju9Nr9By+V bM528thUJDkRU6TkO+MYEWL2//hPShSyg5BZ X-Google-Smtp-Source: ABdhPJyoUJqQveTgEUmjJfuQeDVoOSVHT1zgUsBLJtN/FnbksMK0OCzPbofyYRz+uqb/BBEFNUlMjw== X-Received: by 2002:a5d:4145:: with SMTP id c5mr8280462wrq.353.1612431301102; Thu, 04 Feb 2021 01:35:01 -0800 (PST) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id g16sm5280580wmi.30.2021.02.04.01.35.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 01:35:00 -0800 (PST) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Thu, 4 Feb 2021 09:34:50 +0000 Message-Id: <20210204093457.6879-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/7] Raspberry Pi IPA maintenance X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi everyone Here's a set of hopefully uncontroversial patches that just do some tidying in the Raspberry Pi control algorithms. On the Pi 4 platform, changes to the algorithm's settings are enacted synchronously with the algorithms themselves, so a handful of atomic variables or mutexes that protect these variables can simply be removed. (Some algorithms, such as AGC and ALSC, have already been dealt with.) There's one further related commit (the second of this set) which makes some locking improvements, exactly as we did some time ago in commit db552b for ALSC. Hope that all makes sense! Thanks David David Plowman (7): ipa: raspberrypi: AWB: Remove unnecessary locking for AWB settings ipa: raspberrypi: AWB: Improve locking. ipa: raspberrypi: ccm: Remove unnecessary atomic variable ipa: rasberrypi: contrast: Remove unnecessary atomic variables ipa: raspberrypi: noise: Remove unnecessary atomic variable ipa: raspberrypi: lux: Supply missing method and remove atomic variable ipa: raspberrypi: Remove atomic variable from Algorithm class src/ipa/raspberrypi/controller/algorithm.hpp | 3 +- src/ipa/raspberrypi/controller/rpi/awb.cpp | 28 ++++++++----------- src/ipa/raspberrypi/controller/rpi/awb.hpp | 4 +-- src/ipa/raspberrypi/controller/rpi/ccm.hpp | 3 +- .../raspberrypi/controller/rpi/contrast.cpp | 9 +++--- .../raspberrypi/controller/rpi/contrast.hpp | 5 ++-- src/ipa/raspberrypi/controller/rpi/lux.cpp | 5 ++++ src/ipa/raspberrypi/controller/rpi/lux.hpp | 3 +- src/ipa/raspberrypi/controller/rpi/noise.hpp | 2 +- src/ipa/raspberrypi/meson.build | 1 - 10 files changed, 27 insertions(+), 36 deletions(-)