From patchwork Fri Jan 29 15:11:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 11060 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 9650ABD808 for ; Fri, 29 Jan 2021 15:12:01 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 05131683B2; Fri, 29 Jan 2021 16:12:01 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="dVSHAAKe"; dkim-atps=neutral Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DD4E6683A2 for ; Fri, 29 Jan 2021 16:11:58 +0100 (CET) Received: by mail-wm1-x32b.google.com with SMTP id o10so7219166wmc.1 for ; Fri, 29 Jan 2021 07:11:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YQP3LOFLsBENigtCrJwP4h3MA5BtKurRNr3nDZD0GAE=; b=dVSHAAKePmdRsoLLyQ7lMhQjZtScl2msJ+sNs5KNy5n5hJJX8wt0Wsr/Z2O+IyK1y0 7aHbpAReN0406Qj4mHvI3j94H2v3MxLxHRRO9JZV9GrqG65oLnnQrSSbNYT+tNiARQL3 XuDbymCxAQJxXn5HtBiT9hslUl5+Dpj1Z8fxKPfSRx6QC+iT94f+39idfM/SoxrZobO6 DQiR3IPB1SPmYArWIXB+UQa5QQo5tR96jVFKwQH5cKn0oXFPcd5FXzEHeyIp8Qkeh0Wb Z0/Nyr1osRd5EVGINDudI7B83t8UaQXh2JwUtccv94bfSwXK1Hb+DBDuMk42dhaZCfHT 8ZPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YQP3LOFLsBENigtCrJwP4h3MA5BtKurRNr3nDZD0GAE=; b=iTXBhmDJIDUAcLlMCoqtj6HwRW8Bqd6+bgZA2ez7i7vgRbBtjQNPye0zcbwmPAP6tY s6B/3KLcP4QRSTOVXTgEDQK0U+ABJ8EImSZOaO8PouH4QspfvRASAJaLP+etJxGUtN0t eW+TtC1ds5DWn9pCip1qp+Y5DIHvXlqMSYq2T7XLD5MMBmqIZ/d68g8MmH+p3HXq7a8o tA7CkRiBkx2mX8hz5fnkv/JDGOhkbkCUS+2YOW7DQAiuO8CFLmrSMiIkGAkI/aIHkqJ3 Tuaup94aFM2SXx6md7tYB3i3h6kLoFQAob39Eo+4rJn7y/eAB6cKXEcX1/UMdMTbbz2f OU+w== X-Gm-Message-State: AOAM5328qnWrthUNMBFNKvUFM8O2wLFq0FnAIl5AAldbnaSwfEQRBKMi 5x+4NwpLFau4FwcupxTluiNcao0Xbx5mksNj X-Google-Smtp-Source: ABdhPJzrR9Ule/gjEYa08Ethjl69QfNaLDeZtqkPZh1j3jm2QxYRvY4iGkg5wH/qVYGZ5VuvxFvokg== X-Received: by 2002:a1c:c903:: with SMTP id f3mr4212517wmb.69.1611933118178; Fri, 29 Jan 2021 07:11:58 -0800 (PST) Received: from naushir-VirtualBox.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id f13sm6517461wmf.1.2021.01.29.07.11.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Jan 2021 07:11:57 -0800 (PST) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Fri, 29 Jan 2021 15:11:48 +0000 Message-Id: <20210129151154.1051163-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v5 0/6] Raspberry Pi: Colour denoise X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, Version 5 of this patch series addresses all the review comments in v4: - Switch DenoiseMode to an enum class. - Avoid double lookup in the DenoiseMode conversion table. - Add controls::draft::NoiseReductionMode to the available controls handled by the IPA. Regards, Naush Naushir Patuck (6): pipeline: raspberrypi: Refactor stream configuration routine pipeline: raspberrypi: Set the ISP Output1 to 1/4 resolution if unused uapi: raspberrypi: Update the bcm2835-isp header definition ipa: raspberrypi: Rename SdnStatus to DenoiseStatus ipa: raspberrypi: Add a DenoiseAlgorithm class to the Controller ipa: raspberrypi: Handle control::NoiseReductionMode in the controller include/libcamera/ipa/raspberrypi.h | 1 + include/linux/bcm2835-isp.h | 32 ++++++- .../controller/denoise_algorithm.hpp | 23 +++++ .../{sdn_status.h => denoise_status.h} | 7 +- src/ipa/raspberrypi/controller/rpi/sdn.cpp | 17 ++-- src/ipa/raspberrypi/controller/rpi/sdn.hpp | 5 +- src/ipa/raspberrypi/raspberrypi.cpp | 59 +++++++++++-- .../pipeline/raspberrypi/raspberrypi.cpp | 86 ++++++++++--------- 8 files changed, 174 insertions(+), 56 deletions(-) create mode 100644 src/ipa/raspberrypi/controller/denoise_algorithm.hpp rename src/ipa/raspberrypi/controller/{sdn_status.h => denoise_status.h} (62%)