From patchwork Fri Apr 26 15:01:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 1106 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8CF7C60B2E for ; Fri, 26 Apr 2019 17:02:09 +0200 (CEST) Received: from pendragon.station (net-37-182-44-227.cust.vodafonedsl.it [37.182.44.227]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 039685F for ; Fri, 26 Apr 2019 17:02:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1556290929; bh=U8mnjMst51bhiF+QMJhMI76rs/z4Zc1OYyJoDZVErXc=; h=From:To:Subject:Date:From; b=m66A3lRoGH0HA8nKe/Thm/cJTldBbt73me7eSN43znFC/r5fGGrjmU+m2ID9WDvw6 BftcByu+4MWrMYCVYHjbWPOlfKmV5BkxjWUtdEM6LXwlz7SK+481+7GpF8OytGRSXw Pou3qxtz3U9405xc+nWkvgc4aRuo8rAowvMeWwDg= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Fri, 26 Apr 2019 18:01:47 +0300 Message-Id: <20190426150155.18652-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/8] Fix clang compilation warnings and errors X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Apr 2019 15:02:10 -0000 Hello, This patch series fixes miscellaneous issues flagged by compiling libcamera with clang. There isn't much to be said, I believe all issues to be valid, please see individual patches for the fixes. Laurent Pinchart (8): libcamera: Correct struct forward declarations libcamera: event_dispatcher_poll: Fix bitwise test libcamera: log: Add a LogInvalid entry to LogSeverity libcamera: Mark overridden functions with override libcamera: v4l2_device: Buffer is not a struct test: v4l2_subdevice: Remove std::move() that prevents copy elision cam: options: Don't initialise variable-length arrays cam: options: Fix string concatenation include/libcamera/camera.h | 3 ++- src/cam/options.cpp | 9 ++++++--- src/libcamera/event_dispatcher_poll.cpp | 2 +- src/libcamera/include/camera_sensor.h | 3 ++- src/libcamera/include/log.h | 3 ++- src/libcamera/include/pipeline_handler.h | 1 - src/libcamera/log.cpp | 14 +++++++------- src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +- src/libcamera/pipeline/uvcvideo.cpp | 2 +- src/libcamera/pipeline/vimc.cpp | 2 +- src/libcamera/v4l2_device.cpp | 2 +- test/v4l2_subdevice/v4l2_subdevice_test.cpp | 2 +- 12 files changed, 25 insertions(+), 20 deletions(-) Reviewed-by: Niklas Söderlund