From patchwork Tue Jan 26 17:30:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 11016 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0EB78BD808 for ; Tue, 26 Jan 2021 17:29:56 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1F76B68327; Tue, 26 Jan 2021 18:29:55 +0100 (CET) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4BD4468318 for ; Tue, 26 Jan 2021 18:29:53 +0100 (CET) X-Originating-IP: 93.34.118.233 Received: from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233]) (Authenticated sender: jacopo@jmondi.org) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 00ABFE0002 for ; Tue, 26 Jan 2021 17:29:52 +0000 (UTC) From: Jacopo Mondi To: libcamera-devel@lists.libcamera.org Date: Tue, 26 Jan 2021 18:30:02 +0100 Message-Id: <20210126173008.446321-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/6] android: Report frame durations X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The only difference compared to v1 is [4/6] which I left un-squashed to ease review. The issue is subtle and manifests itself with a number of CTS tests that "fail to open camera". The culprit is the ov13858 minimum frame duration that is registered as 33389 microseconds, and the android camera framework filters away all streams intended for preview/record with a minimum frame duration larger than 33366 microseconds. The rounding criteria are quite arbitrary, so I expect someone to scream to those. Thanks j Jacopo Mondi (6): libcamera: camera_sensor: Make VBLANK mandatory libcamera: ipu3: Register FrameDurations control android: camera_device: Compute frame durations fixup! android: camera_device: Compute frame durations android: camera_device: Use AE FPS range in template android: camera_device: Return AE FPS range Documentation/sensor_driver_requirements.rst | 6 +- src/android/camera_device.cpp | 137 +++++++++++++++---- src/libcamera/camera_sensor.cpp | 1 + src/libcamera/pipeline/ipu3/ipu3.cpp | 35 ++++- 4 files changed, 147 insertions(+), 32 deletions(-) --- 2.30.0