From patchwork Tue Jan 26 10:28:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 10996 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8C119BD808 for ; Tue, 26 Jan 2021 10:28:37 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 155FB682F3; Tue, 26 Jan 2021 11:28:37 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Vpymi6ph"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9A956682D4 for ; Tue, 26 Jan 2021 11:28:35 +0100 (CET) Received: from pyrite.rasen.tech (unknown [IPv6:2400:4051:61:600:2c71:1b79:d06d:5032]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0DAD52C1; Tue, 26 Jan 2021 11:28:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1611656915; bh=EcC9EC6rE4uOk4YD0AF6k8xMJ5bXGSyi3/Kubheb0WQ=; h=From:To:Cc:Subject:Date:From; b=Vpymi6phQviqbsNXqO8en6zv03uQc+/4oijeTnIIH8WuU/IffT5RFTZ3DmkmTFYrK AJXHHZ70PNzwVRzQP6FUfpBLWqDemJ/71uiKAXJ0voulNz+TNSa5OaBaIW0K+tqraa 4ZNMf7JfDdsGGC3xgkrEtP3K7EgIh/634faSZ1VI= From: Paul Elder To: libcamera-devel@lists.libcamera.org Date: Tue, 26 Jan 2021 19:28:17 +0900 Message-Id: <20210126102825.147026-1-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v5 0/8] Fill in android result metadata and EXIF tags X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This patch series depends on the following two series: - "android: Exposure times + scaler crop + android metadata" This patch series makes the following CTS tests pass: - android.hardware.camera2.cts.StillCaptureTest#testFocalLengths - android.hardware.camera2.cts.StillCaptureTest#testJpegExif Mostly by filling out android result metadata and EXIF tags correctly based on the android request metadata. --- Changes in v5: - fix number alignment in exif subsec tag - improve todos - fix static metadata size - cosmetic and small reorganizing changes Changes in v4: - cosmetic and small reorganizing changes Changes in v3: - drop JIS and Undefined support for generating EXIF tags with undefined formats - clean up exif setString - fix endianness in exif setString - merge setting subsec into setTimestamp (in exif) - fix metadata entries and byte count - move thumbnail handling to separate patch - clean up caching request metadata - set quality of jpeg and thumbnail Changes in v2: - move string encoder from utils to exif, and support no-encoding - expand explanation about the exif orientation values - make camera.prop file parsing nicer - split out thumbnailer configuration and processControls into separate patch - handle null request settings Paul Elder (8): android: jpeg: exif: Expand setString to support different encodings android: jpeg: exif: Fix setOrientation EXIF values android: jpeg: exif: Add functions for setting various values android: camera_device: Load make and model from platform settings android: Set result metadata and EXIF fields based on request metadata android: jpeg: Configure thumbnailer based on request metadata android: camera_device: Cache request metadata android: jpeg: Set thumbnail and JPEG quality based on request src/android/camera_device.cpp | 63 +++++- src/android/camera_device.h | 7 + src/android/camera_stream.cpp | 7 +- src/android/camera_stream.h | 4 +- src/android/jpeg/encoder.h | 3 +- src/android/jpeg/encoder_libjpeg.cpp | 10 +- src/android/jpeg/encoder_libjpeg.h | 8 +- src/android/jpeg/exif.cpp | 262 +++++++++++++++++++++-- src/android/jpeg/exif.h | 50 ++++- src/android/jpeg/post_processor_jpeg.cpp | 113 +++++++--- src/android/jpeg/post_processor_jpeg.h | 5 +- src/android/jpeg/thumbnailer.cpp | 25 +-- src/android/jpeg/thumbnailer.h | 6 +- src/android/post_processor.h | 3 +- 14 files changed, 473 insertions(+), 93 deletions(-)