From patchwork Mon Jan 25 18:48:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 10989 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id ACF55BD808 for ; Mon, 25 Jan 2021 18:49:05 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3655E682DB; Mon, 25 Jan 2021 19:49:05 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="RFEp9UIl"; dkim-atps=neutral Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 125D6682CB for ; Mon, 25 Jan 2021 19:49:04 +0100 (CET) Received: by mail-ed1-x530.google.com with SMTP id d22so16776593edy.1 for ; Mon, 25 Jan 2021 10:49:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=JFGgB7Od4L5vHb1fn8AXLP04JwbNT1CBENlztafjzjo=; b=RFEp9UIl6vuyS6jrzEZy4+NboDYltw30XZkAXC3iu+GBxkewnxgg+Ibhn2kdxK+arS 9gp9Ie4YLEU7lfsqLNGNFrD2h/K2gUwm5GJfrv30dkRFF8bykiS51P73s8yMAZfp2bn1 D2MA2tNpSQ/H6yXoLcrcdxCS6lnoaXmO7Mg3QEVsup6+AnAa53J2gb1Z701wOz0TqCcy BT8fi6MWgHE9TJZsNEqTyHa+C1AR58BoGYZyb6yLwOa5vjzKBmax1VuS73fG7FtBPf5y wzigP8M9JkZ7FOBNZ7kAwqHDq7ZeJGf5sflfl5sba6mQRqrr12BFVbF7NWakdiv9fzf4 QxoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=JFGgB7Od4L5vHb1fn8AXLP04JwbNT1CBENlztafjzjo=; b=rn2PiLUaSag+jWcHdP0LMo80C/FtZp0sHNJftR58c+UbsKEUu2THX3A62ZvAgU3yfE FaYQ1qhpsbI79R5t5BwR3vrgJUc8lD0tv3dIEt2Ml+slxc3s/22pnxvl7hqY3IZ3pm+w 0y9jsF4M4Lk3KLIoblnk4A/ak6XDipsIFHJzAg33cmatCCsj60uuOcX49oA3sVWPSdlu geBz6j7VnenD7CyWOufi5pSL5yNQNzEpwYSyXalxRhuOxj7waBravqBdxUXQo4RuBybN HVb6CrNgUuhvNf4oDBJ93Ll9egXnGdi2BzFjGMGM62+0oeYNuqHDwsS1eR/ovOUBLw2z v5AQ== X-Gm-Message-State: AOAM530N3mNr5T0607mOZtCJsiIb6ElYJvAZ6SZ94kky9HQDFfkkgZds GNkBWYAqBaDGGa5kE+a2GFFPmoo+5AYqsRyj X-Google-Smtp-Source: ABdhPJwAnMxjcN+iw90znzvHGQVipErOX+sJEl/sL5RtM6T0uAIzTZX9Rd2r0rgoA6wGcDgfie86Cw== X-Received: by 2002:a50:eacd:: with SMTP id u13mr1627243edp.382.1611600543442; Mon, 25 Jan 2021 10:49:03 -0800 (PST) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id y59sm11601836ede.59.2021.01.25.10.49.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 10:49:02 -0800 (PST) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Mon, 25 Jan 2021 18:48:53 +0000 Message-Id: <20210125184858.16339-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/5] Remove Raspberry Pi logging X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi again everyone Version 2 of this set again makes no functional changes beyond debug logging. There are the following differences compared to v1: * I've removed some debug messages that were unnecessary (either just tracing statements or duplicates). * A number of messages repeated the algorithm name which is unnecessary with libcamera logging. * One or two that were actually warnings without using LOG(RPiXxx, Warning) have been amended. * A bit more whitespace tidying. I've actually folded the changes into the original commits, I think it's easy enough to follow like this. Most of Laurent's other suggestions I'd be fine with if we wanted to pursue them (except the one about sharing frame counts between algorithms - I'm actually really paranoid about that!). Thanks! David David Plowman (5): ipa: raspberrypi: controller: Replace Raspberry Pi debug with libcamera debug ipa: raspberrypi: alsc: Replace Raspberry Pi debug with libcamera debug ipa: raspberrypi: awb: Replace Raspberry Pi debug with libcamera debug ipa: raspberrypi: Replace Raspberry Pi debug with libcamera debug ipa: raspberrypi: Remove legacy Rasberry Pi logging src/ipa/raspberrypi/controller/algorithm.hpp | 1 - src/ipa/raspberrypi/controller/controller.cpp | 19 ++-- src/ipa/raspberrypi/controller/logging.hpp | 30 ------ src/ipa/raspberrypi/controller/rpi/alsc.cpp | 66 +++++++------ src/ipa/raspberrypi/controller/rpi/awb.cpp | 97 ++++++++++--------- .../controller/rpi/black_level.cpp | 11 ++- src/ipa/raspberrypi/controller/rpi/ccm.cpp | 26 +++-- .../raspberrypi/controller/rpi/contrast.cpp | 20 +++- src/ipa/raspberrypi/controller/rpi/dpc.cpp | 8 +- src/ipa/raspberrypi/controller/rpi/geq.cpp | 20 ++-- src/ipa/raspberrypi/controller/rpi/lux.cpp | 11 ++- src/ipa/raspberrypi/controller/rpi/noise.cpp | 14 ++- src/ipa/raspberrypi/controller/rpi/sdn.cpp | 21 ++-- .../raspberrypi/controller/rpi/sharpen.cpp | 11 ++- 14 files changed, 192 insertions(+), 163 deletions(-) delete mode 100644 src/ipa/raspberrypi/controller/logging.hpp