From patchwork Fri Jan 22 10:22:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 10951 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 1C1C1BD808 for ; Fri, 22 Jan 2021 10:22:26 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7A55D68238; Fri, 22 Jan 2021 11:22:25 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="rScLMM8K"; dkim-atps=neutral Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id EE3B16822F for ; Fri, 22 Jan 2021 11:22:23 +0100 (CET) Received: by mail-wr1-x42b.google.com with SMTP id a9so4539642wrt.5 for ; Fri, 22 Jan 2021 02:22:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=i6X0G18JPPHNQiPKUXTknrraVH9LER5VQFTuFM1RjKM=; b=rScLMM8KK7z1C/58VCG2f0lJIVxbdKsNJTL3RBo1+HTE0WbRAC9Uthuw4CEXUy6Pyi aJtF1AgAy9aOAio1n37vZ2lPg4O0hE4iiiNJ6laXSLxebYOnx3r4UO7ptZXrZfzOPZXC /IiO9LeaYZFVuCVdMpX95+epT+wZbaE4Zm2Lj85UDhTpj2oE09gZXGMLVv3He2WPhHIC dXZdEX8HJpvh7+k+JHUYNPeI0Kar3Y+68t90BdN0rYeJTLlw+zHUbj8oYeythUovCcoq pvWc2nUuc0f6sw4ERhf7En4Z4Otcgwil2eb5ZktM2q7ljb3yuyzch7BgJvRLndcDcpHp 6eCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=i6X0G18JPPHNQiPKUXTknrraVH9LER5VQFTuFM1RjKM=; b=e4iUd4d3JCXuHAdzfI/vzI2363oOkK+ZG1BHu+s20t4VU1wUWQcZejt+tE8XPxVjMe fVzRIo4+wRU6e5RcUclMFbgzGcWvvB/5VzyN2UYnMj4UUG/cQqDq1oJwOW9Sk01gxVLY CtDXDMXDq3V6r6xevyqXiu6hiVdU6c2WAQ/Qfgkc7RqYeVxB0ltH7bRytEUm+oIawjrq V0JbQN5OaitZnZvYLB+p2v28m8y4hFb1n5Mzx91o61e/VQXLfHugvAM3F4/1TOo3l0p+ V/JEfX3yosEdiRs5WEzEnaFQ7uz7Nxl1ozar3aYBHEwTStsU7pkQNKhwj+OiarkqvmSW lMGA== X-Gm-Message-State: AOAM533Tu+5UTevPzFeveAirJcgH9dnQ1XrIJ1avcIekV8QF+2TDR08r K5qxX3krTaOmzmpc04RB90gR7fC5tRikg7EX X-Google-Smtp-Source: ABdhPJwCGc1GFXbyEpsWurMg9s63lvmZCq6S39Xlxk6flEqE5wYw8hbozKJYYygNzZj7Bgh1tpjIRA== X-Received: by 2002:adf:90e3:: with SMTP id i90mr3916269wri.248.1611310943281; Fri, 22 Jan 2021 02:22:23 -0800 (PST) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id p15sm11469221wrt.15.2021.01.22.02.22.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jan 2021 02:22:22 -0800 (PST) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Fri, 22 Jan 2021 10:22:06 +0000 Message-Id: <20210122102211.12768-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/5] Remove Raspberry Pi logging X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi everyone This patch set removes the old Raspberry Pi logging from all our control algorithms and replaces it with libcamera logging. There is literally nothing in this patch set except for the necessary macro replacements and a few whitespace adjustments to keep the style checker happy. This is actually quite an important change because, now that we're about to publish libcamera versions of our legacy applications, it makes it much easier to get debug information from our customers. Perhaps the biggest question is whether to squish all the patches together? I've not done this yet as it's easier to squish than to un-squish, though I did roll up all the "minor" algorithms into a single commit. But I'll happily do that if it's tidier! Thanks and best regards David David Plowman (5): ipa: raspberrypi: controller: Replace Raspberry Pi debug with libcamera debug ipa: raspberrypi: alsc: Replace Raspberry Pi debug with libcamera debug ipa: raspberrypi: awb: Replace Raspberry Pi debug with libcamera debug ipa: raspberrypi: Replace Raspberry Pi debug with libcamera debug ipa: raspberrypi: Remove legacy Rasberry Pi logging src/ipa/raspberrypi/controller/algorithm.hpp | 1 - src/ipa/raspberrypi/controller/controller.cpp | 29 +++--- src/ipa/raspberrypi/controller/logging.hpp | 30 ------ src/ipa/raspberrypi/controller/rpi/alsc.cpp | 59 ++++++------ src/ipa/raspberrypi/controller/rpi/awb.cpp | 92 ++++++++++--------- .../controller/rpi/black_level.cpp | 8 +- src/ipa/raspberrypi/controller/rpi/ccm.cpp | 24 +++-- .../raspberrypi/controller/rpi/contrast.cpp | 15 ++- src/ipa/raspberrypi/controller/rpi/dpc.cpp | 8 +- src/ipa/raspberrypi/controller/rpi/geq.cpp | 18 ++-- src/ipa/raspberrypi/controller/rpi/lux.cpp | 12 ++- src/ipa/raspberrypi/controller/rpi/noise.cpp | 14 ++- src/ipa/raspberrypi/controller/rpi/sdn.cpp | 21 +++-- .../raspberrypi/controller/rpi/sharpen.cpp | 8 +- 14 files changed, 179 insertions(+), 160 deletions(-) delete mode 100644 src/ipa/raspberrypi/controller/logging.hpp Reviewed-by: Kieran Bingham Reviewed-by: Naushir Patuck