From patchwork Thu Jan 21 10:15:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Elder X-Patchwork-Id: 10912 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 3AF06C0F2A for ; Thu, 21 Jan 2021 10:16:03 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7DDAD681C0; Thu, 21 Jan 2021 11:16:02 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="EIsc5YvO"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 052A4681A0 for ; Thu, 21 Jan 2021 11:16:01 +0100 (CET) Received: from pyrite.rasen.tech (unknown [IPv6:2400:4051:61:600:2c71:1b79:d06d:5032]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 49E4E50E; Thu, 21 Jan 2021 11:15:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1611224161; bh=Jz+43xsVc5ktYOojFd62iVtX8zqcFYityVoWs9tKc7o=; h=From:To:Cc:Subject:Date:From; b=EIsc5YvOqBYxNuPZ51802d4baDuq1WHfeDmo8/swEOp5Zx/sHgtdIp7wXbyzZU8Rw ywGQm6ozg3EgrXkBRgKVHioj1b+HHfC4MatNcC6bcO+ejUrMj4ajNV1Zvjt04A70xo Ly9JCCev74Lf0xIWL8By0rdI2sGlns54J/ETejJA= From: Paul Elder To: libcamera-devel@lists.libcamera.org Date: Thu, 21 Jan 2021 19:15:40 +0900 Message-Id: <20210121101549.134574-1-paul.elder@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/9] Fill in android result metadata and EXIF tags X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This patch series depends on the following two series: - "android: Exposure times + scaler crop + android metadata" This patch series makes the following CTS tests pass: - android.hardware.camera2.cts.StillCaptureTest#testFocalLengths - android.hardware.camera2.cts.StillCaptureTest#testJpegExif Mostly by filling out android result metadata and EXIF tags correctly based on the android request metadata. --- Changes in v2: - move string encoder from utils to exif, and support no-encoding - expand explanation about the exif orientation values - make camera.prop file parsing nicer - split out thumbnailer configuration and processControls into separate patch - handle null request settings Paul Elder (9): android: jpeg: exif: Expand setString to support different encodings android: CameraMetadata: Add copy constructor and getEntry android: jpeg: exif: Fix setOrientation EXIF values android: jpeg: exif: Add functions for setting various values android: camera_device: Load make and model from platform settings android: jpeg: Factor out thumbnailer configuration android: camera_device: Use CameraMetadata wrapper in processControls android: Set result metadata and EXIF fields based on request metadata android: camera_device: Cache request metadata src/android/camera_device.cpp | 65 +++++- src/android/camera_device.h | 12 +- src/android/camera_metadata.cpp | 34 +++ src/android/camera_metadata.h | 5 + src/android/camera_stream.cpp | 7 +- src/android/camera_stream.h | 4 +- src/android/jpeg/exif.cpp | 270 +++++++++++++++++++++-- src/android/jpeg/exif.h | 52 ++++- src/android/jpeg/post_processor_jpeg.cpp | 116 ++++++++-- src/android/jpeg/post_processor_jpeg.h | 5 +- src/android/jpeg/thumbnailer.h | 1 + src/android/post_processor.h | 3 +- 12 files changed, 512 insertions(+), 62 deletions(-)