From patchwork Wed Jan 6 10:06:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 10827 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 20DE9C0F1A for ; Wed, 6 Jan 2021 10:07:06 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9D9EB6010B; Wed, 6 Jan 2021 11:07:05 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="WdxLJiex"; dkim-atps=neutral Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 00D786010B for ; Wed, 6 Jan 2021 11:07:03 +0100 (CET) Received: by mail-wr1-x435.google.com with SMTP id i9so1889849wrc.4 for ; Wed, 06 Jan 2021 02:07:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yvWzh03NQCjWT/miSxqUAmszV0pCO/3v+KH089imjls=; b=WdxLJiexL6KRm6DlA7o3aG0dxeci4gTCUOEMM5Fv7Xsj7UNrRMk1HG+RopZOOpKfN8 0X8TnHeG0eP+Po1RIJNQXVuU13i+or3t0kmO2zp5UwGarHFiCtdVFzQn29Wj0IKFbe7/ dX3HiUlt8RtfEb1vRmikpuFTO0JJHJxrmEdnX6qaHNZ1nuoPt5nRBXeQqW+MbebOt3AN gK+kYLe4P004p6ROOy4dwl71sJVAdsyR9UeuHudnoCfpYQ+RTMc7C7h+aavnIYrcRW6J XheCv+2+A3gkSUnOgwMzOV5/ooi0xTgTEpTTszTJKW7X7aG/ciIBbB12ghWAtDOne4qo 0pSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yvWzh03NQCjWT/miSxqUAmszV0pCO/3v+KH089imjls=; b=debW7/Ga1KzX74jrffBb3ppM5S1YanGG6KQn1rnLEQhh5yRSxisNRTMXEjRL9UGzPg 3+BXJeWdnpo4zjk0OmOE3jCZsu+4rNqcLzI6tYIuwkTJ07QvEqwAkkwL/AkpSsSluP7v 6qhnfGk8oXw+RHEwiH3Q6TQqEjCdkHyimTHuY6rlmNDIOSe19o3U7E6BDyDm7eXToO0B wWDlbkQciHoobtMhPl8oT8jT+xu9ynBnpatapG+kdprrSnjB3rfK8xiNLkwyj4f/mUQr Gsd/JGPkcepEVD02KdDu7Hgw9OnE0jw6C11Ido4QNuHgwytVBqxk9Vv2KEzfs+88UqkB TMRg== X-Gm-Message-State: AOAM531Xx6XRe37anXb3urA6lmK3UmnKxOpyu0jHId5wauLp9cOvdUKL lo6KxEkGXHdVNoKHFH6Kq49w6AHKT7uUSg== X-Google-Smtp-Source: ABdhPJw1kQfDlaR1eBwFlpRbBIfeJB8jOfq7A2iOJNQ+0KiPpW+LPYO6xKE+H6Gm2lOz5D0yQk8s/Q== X-Received: by 2002:adf:ef12:: with SMTP id e18mr3535505wro.192.1609927623450; Wed, 06 Jan 2021 02:07:03 -0800 (PST) Received: from naushir-VirtualBox.patuck.local ([88.97.76.4]) by smtp.gmail.com with ESMTPSA id m21sm2382381wml.13.2021.01.06.02.07.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jan 2021 02:07:02 -0800 (PST) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Wed, 6 Jan 2021 10:06:56 +0000 Message-Id: <20210106100659.8363-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v11 0/3] raspberrypi: FPS control X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi all, Here is the next iteration of the FPS control patchset. This version has all the various nits fixed: - Clip -> Clamp in a comment. - Member definitions on separate lines to match the rest of the file. - Ensure we handle the case where minFrameDuration > maxFrameDuration without breaking. - Expanded wording in the commit message for 3/3. The documentation for frameDurations control has been updated as well. I've included a line about resetting to default values, together with a todo to rationalise this as well as for other controls. Also simplified the text surrounding metadata return values. Many thanks, Naush Naushir Patuck (3): libcamera: controls: Add frame duration control libcamera: raspberrypi: Add control of sensor vblanking ipa: raspberrypi: config: Update shutter speeds for imx219/477 and ov5647 include/libcamera/ipa/raspberrypi.h | 1 + src/ipa/raspberrypi/cam_helper.cpp | 35 +++++++++++- src/ipa/raspberrypi/cam_helper.hpp | 15 ++++- src/ipa/raspberrypi/cam_helper_imx219.cpp | 13 ++++- src/ipa/raspberrypi/cam_helper_imx477.cpp | 11 +++- src/ipa/raspberrypi/cam_helper_ov5647.cpp | 11 +++- src/ipa/raspberrypi/data/imx219.json | 15 ++++- src/ipa/raspberrypi/data/imx477.json | 15 ++++- src/ipa/raspberrypi/data/ov5647.json | 15 ++++- src/ipa/raspberrypi/raspberrypi.cpp | 56 ++++++++++++++++--- src/libcamera/control_ids.yaml | 38 +++++++++++++ .../pipeline/raspberrypi/raspberrypi.cpp | 3 +- 12 files changed, 207 insertions(+), 21 deletions(-)