From patchwork Tue Dec 22 13:58:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 10693 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 20366C0F1A for ; Tue, 22 Dec 2020 13:58:57 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8FAB8615D2; Tue, 22 Dec 2020 14:58:56 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="iYhmmI3f"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A293E60528 for ; Tue, 22 Dec 2020 14:58:54 +0100 (CET) Received: from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1BCC69E6; Tue, 22 Dec 2020 14:58:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1608645534; bh=BWXeQu7WrjA9BzdKzwIACZ/vbb7ApF7nl0N+ZEKHiK8=; h=From:To:Cc:Subject:Date:From; b=iYhmmI3fEZysBs0bwHIW4iSLt7F/CCk3+zuk8nw/bUilsH6DqgRrV4FlIkv1tzTXq haGdE2j7Zi3GIg+VfjztfIiQnP5vWepPwmrTyc42+6fIQ+vPDuVL5Rfvk5+/G9tOB4 NYjKOceZKFwSjyhnJX6vr+tvtE9N6okqL2j5nyAo= From: Kieran Bingham To: libcamera devel Date: Tue, 22 Dec 2020 13:58:47 +0000 Message-Id: <20201222135849.38052-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/2] libcamera: file: Don't parse directories X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" During development, and checking that the file I needed existed, I hit a fault where the path was inadvertantly pointing to a directory. The call to File::exists() then succeeded, and the code attempted to parse a directory as if it were a file, with expectedly undesireable results. Add a test to ensure that File::exists does not return true when given a directory and fix the underlying issue. Kieran Bingham (2): test: file: Check that directories are not treated as files libcamera: file: Check files exist() src/libcamera/file.cpp | 3 ++- test/file.cpp | 5 +++++ 2 files changed, 7 insertions(+), 1 deletion(-)