From patchwork Fri Dec 18 10:06:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 10677 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B276AC0F1A for ; Fri, 18 Dec 2020 10:07:00 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2024261596; Fri, 18 Dec 2020 11:07:00 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="Lr9Bs9KV"; dkim-atps=neutral Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1960661592 for ; Fri, 18 Dec 2020 11:06:59 +0100 (CET) Received: by mail-wr1-x42a.google.com with SMTP id q18so1529820wrn.1 for ; Fri, 18 Dec 2020 02:06:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=r/bRQm5YU7hGwqftmWqSmH/M//uZAHW4XEajVT/fvog=; b=Lr9Bs9KVkQUMwOEuqf6XPMO/Ev7Q+UaLD9xaR0Hsr46yH9WQrDW33Zqkk6GCsfpuVh 4yfjWNJRonMV05F9zfFtLzQEW9XthwtZJFLZuuMHmi440zlFv091f2gaFDnWh9GQeQl/ 6VH7CmwOdbyuYSXu1rTsLnASSCW0TeecwYhgaT7IcvJw263PlFhFqjzdXpG8JDMbIuMY mam/WSmLOsgYbZ/XFd61OxTsRsvd7KctxBfjtzvTIxcrqP6TB6gq0mOSwgLW5mx3QzYG Bx/ozG1bd1SnAhCGjpWcunLUmnZ7NtCwt3203F1o25VrR+3Bv8kiwhkt1TS83sE9kubX 2JsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=r/bRQm5YU7hGwqftmWqSmH/M//uZAHW4XEajVT/fvog=; b=jj3xnJmLHP6BxovOuA+kmSXfiGgyZHDh7OIfahoK2U2NULXLITSgOOJLCeBwTSWZ/I jns9lX19CHjvVQ8l0BgUIoaRBy7SR1Ff9qVflFZ2lvit97g6F+jtOqKLZHnTXhuJGc5n 4x7YrIxtgvMrKQoCRvHP9nmOcOFOvtajOZeKnRQwZH9Pf3ZK08dGj1SG616x4fG5PcdV lakkSlxEvURLDA6Q49v7s3kduOwx2OOwOes/VcxCXHzThj4Ojkr0p73kZlK8AOAxlvj9 1xPV4Kxwf+sD0WlKbv5d+J2Zd65rr5wqGd2tzufQGUuUXjFM1Znp440J3V+fiqSvQMkZ d6mg== X-Gm-Message-State: AOAM5306yDK4cCxT7rnDAxD28axXeksfhepud+bZufgUaa/5gCcX/jlt oD8xDKq6qHVGZYWQ0oMEYyVl3rMKceyQrw== X-Google-Smtp-Source: ABdhPJwdW1rh2VJGG/R2FImZB4fanqSmGKOIye4xrqJwvjNayQFb8IOFvKErlxXy5YpA0P50G8nmZA== X-Received: by 2002:a5d:6607:: with SMTP id n7mr3418033wru.206.1608286018429; Fri, 18 Dec 2020 02:06:58 -0800 (PST) Received: from naushir-VirtualBox.pitowers.org ([2a00:1098:3142:14:a00:27ff:fe4d:f6a2]) by smtp.gmail.com with ESMTPSA id c4sm11836424wmf.19.2020.12.18.02.06.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Dec 2020 02:06:57 -0800 (PST) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Fri, 18 Dec 2020 10:06:24 +0000 Message-Id: <20201218100626.205134-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v10 0/3] raspberrypi: FPS control X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi all, Here is the next iteration of the FPS control patch set. Jacopo, based on our discussion yesterday, I've modified the wording in the control documentation. Only the return metadata part of the text has changed, but I've removed your review tag from patch 1/3 so that you have a chance to go through the new text again. After having thought about it a bit more, setting the correct values of frame durations (based on the new text description) in the Raspberry Pi IPA is not currently possible without my next series of changes to get the AGC to handle frame durations correctly. So I have put a \todo in the code to fix this correctly in the follow up series. At present, the code simply returns the values that were provided by the user. Hope that is ok. Other than that, the minor typos in patch 2/3 have also been fixed. Thanks, Naush Naushir Patuck (3): libcamera: controls: Add frame duration control libcamera: raspberrypi: Add control of sensor vblanking ipa: raspberrypi: config: Update shutter speeds for imx219/477 and ov5647 include/libcamera/ipa/raspberrypi.h | 1 + src/ipa/raspberrypi/cam_helper.cpp | 35 ++++++++++++- src/ipa/raspberrypi/cam_helper.hpp | 15 +++++- src/ipa/raspberrypi/cam_helper_imx219.cpp | 13 ++++- src/ipa/raspberrypi/cam_helper_imx477.cpp | 11 +++- src/ipa/raspberrypi/cam_helper_ov5647.cpp | 11 +++- src/ipa/raspberrypi/data/imx219.json | 15 +++++- src/ipa/raspberrypi/data/imx477.json | 15 +++++- src/ipa/raspberrypi/data/ov5647.json | 15 +++++- src/ipa/raspberrypi/raspberrypi.cpp | 52 ++++++++++++++++--- src/libcamera/control_ids.yaml | 41 +++++++++++++++ .../pipeline/raspberrypi/raspberrypi.cpp | 3 +- 12 files changed, 207 insertions(+), 20 deletions(-)