From patchwork Fri Dec 4 15:31:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naushir Patuck X-Patchwork-Id: 10559 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id DFF27BE177 for ; Fri, 4 Dec 2020 15:31:27 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 64516635D0; Fri, 4 Dec 2020 16:31:27 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="OJdI0SZc"; dkim-atps=neutral Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id ADE19635D0 for ; Fri, 4 Dec 2020 16:31:25 +0100 (CET) Received: by mail-wm1-x32f.google.com with SMTP id g185so7404131wmf.3 for ; Fri, 04 Dec 2020 07:31:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=qBjX/pHP847xM9XkPktwvWd+wY2KzR3/VSRBBfCM01c=; b=OJdI0SZcT18+9JQfKET/NVxUmpQIj7Z5Nc6b6FHKjlb9MVLh2EJyGzjSS+NIHAWB6r VF6ht2UlFDn19DA2iECp/u51EXhQXJTbKur1GlcTSuvTxvok7CxkpUZ1Y42tQUkhi9qs i4eS26mdO9XJVrwOaFFZlbP/vELIOZ1Qg+IpjqbgK77faVuobW02KkI6T5ztRiDe1apM xdzpvaf5bJAlAAkhcMZs/VY729F2WiJzE617etP/AsUzDywniHo72xhFjoWUgqrgevXZ MlPDEzKRiKb2p1oqGmQVY3oH6sEby8gvpekTvUIDCXEP7ywN7l8vvn5b1/daKWnlnH1v 1CXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=qBjX/pHP847xM9XkPktwvWd+wY2KzR3/VSRBBfCM01c=; b=FraCh05ukH9/Tpxr/QxA1qQGpkMY+/Ge0Rz3BHBUzqTMIKjSjxCqO7GJm6hFco822q yjzXkwweD/Jeb1BtUmdpjvBgqkrU8XSHzH0d8MQmt6lUqtesSwDakXQkDWF24ba0/XMx tefzHx6D5/oJBd1EgSigKgYYU1T6pMvqdIDpU8Gq5Cf68pA8xsKc5NY1zHdMFo8lpwyl XJRgEqzVpyLLZd5rGZcpN+n9wT2oiX6d38aMh5b6RyL5eUDIfmB9ApXWHW/k207cSCwn 9nPw4gidxtBahVETdKOdNPr2S8uzpqcgnH3rbSfKYk9w4i/ZZVoWqKDPjXNDd8FSfiVM a65A== X-Gm-Message-State: AOAM531TACCHwLY/XasEFMMpczcjNnXIwC6NOyASe4XybAcFxtd9z124 Iqu0AnE7XsB4wHtollZOFYFjgQQXYnKQUA== X-Google-Smtp-Source: ABdhPJzHfFSPCGsGaSZXtRAl8QPtBaJ/KUn0H4AKDupc/QkcuTgD35zVUrAmHA3dAlkI4WwsQwKgCQ== X-Received: by 2002:a1c:e907:: with SMTP id q7mr4835125wmc.161.1607095885123; Fri, 04 Dec 2020 07:31:25 -0800 (PST) Received: from naushir-VirtualBox.pitowers.org ([2a00:1098:3142:14:a00:27ff:fe4d:f6a2]) by smtp.gmail.com with ESMTPSA id x66sm3465426wmg.26.2020.12.04.07.31.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Dec 2020 07:31:24 -0800 (PST) From: Naushir Patuck To: libcamera-devel@lists.libcamera.org Date: Fri, 4 Dec 2020 15:31:18 +0000 Message-Id: <20201204153121.66136-1-naush@raspberrypi.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/3] Pass controls on camera:start() X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi, Here is patchset v3 for the work on passing controls on camera::start(). I have addressed Jacopo's review comments, and rebased to the top of master. Thanks, Naush Naushir Patuck (3): libcamera: pipeline: Pass libcamera controls into pipeline_handler::start() libcamera: ipa: Pass a set of controls and return results from ipa::start() pipeline: ipa: raspberrypi: Pass controls to IPA on start Documentation/guides/pipeline-handler.rst | 4 +- include/libcamera/camera.h | 2 +- .../libcamera/internal/ipa_context_wrapper.h | 3 +- include/libcamera/internal/pipeline_handler.h | 2 +- include/libcamera/ipa/ipa_interface.h | 3 +- include/libcamera/ipa/raspberrypi.h | 1 + src/ipa/libipa/ipa_interface_wrapper.cpp | 4 +- src/ipa/raspberrypi/raspberrypi.cpp | 55 ++++++++++++------- src/ipa/rkisp1/rkisp1.cpp | 3 +- src/ipa/vimc/vimc.cpp | 6 +- src/libcamera/camera.cpp | 11 ++-- src/libcamera/ipa_context_wrapper.cpp | 5 +- src/libcamera/ipa_interface.cpp | 7 +++ src/libcamera/pipeline/ipu3/ipu3.cpp | 4 +- .../pipeline/raspberrypi/raspberrypi.cpp | 22 ++++++-- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 7 ++- src/libcamera/pipeline/simple/simple.cpp | 4 +- src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 4 +- src/libcamera/pipeline/vimc/vimc.cpp | 7 ++- src/libcamera/pipeline_handler.cpp | 1 + src/libcamera/proxy/ipa_proxy_linux.cpp | 3 +- src/libcamera/proxy/ipa_proxy_thread.cpp | 13 +++-- test/ipa/ipa_interface_test.cpp | 3 +- test/ipa/ipa_wrappers_test.cpp | 5 +- 24 files changed, 117 insertions(+), 62 deletions(-)