From patchwork Tue Dec 1 17:55:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 10535 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7247BBE176 for ; Tue, 1 Dec 2020 17:55:44 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E176663503; Tue, 1 Dec 2020 18:55:43 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="tJ3z3Nte"; dkim-atps=neutral Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4ED4163460 for ; Tue, 1 Dec 2020 18:55:42 +0100 (CET) Received: by mail-wm1-x330.google.com with SMTP id k10so5162876wmi.3 for ; Tue, 01 Dec 2020 09:55:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=RltHz9fO3dZVF6Q5/IcRP+mghYl97y/I2ynS48JWFU0=; b=tJ3z3NteG1ZhvPFDfZzukh3yzckLIOfB2qPApKVQIK46GxNLYA/UmunYFqEcNegrnw MblbuiR71mLGXe8cXOndxjO8QKZE/iezRACtzahhq7xwQx7rkCu6IC5DKfIYovoi9+Bp F0Pum1W7VI0W91NZSmaQSuFUKRDCiUYlXLA6kZ+vcQjWwDxvgu4yHjZJqULgzUZGTClX RwxZBxuqV4MlMh29BjeNYja12l3QnSJP0H7WmaqNmRCCirH3zaPPAh8e/eSkgwcxwmIC GQV1tRpRP7Kjd51gEr45j/onL0Ni3mgF4k/jh6JG285p5Tp292WoLWe+9cAyrlGMj8yx uG7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=RltHz9fO3dZVF6Q5/IcRP+mghYl97y/I2ynS48JWFU0=; b=ZvRwaA2pUJnWvBfvverHQ4hCMZujRoEC83x1y23AyTVZ5JngNMXjCORf36M/Xi59uP cK5Xc++6bySvoUJ/TjKQf2uR/yPQ5tS0WpH1TyzbA6iD91fSinoXQ9djkfPpZYZ0ll9h kp/UspUUK2FU7XlpsCigaovHMGT28DrqvLLDQ3fOmI8ByXJ8iRQdpvM6r5Oz34QG/neL 0D/1fyWqC2TvbBnSN110meflpvbXKD1AYiZWRGzC+SyZo2aulJdEsiPgAiSqpbgui7Eu GWbeJZLqluZkF8Hob/Ek469AHoBoEoa8ApifQejAyiNM5/4RaPdSIyDd2GjVkFiR9Rnv bNsw== X-Gm-Message-State: AOAM531WMQan3EOjlRJeBsQQIG8519dbwNtDII9v5h1lQ+qu93JIHHBV qob8OlIXB9ZNHWyllnasL7QCKq/Uh31xSz9s X-Google-Smtp-Source: ABdhPJwlE8Hl42wj4mSEcvgKVgik0AllC/SXt5tHvfaw8h7TB3LNQi9cVlmkwEj/mq3XOWRunjYi8g== X-Received: by 2002:a7b:c954:: with SMTP id i20mr3894275wml.56.1606845341552; Tue, 01 Dec 2020 09:55:41 -0800 (PST) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id l3sm438561wrr.89.2020.12.01.09.55.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Dec 2020 09:55:40 -0800 (PST) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Tue, 1 Dec 2020 17:55:31 +0000 Message-Id: <20201201175536.11093-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 0/5] Raspberry Pi AGC improvements X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi everyone Here's a fourth version of my mostly minor AGC improvements. Everything is identical to v3 except with an extra commit squeezed in just before the final one which updates the documentation for the ExposureTime and AnalogueGain controls. Thanks! David David Plowman (5): src: ipa: raspberrypi: Avoid AGC filtering when both gain and shutter specified src: ipa: raspberrypi: agc: Make AGC handle Pause/Resume for itself src: ipa: raspberrypi: Improve behaviour when AE disabled libcamera: controls: Improve documentation for ExposureTime and AnalogueGain src: ipa: raspberrypi: Fix initial AGC oscillation for imx219 sensor src/ipa/raspberrypi/controller/rpi/agc.cpp | 31 +++++++++++++++++++++- src/ipa/raspberrypi/controller/rpi/agc.hpp | 4 +++ src/ipa/raspberrypi/data/imx219.json | 4 +-- src/ipa/raspberrypi/raspberrypi.cpp | 8 ------ src/libcamera/control_ids.yaml | 14 ++++++++++ 5 files changed, 50 insertions(+), 11 deletions(-)