From patchwork Thu Nov 26 14:50:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 10511 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 0FA25BE08A for ; Thu, 26 Nov 2020 14:50:11 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6684363477; Thu, 26 Nov 2020 15:50:10 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="kgIo31ig"; dkim-atps=neutral Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A223563469 for ; Thu, 26 Nov 2020 15:50:08 +0100 (CET) Received: by mail-ed1-x533.google.com with SMTP id l5so2534359edq.11 for ; Thu, 26 Nov 2020 06:50:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=cjGBcaIMK2lLzJbkoT0YI5N7RryRivSacoNXGCVqb4U=; b=kgIo31ig+GK2BWPqA4g7RYwC3vnSMvSf/MlbSaw1TrEiIQ+XQuiVfZIyn+YeJjvC+6 rMK5jWHbmRYA/Pi7an3Xl0XtA3pCN8t3CJjV0Iosy+Pcyd60nDBVD6gQH0r+UrNwDBQS QqHRt9auprJ46IuXwfkPl0TnSt2ByG/ar0OjJror1M2oMksWKbVVDvYtsuFrTgntpyPj YfV0xB4KFBd2D2LvjHL9t/pOPKhfZssIqpItLCBh8iMNeWWK6fGY+1d99JCaTgAGboDb /9b4nDPeK9FR9kKA0U0V3IgRknoL41IoyGKAX/PmUPw2ZxNAt5uGxogiqczCVLW7jDx/ gqdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=cjGBcaIMK2lLzJbkoT0YI5N7RryRivSacoNXGCVqb4U=; b=egGXFPm3zXaQJppoaeGqdHwnISsRoqh5wMCK8alJ/tq86LocOKw/zk60wmJf2FGtwQ pqSCOq4DmeuC1gGAqJeRuLGqjznFFGn4V3vJIJlEmIn73CzLagwyEdVMqNNdxe/sbhLe MLdlX7csez7HYq6GbRIhc6Y5Pm2Z97bayJAoYvTIvRxpLjIA3ZSvnb75YMFfYZUkA6X9 CPx1rFJlbduT0AGDsPC/3MjHxQGoelKdBloQaq+8gK9Nrdhf4Dt/nXeDnpzjsVKinC4I isgUv/RmIQrM2zG484ROoaf2MvhmckXKKODKxIpjdiQNUZi9qwoBIBXR/ZckMWAC5qhb DDoA== X-Gm-Message-State: AOAM532nypXe0XDUEJ/dtuAZsajqTdz9NAFF4QCyYwcuCZN6uJFpZLZm 03YsNDBB8gDfkx93djbW5Al/sbszO26AiRbL X-Google-Smtp-Source: ABdhPJzm95Ult0fYeMuq/ekseX1HYID9MuFyzyrTsKlVLFRfH6P0Yr4hI/dTYRT6uOwUHtRswj5K0A== X-Received: by 2002:a05:6402:1389:: with SMTP id b9mr2940664edv.178.1606402207617; Thu, 26 Nov 2020 06:50:07 -0800 (PST) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id cw26sm3249359ejb.47.2020.11.26.06.50.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 06:50:07 -0800 (PST) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Thu, 26 Nov 2020 14:50:03 +0000 Message-Id: <20201126145005.8838-1-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 0/2] Digital gain control X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hi everyone Here (after much talking ourselves in circles!) is a second version of the digital gain control. I've taken Jacopo's text for the control description, and added a second patch that makes use of the control in the Raspberry Pi IPAs to add the digital gain to the metadata. This second patch doesn't really tell you very much. In our libcamera version of raspistill (still image capture app) there will be a line like this: iso *= metadata.get(controls::DigitalGain); and that's about it! Best regards David David Plowman (2): libcamera: controls: Add DigitalGain control src: ipa: raspberrypi: Add digital gain to libcamera metadata src/ipa/raspberrypi/raspberrypi.cpp | 4 +++- src/libcamera/control_ids.yaml | 17 +++++++++++++++++ 2 files changed, 20 insertions(+), 1 deletion(-)