From patchwork Mon Nov 23 22:12:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Niklas_S=C3=B6derlund?= X-Patchwork-Id: 10480 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6686FBE176 for ; Mon, 23 Nov 2020 22:12:49 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8DCF4633F7; Mon, 23 Nov 2020 23:12:48 +0100 (CET) Received: from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net [195.74.38.228]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 77479631D0 for ; Mon, 23 Nov 2020 23:12:46 +0100 (CET) X-Halon-ID: 21d53590-2dd8-11eb-a076-005056917f90 Authorized-sender: niklas.soderlund@fsdn.se Received: from bismarck.berto.se (p4fca2458.dip0.t-ipconnect.de [79.202.36.88]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA id 21d53590-2dd8-11eb-a076-005056917f90; Mon, 23 Nov 2020 23:06:32 +0100 (CET) From: =?utf-8?q?Niklas_S=C3=B6derlund?= To: libcamera-devel@lists.libcamera.org, naush@raspberrypi.com Date: Mon, 23 Nov 2020 23:12:26 +0100 Message-Id: <20201123221234.485933-1-niklas.soderlund@ragnatech.se> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 0/8] libcamera: Add helper for controls that take effect with a delay X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, This series adds a new helper class to libcamera-core based on the StaggerdCtrl principle from the Raspberry Pi pipeline handler. The new helper matches perfectly the RPi implementation and can therefore replace the pipeline specific implementation. There are slight changes in the API of the two but noting preventing it to be a drop in replacement. The major new addition to the DelayedControls implementation is the ability to queue controls ahead of time. This allows the concept of pipeline depth we already have for buffers to be extended to controls. Patch 1/8 and 2/8 adds the new core helper and its unit test. Patch 3/8 and 4/8 replaces StaggerdCtrl with DelayedControls in the Raspberry Pi pipeline handler. Patch 5/8 adds an interface based on DelayedControls to CameraSensor. And last 6/8 - 8/8 make use of the new helper in the RkISP1 pipeline to completely remove another local helper (Timeline). The RkISP1 IPA feels much snappier after this change but this is anecdotal and no real measurements have been done as the RkISP1 IPA at this stage is neither advanced nor tuned. Niklas Söderlund (8): libcamera: delayed_controls: Add helper for controls that applies with a delay test: delayed_controls: Add test case for DelayedControls libcamera: raspberrypi: Switch to DelayedControls libcamera: raspberrypi: Remove StaggeredCtrl libcamera: camera_sensor: Expose a DelayedControls interface libcamera: pipeline: rkisp1: Use CameraSensor and delayed controls libcamera: pipeline: rkisp1: Use SOF event to warn about late parameters libcamera: pipeline: rkisp1: Remove Timeline include/libcamera/internal/camera_sensor.h | 5 + include/libcamera/internal/delayed_controls.h | 87 +++++ src/libcamera/camera_sensor.cpp | 31 ++ src/libcamera/delayed_controls.cpp | 265 ++++++++++++++++ src/libcamera/meson.build | 1 + .../pipeline/raspberrypi/meson.build | 1 - .../pipeline/raspberrypi/raspberrypi.cpp | 44 ++- .../pipeline/raspberrypi/staggered_ctrl.cpp | 174 ---------- .../pipeline/raspberrypi/staggered_ctrl.h | 96 ------ src/libcamera/pipeline/rkisp1/meson.build | 1 - src/libcamera/pipeline/rkisp1/rkisp1.cpp | 158 +++------ src/libcamera/pipeline/rkisp1/timeline.cpp | 227 ------------- src/libcamera/pipeline/rkisp1/timeline.h | 71 ----- test/delayed_contols.cpp | 300 ++++++++++++++++++ test/meson.build | 1 + 15 files changed, 747 insertions(+), 715 deletions(-) create mode 100644 include/libcamera/internal/delayed_controls.h create mode 100644 src/libcamera/delayed_controls.cpp delete mode 100644 src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp delete mode 100644 src/libcamera/pipeline/raspberrypi/staggered_ctrl.h delete mode 100644 src/libcamera/pipeline/rkisp1/timeline.cpp delete mode 100644 src/libcamera/pipeline/rkisp1/timeline.h create mode 100644 test/delayed_contols.cpp