From patchwork Fri Oct 23 05:10:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 10204 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 37BC2BDB13 for ; Fri, 23 Oct 2020 05:11:13 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id BCA26615DA; Fri, 23 Oct 2020 07:11:12 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="QUgr8qMI"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id CFF746034E for ; Fri, 23 Oct 2020 07:11:11 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 55DB8B26 for ; Fri, 23 Oct 2020 07:11:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1603429871; bh=yE65HMc/PBPrcDBu/sLOQDHFo9GTjY0jGBZZZs0fils=; h=From:To:Subject:Date:From; b=QUgr8qMIcEUHWBMzq29oOjOsOj8DLlB0hvO/cUKzQRMzVgLRLxweYTKZTwAD79FMj qNGQcmTMowRWLjvDwX+lNunZ86AV8fK0aF+LFHQMROI1dUZVcbEnXqzFaw6CPlp1mA LCG994xnuPqTZ/Z49Py+cV6ruzv+bbwgU4oiFQdI= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Fri, 23 Oct 2020 08:10:18 +0300 Message-Id: <20201023051021.16389-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/3] libcamera: Miscellaneous constructors and destructors cleanups X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, While reviewing Kieran's copy/move disabling series ("[libcamera-devel] [PATCH 0/5] Delete Copy-Move-Assign"), I noticed a few minor issues in several classes the needlessly define custom empty default constructors and destructors. This patch series fixes it. Laurent Pinchart (3): libcamera: media_object: Remove unneeded destructors libcamera: Drop unneeded empty default constructors and destructors libcamera: Declare empty virtual destructors as defaulted include/libcamera/bound_method.h | 4 ++-- include/libcamera/internal/control_validator.h | 2 +- include/libcamera/internal/ipa_proxy.h | 2 +- include/libcamera/internal/media_object.h | 5 +---- include/libcamera/internal/pipeline_handler.h | 4 ++-- include/libcamera/ipa/ipa_interface.h | 2 +- include/libcamera/signal.h | 1 - src/android/jpeg/encoder.h | 2 +- src/android/post_processor.h | 2 +- src/cam/options.h | 2 +- src/libcamera/media_object.cpp | 18 ------------------ src/libcamera/pipeline/rkisp1/timeline.h | 4 ++-- src/qcam/viewfinder.h | 2 +- test/media_device/media_device_print_test.cpp | 4 ---- 14 files changed, 14 insertions(+), 40 deletions(-)