From patchwork Tue Oct 20 00:03:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 10100 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 801EBBDB1F for ; Tue, 20 Oct 2020 00:04:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5E9BE613BD; Tue, 20 Oct 2020 02:04:06 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="v07i16xo"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 687AA6052F for ; Tue, 20 Oct 2020 02:04:05 +0200 (CEST) Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DA7E352 for ; Tue, 20 Oct 2020 02:04:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1603152245; bh=8Ok8W1BF9o3jrNLEZoEUJk9VPzkGiOJfiDOzOsBHtKk=; h=From:To:Subject:Date:From; b=v07i16xoKVWx/8N+MAA0GTkoqxk+KRWgM49bOvyHx52r6467Pl7wpwmNkKLPzPr1L Z4m644hQMQobHyRXSRRec0P0xrvFeePNxdraLLujavBPKQx0/Ij8ibxLjnh7byI1+h tyy96dTzIs/SX1CbG8b/nwjj0FZLpzRNDpz7M7Do= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Tue, 20 Oct 2020 03:03:05 +0300 Message-Id: <20201020000310.3008-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/5] libcamera: Miscellaneous documentation fixes X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Hello, This small patch series fixes miscellaneous issues with doxygen. It stems from the need to document the libcamera namespace with the latest doxygen version (current master branch), which is done in patch 5/5. Patches 1/5 to 4/5 fixes small issues uncovered by the libcamera namespace being documented. The only patch that I think may be need discussion is 2/5. Adding #ifndef __DOXYGEN__ to all pipeline-specific IPA headers isn't very nice, but there's no easy way to get doxygen to skip them. Listing the files to be skipped explicitly to Doxyfile.in isn't great. Another option would be to move those files to a separate directory, for instance include/ipa/pipeline/, which can then be listed in Doxyfile.in. Please let me know of your preference. Laurent Pinchart (5): ipa: Rename ipa_vimc.h to vimc.h ipa: Skip doxygen parsing for pipeline-specific IPA headers libcamera: Place doxygen \file block above namespace libcamera: Drop semicolon after LOG_{DECLARE,DEFINE}_CATEGORY libcamera: Document the libcamera namespace include/libcamera/ipa/raspberrypi.h | 4 ++++ include/libcamera/ipa/rkisp1.h | 4 ++++ include/libcamera/ipa/{ipa_vimc.h => vimc.h} | 6 +++++- src/ipa/vimc/vimc.cpp | 2 +- src/libcamera/byte_stream_buffer.cpp | 8 ++++---- src/libcamera/camera_manager.cpp | 3 +++ src/libcamera/camera_sensor.cpp | 2 +- src/libcamera/file.cpp | 2 +- src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp | 2 +- src/libcamera/pipeline/simple/converter.cpp | 2 +- src/libcamera/sysfs.cpp | 2 +- src/libcamera/v4l2_pixelformat.cpp | 1 + src/libcamera/v4l2_videodevice.cpp | 1 + test/ipa/ipa_interface_test.cpp | 2 +- 14 files changed, 29 insertions(+), 12 deletions(-) rename include/libcamera/ipa/{ipa_vimc.h => vimc.h} (80%)