From patchwork Fri Oct 16 09:00:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 10077 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 77975BDB1F for ; Fri, 16 Oct 2020 09:00:20 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C9CDE610CC; Fri, 16 Oct 2020 11:00:19 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="jlFHxcov"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BE22860532 for ; Fri, 16 Oct 2020 11:00:18 +0200 (CEST) Received: from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3A707528; Fri, 16 Oct 2020 11:00:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1602838818; bh=aTHYZfnNqKCCR9A3lXsCG+YMaOAAu5q3Cf+dw4MU0Ec=; h=From:To:Cc:Subject:Date:From; b=jlFHxcovo2jiinu17K+rUmG/nEX6xjtcpqqV9PRHro63WxTQIVSfnHA3XqituSuYt Zuka2eDUZhTT38g3jWP360PM3V/5Jya4rab77wOBMq/3GJ/eY+M7FXW94GKQqcl/q/ MGzRabY04YyU2KvqYkGoXgE56fAi1Hrlk3ebtGDs= From: Kieran Bingham To: libcamera devel Date: Fri, 16 Oct 2020 10:00:03 +0100 Message-Id: <20201016090014.64703-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 00/11] Shadowed Variables X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Final spin of the shadowed variables series. Minor fixups mostly to renaming the use of the word 'alias' in this series to be 'shadow'. All tests pass, and I'll push this this evening or next week if no blockers are identified. Kieran Bingham (11): cam: options: Rename optional arg to prevent shadowing qcam: main_window: Explicitly name raw buffer libcamera: thread: Prevent shadowing of signal name libcamera: pipeline: Prevent variable shadowing libcamera: pipeline: Use existing variable definitions libcamera: pipeline: rpi_stream: Explicitly name requestBuffer libcamera: v4l2_videodevice: Prevent shadowing of V4L2BufferCache members test: v4l2_videodevice: Prevent variable shadowing of format ipa: raspberrypi: Re-use iterator variable android: metadata: Disable -Wshadow meson: Enable shadowed variable warning include/libcamera/internal/v4l2_videodevice.h | 4 ++-- meson.build | 1 + src/android/meson.build | 1 + src/cam/options.cpp | 10 +++++----- src/ipa/raspberrypi/controller/rpi/alsc.cpp | 6 +++--- src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 8 ++++---- src/libcamera/pipeline/raspberrypi/rpi_stream.cpp | 8 ++++---- src/libcamera/pipeline/simple/converter.cpp | 8 ++++---- src/libcamera/pipeline/simple/simple.cpp | 8 ++++---- src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 4 ++-- src/libcamera/thread.cpp | 8 ++++---- src/libcamera/v4l2_videodevice.cpp | 12 ++++++------ src/qcam/main_window.cpp | 8 ++++---- test/v4l2_videodevice/formats.cpp | 6 +++--- 14 files changed, 47 insertions(+), 45 deletions(-)