From patchwork Wed Oct 7 18:57:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 10017 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8DF51BEEDF for ; Wed, 7 Oct 2020 18:57:27 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 232A360730; Wed, 7 Oct 2020 20:57:27 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="L7xBsebc"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F0A6605A8 for ; Wed, 7 Oct 2020 20:57:25 +0200 (CEST) Received: from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 071FF9DA; Wed, 7 Oct 2020 20:57:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1602097045; bh=96tmDI3HB8+qQHfxn9x1eJgbqJOJKy2hz59ojay7jcU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L7xBsebce7td80RFOXd3U30X6Ls2cDBkwihM543MBHkfY/SBm9LJFVJ7HzxCBrncq vvxrITp9tqRRRY7ciK1L8g84E0fdQAZtlaYnVIn//zcvB69o/Ns9Z4ueM3Xn7/CTYp Tz52LGVPqkulnsVYbiuCt/fNahGcHrX4h+7ZZysE= From: Kieran Bingham To: libcamera devel Date: Wed, 7 Oct 2020 19:57:17 +0100 Message-Id: <20201007185719.3208272-1-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200911162039.61933-1-jacopo@jmondi.org> References: <20200911162039.61933-1-jacopo@jmondi.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 0/2] draft controls and properties support X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This provides support to allow namespaced draft controls and properties. I feared this may be a contentious topic, but I think it helps clarify the state of the 'draft' controls/properties. Also by having a dedicated flag/key - it means we can (more) easily do things like potentially highlight the items in doxygen or flag them in a certain way - or even simply be able to generate a report of 'these are the controls which are available - but not confirmed yet'. First patch adds the support, second patch demonstrates it by converting the rotation property into a draft property ;-) (Not for merge of course hehe). Kieran Bingham (2): properties: Support draft controls and properties DNI: How to use a draft control include/libcamera/control_ids.h.in | 6 ++++ include/libcamera/property_ids.h.in | 6 ++++ src/libcamera/camera_sensor.cpp | 2 +- .../pipeline/raspberrypi/raspberrypi.cpp | 2 +- src/libcamera/property_ids.cpp.in | 13 +++++++ src/libcamera/property_ids.yaml | 1 + utils/gen-controls.py | 36 ++++++++++++++----- 7 files changed, 56 insertions(+), 10 deletions(-)