[{"id":13042,"web_url":"https://patchwork.libcamera.org/comment/13042/","msgid":"<179ac07a-bb2c-f711-119e-e77a5dc98b28@ideasonboard.com>","date":"2020-10-07T09:45:40","subject":"Re: [libcamera-devel] [PATCH 2/4] meson: enable no-psabi for gcc 9+","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Tomi,\n\nOn 07/10/2020 10:22, Tomi Valkeinen wrote:\n> I get the warnings related to psabi with:\n> \n> gcc 9.3.0 \"arm-buildroot-linux-gnueabihf-g++.br_real (Buildroot 2020.08-24-gc5c5f1fa46) 9.3.0\"\n> \n> Remove the check for gcc-9, so that -Wno-psabi is used on all gcc\n> versions over 7.1.\n\nIt doesn't seem unreasonable to keep this disabled for now.\n\nShould it be < 10 instead though?\n\nWe're not *yet* worried about abi stability anyway, but perhaps we'll\nneed to check through some of this when we do consider stabilising.\n\nIt might be that we end up requiring a greater minimum compiler or such\nto prevent us hitting the changes that were affected. But for now ...\n\nWith some consideration of if <10 is more applicable or not, and\neitherway after that:\n\nReviewed-by: Kieran Bingham \n\n\n> \n> Signed-off-by: Tomi Valkeinen \n> ---\n> meson.build | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/meson.build b/meson.build\n> index dd88eea..16f1c6f 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -75,8 +75,7 @@ if cc.get_id() == 'gcc'\n> # passing on ARM platforms. This generates a large number of messages\n> # during compilation with gcc >=7.1 until gcc 9. Silence them.\n> if (host_machine.cpu_family() == 'arm' and\n> - cc.version().version_compare('>=7.1') and\n> - cc.version().version_compare('<9'))\n> + cc.version().version_compare('>=7.1'))\n> cpp_arguments += [\n> '-Wno-psabi',\n> ]\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0359DBEEDF\n\tfor ;\n\tWed, 7 Oct 2020 09:45:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8D42763CAF;\n\tWed, 7 Oct 2020 11:45:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 262656035F\n\tfor ;\n\tWed, 7 Oct 2020 11:45:43 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B5C59DA;\n\tWed, 7 Oct 2020 11:45:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LhZMAAbD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602063942;\n\tbh=/+qEpgzKCyeCWmPeUQYdgZtH8s+upf2vUooDYHwl7aQ=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=LhZMAAbDT2rg9Ef1889IR37G2y3htvFTVjjiaYzCwgWoNop9sKOHMlO4m1gF4xGRG\n\thqqv1BZxEWxzWQYF+J+jAjdkJYQojDwW9rzpQwJpsDY87Ovm6OiULQE8t3cHr0ABrP\n\tiAws2SxJ9Wl31cn64r/1B+nqjje880vtPUFYng38=","To":"Tomi Valkeinen ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201007092239.41704-1-tomi.valkeinen@iki.fi>\n\t<20201007092239.41704-2-tomi.valkeinen@iki.fi>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<179ac07a-bb2c-f711-119e-e77a5dc98b28@ideasonboard.com>","Date":"Wed, 7 Oct 2020 10:45:40 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201007092239.41704-2-tomi.valkeinen@iki.fi>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 2/4] meson: enable no-psabi for gcc 9+","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13068,"web_url":"https://patchwork.libcamera.org/comment/13068/","msgid":"<20201007132920.GG3937@pendragon.ideasonboard.com>","date":"2020-10-07T13:29:20","subject":"Re: [libcamera-devel] [PATCH 2/4] meson: enable no-psabi for gcc 9+","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi and Kieran,\n\nOn Wed, Oct 07, 2020 at 10:45:40AM +0100, Kieran Bingham wrote:\n> On 07/10/2020 10:22, Tomi Valkeinen wrote:\n> > I get the warnings related to psabi with:\n> > \n> > gcc 9.3.0 \"arm-buildroot-linux-gnueabihf-g++.br_real (Buildroot 2020.08-24-gc5c5f1fa46) 9.3.0\"\n> > \n> > Remove the check for gcc-9, so that -Wno-psabi is used on all gcc\n> > versions over 7.1.\n> \n> It doesn't seem unreasonable to keep this disabled for now.\n> \n> Should it be < 10 instead though?\n\nI was going to suggest the same, for the exact same reasons :-)\n\n> We're not *yet* worried about abi stability anyway, but perhaps we'll\n> need to check through some of this when we do consider stabilising.\n> \n> It might be that we end up requiring a greater minimum compiler or such\n> to prevent us hitting the changes that were affected. But for now ...\n> \n> With some consideration of if <10 is more applicable or not, and\n> eitherway after that:\n> \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> > Signed-off-by: Tomi Valkeinen \n> > ---\n> > meson.build | 3 +--\n> > 1 file changed, 1 insertion(+), 2 deletions(-)\n> > \n> > diff --git a/meson.build b/meson.build\n> > index dd88eea..16f1c6f 100644\n> > --- a/meson.build\n> > +++ b/meson.build\n> > @@ -75,8 +75,7 @@ if cc.get_id() == 'gcc'\n> > # passing on ARM platforms. This generates a large number of messages\n> > # during compilation with gcc >=7.1 until gcc 9. Silence them.\n> > if (host_machine.cpu_family() == 'arm' and\n> > - cc.version().version_compare('>=7.1') and\n> > - cc.version().version_compare('<9'))\n> > + cc.version().version_compare('>=7.1'))\n> > cpp_arguments += [\n> > '-Wno-psabi',\n> > ]","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A184BEEE0\n\tfor ;\n\tWed, 7 Oct 2020 13:30:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CBE98605C3;\n\tWed, 7 Oct 2020 15:30:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C39F605BE\n\tfor ;\n\tWed, 7 Oct 2020 15:30:02 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2759B9DA;\n\tWed, 7 Oct 2020 15:30:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IQrnHa3C\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602077402;\n\tbh=0LTLwgh56t/iCX6OIlgzI61Lak8dSwh0C6uBNv/9nU4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IQrnHa3CCDreMDcdg0MBZroftFXIRANszHiKjUoanu7UYRmzmxExXEmaoLixZgF8E\n\tReGTL5UBTB3P7XD0xJWFjfCARmDs9zBisjTNcUpPAO7kSbqlMgq+ByZmVeO5+ESEsC\n\tjPnwYw8CL7kIWmAoyGzoutLGVe5asMkFTtJoaqws=","Date":"Wed, 7 Oct 2020 16:29:20 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20201007132920.GG3937@pendragon.ideasonboard.com>","References":"<20201007092239.41704-1-tomi.valkeinen@iki.fi>\n\t<20201007092239.41704-2-tomi.valkeinen@iki.fi>\n\t<179ac07a-bb2c-f711-119e-e77a5dc98b28@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<179ac07a-bb2c-f711-119e-e77a5dc98b28@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/4] meson: enable no-psabi for gcc 9+","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org,\n\tTomi Valkeinen ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13075,"web_url":"https://patchwork.libcamera.org/comment/13075/","msgid":"<217f0410-fed8-14be-fcd2-ff40d193f62e@iki.fi>","date":"2020-10-07T13:45:04","subject":"Re: [libcamera-devel] [PATCH 2/4] meson: enable no-psabi for gcc 9+","submitter":{"id":70,"url":"https://patchwork.libcamera.org/api/people/70/","name":"Tomi Valkeinen","email":"tomi.valkeinen@iki.fi"},"content":"On 07/10/2020 16:29, Laurent Pinchart wrote:\n> Hi Tomi and Kieran,\n> \n> On Wed, Oct 07, 2020 at 10:45:40AM +0100, Kieran Bingham wrote:\n>> On 07/10/2020 10:22, Tomi Valkeinen wrote:\n>>> I get the warnings related to psabi with:\n>>>\n>>> gcc 9.3.0 \"arm-buildroot-linux-gnueabihf-g++.br_real (Buildroot 2020.08-24-gc5c5f1fa46) 9.3.0\"\n>>>\n>>> Remove the check for gcc-9, so that -Wno-psabi is used on all gcc\n>>> versions over 7.1.\n>>\n>> It doesn't seem unreasonable to keep this disabled for now.\n>>\n>> Should it be < 10 instead though?\n> \n> I was going to suggest the same, for the exact same reasons :-)\n\nSo what is the reason, I didn't quite get that.\n\nDo we not get the warnings on gcc 10?\n\nWhy not just enable -Wno-psabi if the compiler supports it?\n\n Tomi","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D04C6BEEDF\n\tfor ;\n\tWed, 7 Oct 2020 13:45:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 60A17605CB;\n\tWed, 7 Oct 2020 15:45:08 +0200 (CEST)","from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC486605BF\n\tfor ;\n\tWed, 7 Oct 2020 15:45:06 +0200 (CEST)","by mail-lf1-x143.google.com with SMTP id a7so1271871lfk.9\n\tfor ;\n\tWed, 07 Oct 2020 06:45:06 -0700 (PDT)","from [192.168.1.111] (91-152-83-50.elisa-laajakaista.fi.\n\t[91.152.83.50]) by smtp.gmail.com with ESMTPSA id\n\tv14sm340180lfe.79.2020.10.07.06.45.05\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tWed, 07 Oct 2020 06:45:05 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"BjZEdPQ1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=bluFqsRMVDwoZ7FdjLIXDFRF/q9AhTwp7bO4KiquJgY=;\n\tb=BjZEdPQ1P70Fx1Aq25eovggOlo7v912a5QQJ4buQF52pMfSpNn3YkA5YbiJI3eiiZV\n\tD0jeiz6008EnD/MC3cXTxtGIPnpUttDMc69xeYsKyiX8MZHFQhKdW+YjaN6NdPy/px2v\n\t32QVm5l/aYfsVNYwvozjSE1eemxxygg93/C5nRewW8wjeF1DLwivsovnqgy7yQM3Lml+\n\tgjmLi7jAgzI71n5KqOdNn7G7lsXyvOTx9gVry2MZhfK+C9vC2/vmf1KhjY3jZSzakM+K\n\tdHw02yy+hwE1H3h7mVSS9JkdHVmvogfzgoi4cMQa7/7KoIsZIkr9NKX8F75z8k2fy9hW\n\tMYGQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=bluFqsRMVDwoZ7FdjLIXDFRF/q9AhTwp7bO4KiquJgY=;\n\tb=i3rmOEPM18rJm+xgOW5CrTbz9mmCaC35KxT9J/1h4W//pg57rB3njFhiR8Uiz+SSFO\n\tHz0oBJtB4+qaRObD99Hbrr28BUDyBGylkEmoYfZP3pBNM163LyMZjai1dLg3fuO5Tani\n\tsrwD4qAnz1mpDqjO74/FqW/210S8JfJz+724YcbaDQRCclKSkwvMR5cagzQznzUQxs5D\n\t7bpFUJsV2qNFtYSepwUAXjQnfap4Z0Fdv+37D5tS4qhXUliPTZ8e/XMPVmZ9DK8c4LIQ\n\tzh9eunBnaVKa1peyyZ3MBisMAcwYTX1o7HLJiW4phJg7e4olBS+eP5j+gGwpBpyOMRDn\n\tckSw==","X-Gm-Message-State":"AOAM531815L6xVvdKXuTrexCIeN4NWakm/zenMe+8/Mj1hqhFiDDhzsU\n\tcFAt/7T+DU/egeyRtfzxv1sTRce0qdrLLw==","X-Google-Smtp-Source":"ABdhPJxLtvR93WuqqKBcz+Wxg9j1MdxGSLZxyT6MYS2J0HSCjoGCdA0xr5HijLZAbeeoZ2KeQ2g0yA==","X-Received":"by 2002:a19:c002:: with SMTP id q2mr912673lff.372.1602078305935; \n\tWed, 07 Oct 2020 06:45:05 -0700 (PDT)","To":"Laurent Pinchart ,\n\tKieran Bingham ","References":"<20201007092239.41704-1-tomi.valkeinen@iki.fi>\n\t<20201007092239.41704-2-tomi.valkeinen@iki.fi>\n\t<179ac07a-bb2c-f711-119e-e77a5dc98b28@ideasonboard.com>\n\t<20201007132920.GG3937@pendragon.ideasonboard.com>","From":"Tomi Valkeinen ","Message-ID":"<217f0410-fed8-14be-fcd2-ff40d193f62e@iki.fi>","Date":"Wed, 7 Oct 2020 16:45:04 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201007132920.GG3937@pendragon.ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 2/4] meson: enable no-psabi for gcc 9+","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13076,"web_url":"https://patchwork.libcamera.org/comment/13076/","msgid":"<20201007134746.GM3937@pendragon.ideasonboard.com>","date":"2020-10-07T13:47:46","subject":"Re: [libcamera-devel] [PATCH 2/4] meson: enable no-psabi for gcc 9+","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Oct 07, 2020 at 04:45:04PM +0300, Tomi Valkeinen wrote:\n> On 07/10/2020 16:29, Laurent Pinchart wrote:\n> > Hi Tomi and Kieran,\n> > \n> > On Wed, Oct 07, 2020 at 10:45:40AM +0100, Kieran Bingham wrote:\n> >> On 07/10/2020 10:22, Tomi Valkeinen wrote:\n> >>> I get the warnings related to psabi with:\n> >>>\n> >>> gcc 9.3.0 \"arm-buildroot-linux-gnueabihf-g++.br_real (Buildroot 2020.08-24-gc5c5f1fa46) 9.3.0\"\n> >>>\n> >>> Remove the check for gcc-9, so that -Wno-psabi is used on all gcc\n> >>> versions over 7.1.\n> >>\n> >> It doesn't seem unreasonable to keep this disabled for now.\n> >>\n> >> Should it be < 10 instead though?\n> > \n> > I was going to suggest the same, for the exact same reasons :-)\n> \n> So what is the reason, I didn't quite get that.\n> \n> Do we not get the warnings on gcc 10?\n> \n> Why not just enable -Wno-psabi if the compiler supports it?\n\nIn order to be notified of future ABI changes. Currently we get warned\nthat an ABI we use changed on gcc-7.1, and that's alright. If we\nsuppress the warning unconditionally, once gcc 11 gets released for\nexample, it may warn us of ABI changes introduced in gcc 11. I would\nexpect the gcc 7.1 ABI warning to get disabled at some point. I wonder\nif there's a way to disable ABI warnings of gcc <= 7 only.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 73FA0BEEE0\n\tfor ;\n\tWed, 7 Oct 2020 13:48:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 057D760716;\n\tWed, 7 Oct 2020 15:48:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8C48B6039B\n\tfor ;\n\tWed, 7 Oct 2020 15:48:28 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F13279DA;\n\tWed, 7 Oct 2020 15:48:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OSOW42sz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602078508;\n\tbh=N5SdN2YlLoNKe3tp0ndVA3ATWPRd4EREX9xGK6RGn/A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OSOW42sz39n53FytXxzrncJObzGvlV4b16zfEmlJtdl3LoH6qTekHtN/uZ12jhRC9\n\tgvhoXf0Qwws17/dHil4diT7Su+uaX1afFvJsDQG716EMVtyBKmL9szyGVDzrvdF62w\n\tbpeyOPtUH5s77cn/MAmjkalleMvJjbDm2b4bU338=","Date":"Wed, 7 Oct 2020 16:47:46 +0300","From":"Laurent Pinchart ","To":"Tomi Valkeinen ","Message-ID":"<20201007134746.GM3937@pendragon.ideasonboard.com>","References":"<20201007092239.41704-1-tomi.valkeinen@iki.fi>\n\t<20201007092239.41704-2-tomi.valkeinen@iki.fi>\n\t<179ac07a-bb2c-f711-119e-e77a5dc98b28@ideasonboard.com>\n\t<20201007132920.GG3937@pendragon.ideasonboard.com>\n\t<217f0410-fed8-14be-fcd2-ff40d193f62e@iki.fi>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<217f0410-fed8-14be-fcd2-ff40d193f62e@iki.fi>","Subject":"Re: [libcamera-devel] [PATCH 2/4] meson: enable no-psabi for gcc 9+","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13079,"web_url":"https://patchwork.libcamera.org/comment/13079/","msgid":"","date":"2020-10-07T14:17:57","subject":"Re: [libcamera-devel] [PATCH 2/4] meson: enable no-psabi for gcc 9+","submitter":{"id":70,"url":"https://patchwork.libcamera.org/api/people/70/","name":"Tomi Valkeinen","email":"tomi.valkeinen@iki.fi"},"content":"On 07/10/2020 16:47, Laurent Pinchart wrote:\n> On Wed, Oct 07, 2020 at 04:45:04PM +0300, Tomi Valkeinen wrote:\n>> On 07/10/2020 16:29, Laurent Pinchart wrote:\n>>> Hi Tomi and Kieran,\n>>>\n>>> On Wed, Oct 07, 2020 at 10:45:40AM +0100, Kieran Bingham wrote:\n>>>> On 07/10/2020 10:22, Tomi Valkeinen wrote:\n>>>>> I get the warnings related to psabi with:\n>>>>>\n>>>>> gcc 9.3.0 \"arm-buildroot-linux-gnueabihf-g++.br_real (Buildroot 2020.08-24-gc5c5f1fa46) 9.3.0\"\n>>>>>\n>>>>> Remove the check for gcc-9, so that -Wno-psabi is used on all gcc\n>>>>> versions over 7.1.\n>>>>\n>>>> It doesn't seem unreasonable to keep this disabled for now.\n>>>>\n>>>> Should it be < 10 instead though?\n>>>\n>>> I was going to suggest the same, for the exact same reasons :-)\n>>\n>> So what is the reason, I didn't quite get that.\n>>\n>> Do we not get the warnings on gcc 10?\n>>\n>> Why not just enable -Wno-psabi if the compiler supports it?\n> \n> In order to be notified of future ABI changes. Currently we get warned\n> that an ABI we use changed on gcc-7.1, and that's alright. If we\n> suppress the warning unconditionally, once gcc 11 gets released for\n> example, it may warn us of ABI changes introduced in gcc 11. I would\n> expect the gcc 7.1 ABI warning to get disabled at some point. I wonder\n> if there's a way to disable ABI warnings of gcc <= 7 only.\n\nHmm... So is the suggestion to keep increasing the gcc version number in meson.build whenever\nsomeone tries a more recent gcc version and gets the warning spam?\n\nAnd if in the future there's a new ABI change, we hit the warnings, and then we again add a gcc\nversion range where we add -Wno-psabi to get rid of the warnings?\n\nThis sounds a bit silly. Perhaps I'm missing something. I'm not sure what is the point with these\nwarnings if the solution is always to add -Wno-psabi, which silences all psabi changes.\n\n Tomi","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EDA9DBEEE0\n\tfor ;\n\tWed, 7 Oct 2020 14:18:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 797FE605C1;\n\tWed, 7 Oct 2020 16:18:01 +0200 (CEST)","from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E99F3605BE\n\tfor ;\n\tWed, 7 Oct 2020 16:17:59 +0200 (CEST)","by mail-lf1-x142.google.com with SMTP id d24so2470179lfa.8\n\tfor ;\n\tWed, 07 Oct 2020 07:17:59 -0700 (PDT)","from [192.168.1.111] (91-152-83-50.elisa-laajakaista.fi.\n\t[91.152.83.50]) by smtp.gmail.com with ESMTPSA id\n\t21sm349787lfd.272.2020.10.07.07.17.58\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tWed, 07 Oct 2020 07:17:58 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"s0qa275X\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=fisZqMN04XZV3OFx3aUJ/5cZBZ2JFzmzxCiKnr0J/rA=;\n\tb=s0qa275XjGOVAXNMkFMtG+GkSze1+C7dPyMr/g74huwWHL7487KlQrscJo6nj0zIm+\n\tpX3FY15iDdXZLl39M4itVyg+xgYJ1+vakfsRHtL/i1BS4KyewZB9gSeRy6C2SyuwDQFo\n\tvpPLjaklrF07OS0ApMnP3wFLCVMVP9E4/zpfLG96osfY09uGDkMWulkQfr2hg1fpRAKB\n\ttQjEtuTEKkXX3rTNXbMJnAAmVmtwhR0NlZ8EAKwhdfHixXewl9YEBQldZ2bfUW1lqxgA\n\t6qaxeP2OV9+rMNlDascnmkBMwBxPcaKfBiOx7LemLv5daQS5YXI3D424XE/ozKGQ0Wsu\n\tw4Og==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=fisZqMN04XZV3OFx3aUJ/5cZBZ2JFzmzxCiKnr0J/rA=;\n\tb=uQCj2iBhnsqroZ33Zc21WbJYcDTynYVJBxCQhVhWI+GMo0SbL/rjMqaaTkHvq/jWRi\n\tTypA8UQvcNf1wrQhA9s7uL3wCgb2mxLigsVaPV5Dpli+LpbFlryljT6rV7TDFxWI0Hs+\n\tH03gqNDyr4LRvL1t3OSfKmOmXmpAa61lJIIgJ7ncfX9e/cMBQwJ/GOwfAWdQDDI/RhPI\n\t5SqKlEOrQKi3HjS3u2vG4AeEAh3Z3aDbQJMdmer37xQ0MlxA70gFKLbOfMjA4iSj5QtW\n\tuoSuIH/0rRUKgQISlKelhOo+ARvuJp+3jfu2KIwfQ4EyWzbp57FIuwkX1X+c3QIB2T1/\n\tyEQg==","X-Gm-Message-State":"AOAM530BjUbMVTS5p4JEENxE4Er/t+N625nd1rsvPPqDzOSQiLqOhocZ\n\tFZiOCXxEP7bB6A6U1KOMd12rcYRd967XkA==","X-Google-Smtp-Source":"ABdhPJyb7MnsRCGW0zqBkFFfBnhrkp/cGXj8KlWLKsB5AVoAaN9sx9cRran7mMi4Esswd84Zt0k8Dg==","X-Received":"by 2002:a19:c150:: with SMTP id r77mr978403lff.288.1602080278801;\n\tWed, 07 Oct 2020 07:17:58 -0700 (PDT)","To":"Laurent Pinchart ","References":"<20201007092239.41704-1-tomi.valkeinen@iki.fi>\n\t<20201007092239.41704-2-tomi.valkeinen@iki.fi>\n\t<179ac07a-bb2c-f711-119e-e77a5dc98b28@ideasonboard.com>\n\t<20201007132920.GG3937@pendragon.ideasonboard.com>\n\t<217f0410-fed8-14be-fcd2-ff40d193f62e@iki.fi>\n\t<20201007134746.GM3937@pendragon.ideasonboard.com>","From":"Tomi Valkeinen ","Message-ID":"","Date":"Wed, 7 Oct 2020 17:17:57 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201007134746.GM3937@pendragon.ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 2/4] meson: enable no-psabi for gcc 9+","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13102,"web_url":"https://patchwork.libcamera.org/comment/13102/","msgid":"<3ea45feb-be69-257a-b587-21b61dce4dbd@ideasonboard.com>","date":"2020-10-08T09:18:16","subject":"Re: [libcamera-devel] [PATCH 2/4] meson: enable no-psabi for gcc 9+","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Tomi,\n\nOn 07/10/2020 15:17, Tomi Valkeinen wrote:\n> On 07/10/2020 16:47, Laurent Pinchart wrote:\n>> On Wed, Oct 07, 2020 at 04:45:04PM +0300, Tomi Valkeinen wrote:\n>>> On 07/10/2020 16:29, Laurent Pinchart wrote:\n>>>> Hi Tomi and Kieran,\n>>>>\n>>>> On Wed, Oct 07, 2020 at 10:45:40AM +0100, Kieran Bingham wrote:\n>>>>> On 07/10/2020 10:22, Tomi Valkeinen wrote:\n>>>>>> I get the warnings related to psabi with:\n>>>>>>\n>>>>>> gcc 9.3.0 \"arm-buildroot-linux-gnueabihf-g++.br_real (Buildroot 2020.08-24-gc5c5f1fa46) 9.3.0\"\n>>>>>>\n>>>>>> Remove the check for gcc-9, so that -Wno-psabi is used on all gcc\n>>>>>> versions over 7.1.\n>>>>>\n>>>>> It doesn't seem unreasonable to keep this disabled for now.\n>>>>>\n>>>>> Should it be < 10 instead though?\n>>>>\n>>>> I was going to suggest the same, for the exact same reasons :-)\n>>>\n>>> So what is the reason, I didn't quite get that.\n>>>\n>>> Do we not get the warnings on gcc 10?\n>>>\n>>> Why not just enable -Wno-psabi if the compiler supports it?\n>>\n>> In order to be notified of future ABI changes. Currently we get warned\n>> that an ABI we use changed on gcc-7.1, and that's alright. If we\n>> suppress the warning unconditionally, once gcc 11 gets released for\n>> example, it may warn us of ABI changes introduced in gcc 11. I would\n>> expect the gcc 7.1 ABI warning to get disabled at some point. I wonder\n>> if there's a way to disable ABI warnings of gcc <= 7 only.\n> \n> Hmm... So is the suggestion to keep increasing the gcc version number in meson.build whenever\n> someone tries a more recent gcc version and gets the warning spam?\n\nCurrently, Yes ;-)\n\n\n> And if in the future there's a new ABI change, we hit the warnings, and then we again add a gcc\n> version range where we add -Wno-psabi to get rid of the warnings?\n\nYes ... until the point we declare ourselves ABI stable. At that point,\nthings change.\n\nExtending the -Wno-psabi is papering over the cracks we don't care\nabout. But when we want to be ABI stable - those cracks are suddenly\nimportant.\n\n\n> This sounds a bit silly. Perhaps I'm missing something. I'm not sure what is the point with these\n> warnings if the solution is always to add -Wno-psabi, which silences all psabi changes.\n\n\nI haven't checked/seen the recent warnings, but from my understanding\nthey say something like\n\n \"If you compile the library with GCC 6, and the application with GCC 7\n- it will break in magical ways you would not expect\"\n\nWhich could happen for instance if the library was provided by the\ndistribution, and an individual compiled an application with a different\ntool-chain version...\n\nWe currently have a minimum GCC version of 7, so we don't care about\nthat, and we're happy to ignore the warnings.\n\nIf GCC one day decides to add an ABI break at gcc 10 however, that\nstatement would change to:\n\n \"If you compile the library with GCC 9, and an application with GCC 10\n- It will break in magical ways you would not expect\"\n\nand that would be more problematic for us.\n\nSo we're happy to defer the warnings for now, but we can't ignore any\nfuture additions.\n\n\n> Tomi\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AD404BEEDF\n\tfor ;\n\tThu, 8 Oct 2020 09:18:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 43F98605BD;\n\tThu, 8 Oct 2020 11:18:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 06CC160358\n\tfor ;\n\tThu, 8 Oct 2020 11:18:20 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4B63659E;\n\tThu, 8 Oct 2020 11:18:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VPHRn9eq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602148699;\n\tbh=1Yjhmndxo7tbILGBWP5j6wYml4t2wxk+4DOWIshbvQ0=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=VPHRn9eqosG7UADkD1heCWrKD7WpVI70ehWkeRhGURs1iWLcfrMiVtvdTH+VwhfxC\n\tBicAtPEGMrPjWo6WBkMzNRw6F6WZ+dmtuKOkZuiCBwsBfaf/bLVbCCrEN0yhEV/ZWJ\n\t059in6WGbfIJCHZVfsxg2ovrHQtPqecV+y0OLjx8=","To":"Tomi Valkeinen ,\n\tLaurent Pinchart ","References":"<20201007092239.41704-1-tomi.valkeinen@iki.fi>\n\t<20201007092239.41704-2-tomi.valkeinen@iki.fi>\n\t<179ac07a-bb2c-f711-119e-e77a5dc98b28@ideasonboard.com>\n\t<20201007132920.GG3937@pendragon.ideasonboard.com>\n\t<217f0410-fed8-14be-fcd2-ff40d193f62e@iki.fi>\n\t<20201007134746.GM3937@pendragon.ideasonboard.com>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<3ea45feb-be69-257a-b587-21b61dce4dbd@ideasonboard.com>","Date":"Thu, 8 Oct 2020 10:18:16 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 2/4] meson: enable no-psabi for gcc 9+","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13105,"web_url":"https://patchwork.libcamera.org/comment/13105/","msgid":"<8d95eb2c-d751-75a5-991b-f1f3633a2515@iki.fi>","date":"2020-10-08T10:27:30","subject":"Re: [libcamera-devel] [PATCH 2/4] meson: enable no-psabi for gcc 9+","submitter":{"id":70,"url":"https://patchwork.libcamera.org/api/people/70/","name":"Tomi Valkeinen","email":"tomi.valkeinen@iki.fi"},"content":"Hi,\n\nOn 08/10/2020 12:18, Kieran Bingham wrote:\n\n>> This sounds a bit silly. Perhaps I'm missing something. I'm not sure what is the point with these\n>> warnings if the solution is always to add -Wno-psabi, which silences all psabi changes.\n> \n> \n> I haven't checked/seen the recent warnings, but from my understanding\n> they say something like\n> \n> \"If you compile the library with GCC 6, and the application with GCC 7\n> - it will break in magical ways you would not expect\"\n\nnote: parameter passing for argument of type ‘std::_Rb_tree_const_iterator >’ changed in GCC 7.1\n\n> Which could happen for instance if the library was provided by the\n> distribution, and an individual compiled an application with a different\n> tool-chain version...\n> \n> We currently have a minimum GCC version of 7, so we don't care about\n> that, and we're happy to ignore the warnings.\n\nBut... What does libcamera's minimum gcc version affect? A library libcamera uses against could be\ncompiled with earlier gcc, no?\n\nOr if we consider the ABI from libcamera, libcamera could be compiled on gcc 7, and the application\non gcc 6.\n\n> If GCC one day decides to add an ABI break at gcc 10 however, that\n> statement would change to:\n> \n> \"If you compile the library with GCC 9, and an application with GCC 10\n> - It will break in magical ways you would not expect\"\n> \n> and that would be more problematic for us.\n> \n> So we're happy to defer the warnings for now, but we can't ignore any\n> future additions.\n\nBut how do we separate the two different ABI breakages? There's just -Wno-psabi. If I understand\nwhat you say correctly, we'd like to see the new warning, but not the old one.\n\nAnd... So what's the fix? Rewrite all the code affected by the ABI change in some other way, so that\nyou don't hit the ABI change? Is that even realistic? Isn't the only real fix just requiring the\npeople to compile libraries and apps with gcc versions that are ABI compatible?\n\nI don't think I get this whole thing =). But I'm fine with increasing the version check to < 10, as\nI'm currently using gcc 9. I'll probably switch my buildroot to gcc 10 at some point in the near\nfuture, and then I can send a new patch.\n\n Tomi","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 32ECEBEEE0\n\tfor ;\n\tThu, 8 Oct 2020 10:27:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A40B2605BB;\n\tThu, 8 Oct 2020 12:27:33 +0200 (CEST)","from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B806860391\n\tfor ;\n\tThu, 8 Oct 2020 12:27:32 +0200 (CEST)","by mail-lf1-x142.google.com with SMTP id 184so5878988lfd.6\n\tfor ;\n\tThu, 08 Oct 2020 03:27:32 -0700 (PDT)","from [192.168.1.111] (91-152-83-50.elisa-laajakaista.fi.\n\t[91.152.83.50]) by smtp.gmail.com with ESMTPSA id\n\t124sm588178lfi.114.2020.10.08.03.27.31\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tThu, 08 Oct 2020 03:27:31 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"G2xGRnAx\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=/w1UYCDiyI11Xasb15c17k+WWbZJyRXEkDVg1Uy4JFs=;\n\tb=G2xGRnAxtC0jPH4z1c5aVRrefEuoYHBYJDNh0F+Zt9axPQIED3a61huzyizb0N0IhR\n\tR1VlK+ZrkG3CiDOlwXTbEZv4apq2/xZ5jOFblN0pA4QeSFgsrWzyVrLoIYAn7dfqWXR6\n\taxeX9512pJ3/azY0Afj1t2WZ9frcdAPQ2JKFbpg9w8Lp73g/fBmWOrInF2/k7saix0S/\n\tjbqJ6onU+Z5LGLyngpnWnwNOBl4gNBYIasQwO28Y/B2bEsjhZ1Cp3KbC+tbpqRyO0jF2\n\t6rRB/bCknURIKCPwbuyTClTZQyiHMgvHkB8O29G4Hq5FXdbCkWP4SUPkTh3QmuvEaENb\n\ta/Rg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=/w1UYCDiyI11Xasb15c17k+WWbZJyRXEkDVg1Uy4JFs=;\n\tb=UG5fbq/6otp7DKcfvwa8wJu3EtuB0c9+SiOnegoGhVW/29ocx5QO61KYjBOFarVfmI\n\t2su5xsWSRffqlkZ5TRHKgvKQEFFEsrpHH+rxtjR5ZjhRj4Ki2N/V/4EHIGVYgzVGvr50\n\tg9yJps1kLyDboufxuove5Q6cuErK2FGUTqaQwl0wIo8U71BGTSQXkDPhqWxkL2EDEYyR\n\tAcav2uJoOA6kFl9IiQn3Bck5fcplzbux/AU9K6SbebEFxOmrjfiWi04755XHl63p40la\n\tVqrFFjnKs7vZbUJVLkLOxkZW1jOifUftYDCuUr2NoBccfMtcbXOKAGE7KSiBIwKt/M7N\n\t5fHA==","X-Gm-Message-State":"AOAM533dHbBS6FLhe5VtKgLTsCiz0u8Qqaz9nsVi2mLuzk+aqXxtKqxk\n\tW92VggbYF7AKG/bDWvFJDjH+DMquXylH9g==","X-Google-Smtp-Source":"ABdhPJyF1bHmc0jvghLFs6onogEkj8Ys0ArfYF7JAeyls5sS0MNmq8mMTF5gJXfoIfD29q1CVCHlXw==","X-Received":"by 2002:ac2:4148:: with SMTP id c8mr2282699lfi.278.1602152851720;\n\tThu, 08 Oct 2020 03:27:31 -0700 (PDT)","To":"kieran.bingham@ideasonboard.com,\n\tLaurent Pinchart ","References":"<20201007092239.41704-1-tomi.valkeinen@iki.fi>\n\t<20201007092239.41704-2-tomi.valkeinen@iki.fi>\n\t<179ac07a-bb2c-f711-119e-e77a5dc98b28@ideasonboard.com>\n\t<20201007132920.GG3937@pendragon.ideasonboard.com>\n\t<217f0410-fed8-14be-fcd2-ff40d193f62e@iki.fi>\n\t<20201007134746.GM3937@pendragon.ideasonboard.com>\n\t\n\t<3ea45feb-be69-257a-b587-21b61dce4dbd@ideasonboard.com>","From":"Tomi Valkeinen ","Message-ID":"<8d95eb2c-d751-75a5-991b-f1f3633a2515@iki.fi>","Date":"Thu, 8 Oct 2020 13:27:30 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<3ea45feb-be69-257a-b587-21b61dce4dbd@ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 2/4] meson: enable no-psabi for gcc 9+","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13119,"web_url":"https://patchwork.libcamera.org/comment/13119/","msgid":"<20201009013742.GO3939@pendragon.ideasonboard.com>","date":"2020-10-09T01:37:42","subject":"Re: [libcamera-devel] [PATCH 2/4] meson: enable no-psabi for gcc 9+","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nOn Thu, Oct 08, 2020 at 01:27:30PM +0300, Tomi Valkeinen wrote:\n> On 08/10/2020 12:18, Kieran Bingham wrote:\n> \n> >> This sounds a bit silly. Perhaps I'm missing something. I'm not sure what is the point with these\n> >> warnings if the solution is always to add -Wno-psabi, which silences all psabi changes.\n> > \n> > \n> > I haven't checked/seen the recent warnings, but from my understanding\n> > they say something like\n> > \n> > \"If you compile the library with GCC 6, and the application with GCC 7\n> > - it will break in magical ways you would not expect\"\n> \n> note: parameter passing for argument of type ‘std::_Rb_tree_const_iterator libcamera::PixelFormat, libcamera::PixelFormatInfo> >’ changed in GCC 7.1\n> \n> > Which could happen for instance if the library was provided by the\n> > distribution, and an individual compiled an application with a different\n> > tool-chain version...\n> > \n> > We currently have a minimum GCC version of 7, so we don't care about\n> > that, and we're happy to ignore the warnings.\n> \n> But... What does libcamera's minimum gcc version affect? A library\n> libcamera uses against could be compiled with earlier gcc, no?\n> \n> Or if we consider the ABI from libcamera, libcamera could be compiled\n> on gcc 7, and the application on gcc 6.\n> \n> > If GCC one day decides to add an ABI break at gcc 10 however, that\n> > statement would change to:\n> > \n> > \"If you compile the library with GCC 9, and an application with GCC 10\n> > - It will break in magical ways you would not expect\"\n> > \n> > and that would be more problematic for us.\n> > \n> > So we're happy to defer the warnings for now, but we can't ignore any\n> > future additions.\n> \n> But how do we separate the two different ABI breakages? There's just\n> -Wno-psabi. If I understand what you say correctly, we'd like to see\n> the new warning, but not the old one.\n\nThat's the idea, but it doesn't seem to be possible.\n\n> And... So what's the fix? Rewrite all the code affected by the ABI\n> change in some other way, so that you don't hit the ABI change? Is\n> that even realistic? Isn't the only real fix just requiring the people\n> to compile libraries and apps with gcc versions that are ABI\n> compatible?\n> \n> I don't think I get this whole thing =). But I'm fine with increasing\n> the version check to < 10, as I'm currently using gcc 9. I'll probably\n> switch my buildroot to gcc 10 at some point in the near future, and\n> then I can send a new patch.\n\nThe idea is that I'd like to keep an eye on ABI breakages introduced by\ngcc, in a \"just for my information\" fashion for the moment. I don't know\nat this point how such breakages would even be handled (if at all).\n\n\"Just for my information\" is probably not a good enough excuse to annoy\neverybody with warnings when using new compiler versions though. I'd\nthus agree to drop the version check. I wonder how the gcc developers\nhad envisioned this being used though, if there's a warning (which is\nactually not even a warning, but a note), I imagine it was put there\nwith a target audience in mind. Or maybe this is just a mess and nobody\nshould really pay attention :-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5ECE2BEEDF\n\tfor ;\n\tFri, 9 Oct 2020 01:38:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DD75860725;\n\tFri, 9 Oct 2020 03:38:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6840D60391\n\tfor ;\n\tFri, 9 Oct 2020 03:38:26 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C1C6A59E;\n\tFri, 9 Oct 2020 03:38:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KL1tZnil\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602207506;\n\tbh=JO7BKFX1PjRP6ytfQj7y3DmW3Bdg93BWoHE84z8WX/k=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KL1tZnilOMCf1+yqitKW4+Otrx8oKL85SH1hpD4RPTc3mgu2ptJNrf1+Ie886h2Lq\n\tLRvgYMyG3x7Si3/tRhFjEveVRxRsO8Sj7kwS2D1zeKOai5Tfgbh/WbgttGgMMES0y6\n\tozTRRqm3HD92yBjQqOMpsu74uEjiwo/zTm2LStl0=","Date":"Fri, 9 Oct 2020 04:37:42 +0300","From":"Laurent Pinchart ","To":"Tomi Valkeinen ","Message-ID":"<20201009013742.GO3939@pendragon.ideasonboard.com>","References":"<20201007092239.41704-1-tomi.valkeinen@iki.fi>\n\t<20201007092239.41704-2-tomi.valkeinen@iki.fi>\n\t<179ac07a-bb2c-f711-119e-e77a5dc98b28@ideasonboard.com>\n\t<20201007132920.GG3937@pendragon.ideasonboard.com>\n\t<217f0410-fed8-14be-fcd2-ff40d193f62e@iki.fi>\n\t<20201007134746.GM3937@pendragon.ideasonboard.com>\n\t\n\t<3ea45feb-be69-257a-b587-21b61dce4dbd@ideasonboard.com>\n\t<8d95eb2c-d751-75a5-991b-f1f3633a2515@iki.fi>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<8d95eb2c-d751-75a5-991b-f1f3633a2515@iki.fi>","Subject":"Re: [libcamera-devel] [PATCH 2/4] meson: enable no-psabi for gcc 9+","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13121,"web_url":"https://patchwork.libcamera.org/comment/13121/","msgid":"<95d25797-8b54-be10-a2d8-fe3569d9ec67@iki.fi>","date":"2020-10-09T07:03:39","subject":"Re: [libcamera-devel] [PATCH 2/4] meson: enable no-psabi for gcc 9+","submitter":{"id":70,"url":"https://patchwork.libcamera.org/api/people/70/","name":"Tomi Valkeinen","email":"tomi.valkeinen@iki.fi"},"content":"On 09/10/2020 04:37, Laurent Pinchart wrote:\n\n>> I don't think I get this whole thing =). But I'm fine with increasing\n>> the version check to < 10, as I'm currently using gcc 9. I'll probably\n>> switch my buildroot to gcc 10 at some point in the near future, and\n>> then I can send a new patch.\n> \n> The idea is that I'd like to keep an eye on ABI breakages introduced by\n> gcc, in a \"just for my information\" fashion for the moment. I don't know\n> at this point how such breakages would even be handled (if at all).\n> \n> \"Just for my information\" is probably not a good enough excuse to annoy\n> everybody with warnings when using new compiler versions though. I'd\n> thus agree to drop the version check. I wonder how the gcc developers\n> had envisioned this being used though, if there's a warning (which is\n> actually not even a warning, but a note), I imagine it was put there\n> with a target audience in mind. Or maybe this is just a mess and nobody\n> should really pay attention :-)\n\nOk. Yes, I don't get this either. What would make sense is, e.g. \"-Wno-psabi=1,4\", which would\ndisable warnings for ABI breakages #1 and #4, but allow all the other warnings.\n\nWhat I did in kms++ was just:\n\nif (cpp.get_id() == 'gcc' and\n host_machine.cpu_family() == 'arm' and\n cpp.has_argument('-Wno-psabi'))\n\n cpp_arguments += [\n '-Wno-psabi',\n ]\nendif\n\nIt's silly to always disable the warning, but I haven't found much info about it while googling, so\ncurrently I'm guessing it's the \"this is just a mess\" case.\n\n Tomi","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 50B91BEEDF\n\tfor ;\n\tFri, 9 Oct 2020 07:03:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A8F8D6073B;\n\tFri, 9 Oct 2020 09:03:43 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F2C0C60357\n\tfor ;\n\tFri, 9 Oct 2020 09:03:41 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id a23so7762744ljp.5\n\tfor ;\n\tFri, 09 Oct 2020 00:03:41 -0700 (PDT)","from [192.168.1.111] (91-152-83-50.elisa-laajakaista.fi.\n\t[91.152.83.50]) by smtp.gmail.com with ESMTPSA id\n\tm10sm1089692lfo.237.2020.10.09.00.03.40\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tFri, 09 Oct 2020 00:03:40 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Qi1HIu5G\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=20Gia28bEjvQ9S1puidXuYwPqCRXwTflHhMUtXVFvTw=;\n\tb=Qi1HIu5GEzEO5NHTHHe5P6rFkAKzh5PgKhAc8L6Ud9KYEOiP+u5Xlfieu13P9IFmma\n\t2bH4F8Om6KEWCIK6pdtEIPe9R85nPVNN/3WImUxVGMVpGJeuGwgUoao3p6N1gOtFIF5k\n\trlcN+RJlXAsYOS1HOcQwaHoEswL+uES5LTIooaYiwdEuqkZJH8vhRHeWy3xccyhfwofc\n\t3pFncjKbB32Kc6302zxJCYd8Xpm6EO1X378sIfUpO7a166T7ImD9BLe3GdBgZajeDM7/\n\tOd8oUPtYXsLGhInPQvK6g2jFxh4av63Ni0NOkuWclbhgeTgJkK5vYVWy44LDSj55+xg1\n\tYJzw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=20Gia28bEjvQ9S1puidXuYwPqCRXwTflHhMUtXVFvTw=;\n\tb=FdHnIJ4VZczc6u4rN77saeCxQcrMI95d3CJtbLLsYdR5XRp380s++ZRmi04VRCoYcW\n\t+YW00PD7RZbF2fTxSE8hE7gj0bUok6LdxZjm5gwrjEN817gPwjV3gotmq6ZuLxvF27GY\n\tQS1SaRb3lAe1nFIz7Ysu9+c+++UmaQXh3CSUkqHSNCi4bO2ZoD3G9pP9miyj5JefawtS\n\tiaIvsYLudsOdqAfYMYolWx0D+dM4yAG2Ui9JkQYZGNbMmLzqP3tOmpDJ2AU5LQRH5sas\n\tv31PLg53NBfSPiHPVfqXRphsej+BaRU+/4vIH1e1US60teOPOBuWD4gexu34kvAqx5rC\n\twdwA==","X-Gm-Message-State":"AOAM533SFYBuSERMTpp9qBmlyxW4XwQfVeEfA14GsLjNQquTV1e4V1lA\n\t0nBUcIY1MD+uYDyscUOyi08ZdOT7DtMfmw==","X-Google-Smtp-Source":"ABdhPJxbaVbcS7Qa+j9Eb4MRGAsbxktbl+d39In4zV25z2A6Z8SGjp4/dlDKClgtt31MGlVmFxI68w==","X-Received":"by 2002:a2e:94d0:: with SMTP id r16mr43044ljh.292.1602227020946; \n\tFri, 09 Oct 2020 00:03:40 -0700 (PDT)","To":"Laurent Pinchart ","References":"<20201007092239.41704-1-tomi.valkeinen@iki.fi>\n\t<20201007092239.41704-2-tomi.valkeinen@iki.fi>\n\t<179ac07a-bb2c-f711-119e-e77a5dc98b28@ideasonboard.com>\n\t<20201007132920.GG3937@pendragon.ideasonboard.com>\n\t<217f0410-fed8-14be-fcd2-ff40d193f62e@iki.fi>\n\t<20201007134746.GM3937@pendragon.ideasonboard.com>\n\t\n\t<3ea45feb-be69-257a-b587-21b61dce4dbd@ideasonboard.com>\n\t<8d95eb2c-d751-75a5-991b-f1f3633a2515@iki.fi>\n\t<20201009013742.GO3939@pendragon.ideasonboard.com>","From":"Tomi Valkeinen ","Message-ID":"<95d25797-8b54-be10-a2d8-fe3569d9ec67@iki.fi>","Date":"Fri, 9 Oct 2020 10:03:39 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201009013742.GO3939@pendragon.ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 2/4] meson: enable no-psabi for gcc 9+","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13166,"web_url":"https://patchwork.libcamera.org/comment/13166/","msgid":"<20201011235244.GJ3944@pendragon.ideasonboard.com>","date":"2020-10-11T23:52:44","subject":"Re: [libcamera-devel] [PATCH 2/4] meson: enable no-psabi for gcc 9+","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nOn Fri, Oct 09, 2020 at 10:03:39AM +0300, Tomi Valkeinen wrote:\n> On 09/10/2020 04:37, Laurent Pinchart wrote:\n> \n> >> I don't think I get this whole thing =). But I'm fine with increasing\n> >> the version check to < 10, as I'm currently using gcc 9. I'll probably\n> >> switch my buildroot to gcc 10 at some point in the near future, and\n> >> then I can send a new patch.\n> > \n> > The idea is that I'd like to keep an eye on ABI breakages introduced by\n> > gcc, in a \"just for my information\" fashion for the moment. I don't know\n> > at this point how such breakages would even be handled (if at all).\n> > \n> > \"Just for my information\" is probably not a good enough excuse to annoy\n> > everybody with warnings when using new compiler versions though. I'd\n> > thus agree to drop the version check. I wonder how the gcc developers\n> > had envisioned this being used though, if there's a warning (which is\n> > actually not even a warning, but a note), I imagine it was put there\n> > with a target audience in mind. Or maybe this is just a mess and nobody\n> > should really pay attention :-)\n> \n> Ok. Yes, I don't get this either. What would make sense is, e.g.\n> \"-Wno-psabi=1,4\", which would disable warnings for ABI breakages #1\n> and #4, but allow all the other warnings.\n> \n> What I did in kms++ was just:\n> \n> if (cpp.get_id() == 'gcc' and\n> host_machine.cpu_family() == 'arm' and\n> cpp.has_argument('-Wno-psabi'))\n> \n> cpp_arguments += [\n> '-Wno-psabi',\n> ]\n> endif\n> \n> It's silly to always disable the warning, but I haven't found much\n> info about it while googling, so currently I'm guessing it's the \"this\n> is just a mess\" case.\n\nI think I'm getting convinced that this is indeed the right way forward\nfor now. Kieran, what do you think ?","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7C4BCBEEE0\n\tfor ;\n\tSun, 11 Oct 2020 23:53:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EE43560730;\n\tMon, 12 Oct 2020 01:53:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6736960357\n\tfor ;\n\tMon, 12 Oct 2020 01:53:29 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E50BC308;\n\tMon, 12 Oct 2020 01:53:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dHPV3NJc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602460409;\n\tbh=vgFf/CIXvNhlN/W6gdnndbXDA2ggbOxfir8m201PpVg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dHPV3NJc+25YB3Vb1EPuG9eW61T3H3TjNC/cpZpF526bkuq+zdY5vfhpIx8bgdy+X\n\tOa2fL7d8IDgVqm71UPnU+NFHKf6f6DqaUxjvx5Ec5Lw1JAnl3ZgNkoZNIXT7BrUP6Z\n\t0tMmiBdoiF21QnPX4epvq5h8eIeQq/zZnOMba9N8=","Date":"Mon, 12 Oct 2020 02:52:44 +0300","From":"Laurent Pinchart ","To":"Tomi Valkeinen ","Message-ID":"<20201011235244.GJ3944@pendragon.ideasonboard.com>","References":"<20201007092239.41704-2-tomi.valkeinen@iki.fi>\n\t<179ac07a-bb2c-f711-119e-e77a5dc98b28@ideasonboard.com>\n\t<20201007132920.GG3937@pendragon.ideasonboard.com>\n\t<217f0410-fed8-14be-fcd2-ff40d193f62e@iki.fi>\n\t<20201007134746.GM3937@pendragon.ideasonboard.com>\n\t\n\t<3ea45feb-be69-257a-b587-21b61dce4dbd@ideasonboard.com>\n\t<8d95eb2c-d751-75a5-991b-f1f3633a2515@iki.fi>\n\t<20201009013742.GO3939@pendragon.ideasonboard.com>\n\t<95d25797-8b54-be10-a2d8-fe3569d9ec67@iki.fi>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<95d25797-8b54-be10-a2d8-fe3569d9ec67@iki.fi>","Subject":"Re: [libcamera-devel] [PATCH 2/4] meson: enable no-psabi for gcc 9+","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13176,"web_url":"https://patchwork.libcamera.org/comment/13176/","msgid":"","date":"2020-10-12T10:44:34","subject":"Re: [libcamera-devel] [PATCH 2/4] meson: enable no-psabi for gcc 9+","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 12/10/2020 00:52, Laurent Pinchart wrote:\n> Hi Tomi,\n> \n> On Fri, Oct 09, 2020 at 10:03:39AM +0300, Tomi Valkeinen wrote:\n>> On 09/10/2020 04:37, Laurent Pinchart wrote:\n>>\n>>>> I don't think I get this whole thing =). But I'm fine with increasing\n>>>> the version check to < 10, as I'm currently using gcc 9. I'll probably\n>>>> switch my buildroot to gcc 10 at some point in the near future, and\n>>>> then I can send a new patch.\n>>>\n>>> The idea is that I'd like to keep an eye on ABI breakages introduced by\n>>> gcc, in a \"just for my information\" fashion for the moment. I don't know\n>>> at this point how such breakages would even be handled (if at all).\n>>>\n>>> \"Just for my information\" is probably not a good enough excuse to annoy\n>>> everybody with warnings when using new compiler versions though. I'd\n>>> thus agree to drop the version check. I wonder how the gcc developers\n>>> had envisioned this being used though, if there's a warning (which is\n>>> actually not even a warning, but a note), I imagine it was put there\n>>> with a target audience in mind. Or maybe this is just a mess and nobody\n>>> should really pay attention :-)\n>>\n>> Ok. Yes, I don't get this either. What would make sense is, e.g.\n>> \"-Wno-psabi=1,4\", which would disable warnings for ABI breakages #1\n>> and #4, but allow all the other warnings.\n>>\n>> What I did in kms++ was just:\n>>\n>> if (cpp.get_id() == 'gcc' and\n>> host_machine.cpu_family() == 'arm' and\n>> cpp.has_argument('-Wno-psabi'))\n>>\n>> cpp_arguments += [\n>> '-Wno-psabi',\n>> ]\n>> endif\n>>\n>> It's silly to always disable the warning, but I haven't found much\n>> info about it while googling, so currently I'm guessing it's the \"this\n>> is just a mess\" case.\n> \n> I think I'm getting convinced that this is indeed the right way forward\n> for now. Kieran, what do you think ?\n\nThe part of all this that I don't like is that GCC doesn't (seem to)\nhave a way to disable (/acknowledge) the ABI change from v7, to ignore\n'just that set'.\n\nSo indeed, it means that these warnings will currently persist forever -\nand then get blurred in with any additional ones. Which is quite\nfrustrating.\n\nAlong with the lack of control that we have over what tools actually\nbuild our library in distro's etc, I fear this might simply be a problem\nwe defer to the distributions. It's not something that can be handled\nstand-alone at the library level. I don't particularly want to wave the\n'someone else's problem' - but there are simply external factors that\nare outside of our control for this issue - so we can't hope to solve\nthem all.\n\nI don't mind disabling it.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ACD7ABEEDF\n\tfor ;\n\tMon, 12 Oct 2020 10:44:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2925E60D55;\n\tMon, 12 Oct 2020 12:44:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E1EA2600F2\n\tfor ;\n\tMon, 12 Oct 2020 12:44:36 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3CCBB3B;\n\tMon, 12 Oct 2020 12:44:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cykXLtmX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602499476;\n\tbh=ftB539eFfvGOEKpIsQ8+c1I/oAHVpObXdl3Y6LDfzzg=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=cykXLtmXFoDAH8Ym3zRd+qB87bqOUMsKe44xwZWszrl0MQ/H2gjApvpsJ8UVQzUWH\n\t3K9ffTBj3D1SWSxKLHp/uyRd36I349tDtv3W3UExsBzvg4vQmuanCGI45GoCFQIVWV\n\tHVBPAQjVtWD7IcFdlcrmfHJk7WHVC8j3NSdKaihg=","To":"Laurent Pinchart ,\n\tTomi Valkeinen ","References":"<20201007092239.41704-2-tomi.valkeinen@iki.fi>\n\t<179ac07a-bb2c-f711-119e-e77a5dc98b28@ideasonboard.com>\n\t<20201007132920.GG3937@pendragon.ideasonboard.com>\n\t<217f0410-fed8-14be-fcd2-ff40d193f62e@iki.fi>\n\t<20201007134746.GM3937@pendragon.ideasonboard.com>\n\t\n\t<3ea45feb-be69-257a-b587-21b61dce4dbd@ideasonboard.com>\n\t<8d95eb2c-d751-75a5-991b-f1f3633a2515@iki.fi>\n\t<20201009013742.GO3939@pendragon.ideasonboard.com>\n\t<95d25797-8b54-be10-a2d8-fe3569d9ec67@iki.fi>\n\t<20201011235244.GJ3944@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 12 Oct 2020 11:44:34 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201011235244.GJ3944@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 2/4] meson: enable no-psabi for gcc 9+","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13179,"web_url":"https://patchwork.libcamera.org/comment/13179/","msgid":"<20201012112140.GU3944@pendragon.ideasonboard.com>","date":"2020-10-12T11:21:40","subject":"Re: [libcamera-devel] [PATCH 2/4] meson: enable no-psabi for gcc 9+","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Oct 12, 2020 at 11:44:34AM +0100, Kieran Bingham wrote:\n> On 12/10/2020 00:52, Laurent Pinchart wrote:\n> > On Fri, Oct 09, 2020 at 10:03:39AM +0300, Tomi Valkeinen wrote:\n> >> On 09/10/2020 04:37, Laurent Pinchart wrote:\n> >>\n> >>>> I don't think I get this whole thing =). But I'm fine with increasing\n> >>>> the version check to < 10, as I'm currently using gcc 9. I'll probably\n> >>>> switch my buildroot to gcc 10 at some point in the near future, and\n> >>>> then I can send a new patch.\n> >>>\n> >>> The idea is that I'd like to keep an eye on ABI breakages introduced by\n> >>> gcc, in a \"just for my information\" fashion for the moment. I don't know\n> >>> at this point how such breakages would even be handled (if at all).\n> >>>\n> >>> \"Just for my information\" is probably not a good enough excuse to annoy\n> >>> everybody with warnings when using new compiler versions though. I'd\n> >>> thus agree to drop the version check. I wonder how the gcc developers\n> >>> had envisioned this being used though, if there's a warning (which is\n> >>> actually not even a warning, but a note), I imagine it was put there\n> >>> with a target audience in mind. Or maybe this is just a mess and nobody\n> >>> should really pay attention :-)\n> >>\n> >> Ok. Yes, I don't get this either. What would make sense is, e.g.\n> >> \"-Wno-psabi=1,4\", which would disable warnings for ABI breakages #1\n> >> and #4, but allow all the other warnings.\n> >>\n> >> What I did in kms++ was just:\n> >>\n> >> if (cpp.get_id() == 'gcc' and\n> >> host_machine.cpu_family() == 'arm' and\n> >> cpp.has_argument('-Wno-psabi'))\n> >>\n> >> cpp_arguments += [\n> >> '-Wno-psabi',\n> >> ]\n> >> endif\n> >>\n> >> It's silly to always disable the warning, but I haven't found much\n> >> info about it while googling, so currently I'm guessing it's the \"this\n> >> is just a mess\" case.\n> > \n> > I think I'm getting convinced that this is indeed the right way forward\n> > for now. Kieran, what do you think ?\n> \n> The part of all this that I don't like is that GCC doesn't (seem to)\n> have a way to disable (/acknowledge) the ABI change from v7, to ignore\n> 'just that set'.\n> \n> So indeed, it means that these warnings will currently persist forever -\n> and then get blurred in with any additional ones. Which is quite\n> frustrating.\n> \n> Along with the lack of control that we have over what tools actually\n> build our library in distro's etc, I fear this might simply be a problem\n> we defer to the distributions. It's not something that can be handled\n> stand-alone at the library level. I don't particularly want to wave the\n> 'someone else's problem' - but there are simply external factors that\n> are outside of our control for this issue - so we can't hope to solve\n> them all.\n> \n> I don't mind disabling it.\n\nI'll push Tomi's patch with a comment updated to remove gcc < 9.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 42F9EBEEE0\n\tfor ;\n\tMon, 12 Oct 2020 11:22:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BE6E260D55;\n\tMon, 12 Oct 2020 13:22:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D6D10600F2\n\tfor ;\n\tMon, 12 Oct 2020 13:22:26 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 48DF23B;\n\tMon, 12 Oct 2020 13:22:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wgMo2MWq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602501746;\n\tbh=3kXWWG8J8ng6MA514P3GAA1O2fJ4T+y3rNc6g5+zkCs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wgMo2MWq06z/P2dVewAxWHt51H/wLx8Q6yAGO6tUemPl/0EdIZJVBNqmzxJTDdNqK\n\t00eUgzfGAnFLd3w7HtAmEPQkMukkFLpRDgkBd8zc6nHMwgxl1lKIjGtfZ1Or+3ocp/\n\t3FGW2ENfHZuQ6JMYNY4rW/ocAi5F6X4hAbhzGXa0=","Date":"Mon, 12 Oct 2020 14:21:40 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20201012112140.GU3944@pendragon.ideasonboard.com>","References":"<20201007132920.GG3937@pendragon.ideasonboard.com>\n\t<217f0410-fed8-14be-fcd2-ff40d193f62e@iki.fi>\n\t<20201007134746.GM3937@pendragon.ideasonboard.com>\n\t\n\t<3ea45feb-be69-257a-b587-21b61dce4dbd@ideasonboard.com>\n\t<8d95eb2c-d751-75a5-991b-f1f3633a2515@iki.fi>\n\t<20201009013742.GO3939@pendragon.ideasonboard.com>\n\t<95d25797-8b54-be10-a2d8-fe3569d9ec67@iki.fi>\n\t<20201011235244.GJ3944@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 2/4] meson: enable no-psabi for gcc 9+","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org,\n\tTomi Valkeinen ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]