[{"id":13040,"web_url":"https://patchwork.libcamera.org/comment/13040/","msgid":"<52d3eb18-5d31-f3f3-4c23-77e0885b1e35@ideasonboard.com>","date":"2020-10-07T09:37:41","subject":"Re: [libcamera-devel] [PATCH 1/4] cam: options: fix access to\n\tuninit variable","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Tomi,\n\nOn 07/10/2020 10:22, Tomi Valkeinen wrote:\n> operator[] doesn't check if the option exists in the values_ map, so it\n> can return a pointer to location outside the map.\n> \n> Fix by returning an empty OptionValue if the option is not found.\n> \n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Tomi Valkeinen \n> ---\n> src/cam/options.cpp | 7 ++++++-\n> 1 file changed, 6 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/cam/options.cpp b/src/cam/options.cpp\n> index 77b3cc1..8fc1c42 100644\n> --- a/src/cam/options.cpp\n> +++ b/src/cam/options.cpp\n> @@ -61,7 +61,12 @@ bool OptionsBase::isSet(const T &opt) const\n> template\n> const OptionValue &OptionsBase::operator[](const T &opt) const\n> {\n> -\treturn values_.find(opt)->second;\n> +\tstatic const OptionValue s_empty;\n> +\n> +\tauto it = values_.find(opt);\n> +\tif (it != values_.end())\n> +\t\treturn it->second;\n> +\treturn s_empty;\n> }\n> \n> template\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 063C4BEEE0\n\tfor ;\n\tWed, 7 Oct 2020 09:37:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 54FA663CAF;\n\tWed, 7 Oct 2020 11:37:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B9016035F\n\tfor ;\n\tWed, 7 Oct 2020 11:37:44 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9E3B79DA;\n\tWed, 7 Oct 2020 11:37:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LYJTX+Mq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602063463;\n\tbh=Ic7Ncgg8TaVwqB1d75RYfS12SIdbKfvjNPnPxHnmbDM=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=LYJTX+MqaWAJXnR53cvteKGusnbr0K4ZfDQWviSHNkadkJwV8BGBH++CDtYEtS4eV\n\tNDiBSG/Pw1w+J2+g2XeHX3Yrz/IXfG7F2OOjZYLYzJIApjhHtBNK/uOmP+7XTRrymR\n\tLZAOsBVPWpDvDvfSZLTYhHRJfk7PU00FZPfmyi1U=","To":"Tomi Valkeinen ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20201007092239.41704-1-tomi.valkeinen@iki.fi>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<52d3eb18-5d31-f3f3-4c23-77e0885b1e35@ideasonboard.com>","Date":"Wed, 7 Oct 2020 10:37:41 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201007092239.41704-1-tomi.valkeinen@iki.fi>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 1/4] cam: options: fix access to\n\tuninit variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13066,"web_url":"https://patchwork.libcamera.org/comment/13066/","msgid":"<20201007132550.GF3937@pendragon.ideasonboard.com>","date":"2020-10-07T13:25:50","subject":"Re: [libcamera-devel] [PATCH 1/4] cam: options: fix access to\n\tuninit variable","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Tomi,\n\nThank you for the patch.\n\nOn Wed, Oct 07, 2020 at 12:22:36PM +0300, Tomi Valkeinen wrote:\n> operator[] doesn't check if the option exists in the values_ map, so it\n> can return a pointer to location outside the map.\n\nIs this a problem that you've encountered in practice ?\n\nOptionsBase here is used as a map-like container, and our implementation\nof operator[] doesn't match std::map as the latter will insert an\nelement if the key isn't found. I wonder if this could create confusion\nas to what behaviour a user of OptionsBase::operator[] would expect.\n\n> Fix by returning an empty OptionValue if the option is not found.\n> \n> Signed-off-by: Tomi Valkeinen \n> ---\n> src/cam/options.cpp | 7 ++++++-\n> 1 file changed, 6 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/cam/options.cpp b/src/cam/options.cpp\n> index 77b3cc1..8fc1c42 100644\n> --- a/src/cam/options.cpp\n> +++ b/src/cam/options.cpp\n> @@ -61,7 +61,12 @@ bool OptionsBase::isSet(const T &opt) const\n> template\n> const OptionValue &OptionsBase::operator[](const T &opt) const\n> {\n> -\treturn values_.find(opt)->second;\n> +\tstatic const OptionValue s_empty;\n\nThat should be sEmpty to match the coding style, but I'd just call it\nempty as we don't prefix static variables with a prefix to mean they're\nstatic (the same way we have no m_ prefix).\n\n> +\n> +\tauto it = values_.find(opt);\n> +\tif (it != values_.end())\n> +\t\treturn it->second;\n> +\treturn s_empty;\n> }\n> \n> template","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 79B70BEEDF\n\tfor ;\n\tWed, 7 Oct 2020 13:26:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1671E605C1;\n\tWed, 7 Oct 2020 15:26:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F309E605A8\n\tfor ;\n\tWed, 7 Oct 2020 15:26:32 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6E92D9DA;\n\tWed, 7 Oct 2020 15:26:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kUgWDuJP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602077192;\n\tbh=Wb4MbbTAtUpZDxBUWwaflg2j7MZsbJqv7bYNF98KWCw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=kUgWDuJPGQgksfZiCfbryaKCsTehojWHTSbqFgxzrefh5mlJb/LQGrBG8N9mDYgJJ\n\tR5Ew6XSo6UA7t9Vkk462k1NQGLdwuuADzWENyIGtXOmG9vBHQ8nLAuUcwOECmTyEIl\n\tkhHchgsvYR4xfU/YzO2lDDdOVP9ze4kPtS9cX8hI=","Date":"Wed, 7 Oct 2020 16:25:50 +0300","From":"Laurent Pinchart ","To":"Tomi Valkeinen ","Message-ID":"<20201007132550.GF3937@pendragon.ideasonboard.com>","References":"<20201007092239.41704-1-tomi.valkeinen@iki.fi>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201007092239.41704-1-tomi.valkeinen@iki.fi>","Subject":"Re: [libcamera-devel] [PATCH 1/4] cam: options: fix access to\n\tuninit variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13073,"web_url":"https://patchwork.libcamera.org/comment/13073/","msgid":"","date":"2020-10-07T13:36:53","subject":"Re: [libcamera-devel] [PATCH 1/4] cam: options: fix access to\n\tuninit variable","submitter":{"id":70,"url":"https://patchwork.libcamera.org/api/people/70/","name":"Tomi Valkeinen","email":"tomi.valkeinen@iki.fi"},"content":"On 07/10/2020 16:25, Laurent Pinchart wrote:\n> Hi Tomi,\n> \n> Thank you for the patch.\n> \n> On Wed, Oct 07, 2020 at 12:22:36PM +0300, Tomi Valkeinen wrote:\n>> operator[] doesn't check if the option exists in the values_ map, so it\n>> can return a pointer to location outside the map.\n> \n> Is this a problem that you've encountered in practice ?\n\nYes, cam does e.g.:\n\nroles = StreamKeyValueParser::roles(options_[OptStream]);\n\nIf OptStream is not set, roles() will get uninitialized data.\n\n> OptionsBase here is used as a map-like container, and our implementation\n> of operator[] doesn't match std::map as the latter will insert an\n> element if the key isn't found. I wonder if this could create confusion\n> as to what behaviour a user of OptionsBase::operator[] would expect.\n> \n>> Fix by returning an empty OptionValue if the option is not found.\n>>\n>> Signed-off-by: Tomi Valkeinen \n>> ---\n>> src/cam/options.cpp | 7 ++++++-\n>> 1 file changed, 6 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/src/cam/options.cpp b/src/cam/options.cpp\n>> index 77b3cc1..8fc1c42 100644\n>> --- a/src/cam/options.cpp\n>> +++ b/src/cam/options.cpp\n>> @@ -61,7 +61,12 @@ bool OptionsBase::isSet(const T &opt) const\n>> template\n>> const OptionValue &OptionsBase::operator[](const T &opt) const\n>> {\n>> -\treturn values_.find(opt)->second;\n>> +\tstatic const OptionValue s_empty;\n> \n> That should be sEmpty to match the coding style, but I'd just call it\n> empty as we don't prefix static variables with a prefix to mean they're\n> static (the same way we have no m_ prefix).\n\nOh, right. Yeah, I really don't like libcamera's style here, but I'll try to remember =)\n\n Tomi","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F430BEEDF\n\tfor ;\n\tWed, 7 Oct 2020 13:36:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 16C86605C3;\n\tWed, 7 Oct 2020 15:36:57 +0200 (CEST)","from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 499D3605BE\n\tfor ;\n\tWed, 7 Oct 2020 15:36:55 +0200 (CEST)","by mail-lf1-x144.google.com with SMTP id 184so2312612lfd.6\n\tfor ;\n\tWed, 07 Oct 2020 06:36:55 -0700 (PDT)","from [192.168.1.111] (91-152-83-50.elisa-laajakaista.fi.\n\t[91.152.83.50]) by smtp.gmail.com with ESMTPSA id\n\td18sm337907lfm.178.2020.10.07.06.36.53\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tWed, 07 Oct 2020 06:36:54 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"lsBWKME/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=g4Bs5EiLDy4g0rWYGRtnYKauRcNv8Ve3WHMUgHLISbA=;\n\tb=lsBWKME/LdZkorTAeIrn4wx2nzB3YPMffVSDE1KXP9Z8hCYz3NhD9+5CHwTJMcO5Gu\n\tW1DB6BHD0kcrTxrzrCbcbI1MBITYbc67cHO/FvDk29L3Go4ZvtTOQjgyhXT1l9ZHYdl1\n\tIZ/aW37ePrhzzM5cePKHQg4Aiz4G/IP6ik2Z68uMgouWgwk5pDtzSd0RHnrOAT8Ud0HB\n\tFar7h5+gYboeoT0FuUUZeOza8uWZCWgw+RNQWbvyTCHbK42pNNnlpCIy0EaobCHFB0k+\n\tgnaQNx8sLLzyA7YgalOoCHCcbqw1Vf4TsxKzn56UOA2UadyZHvVN2KE+qYAtYnRNusdO\n\terZA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=g4Bs5EiLDy4g0rWYGRtnYKauRcNv8Ve3WHMUgHLISbA=;\n\tb=oXe4UP88iLMaw5Mm4ZN0ixXYZzS9KY9bxBQOZLNUrFxY86r8BeJWHUIRDjpXZKlVnU\n\tldvvZgr3k/jzAn6tUlSp7zB9gubDyDFAq2HDSOA9n8GZnnovHsLVlhfH4k7CKVfjmUmW\n\t9uJPPuJ8yT/WTOMebHi2W2PIjTTFHPRzSifzaLWMzqtN5iz4XkxOgz1xWJ5EgJ6OZxNp\n\tytl0gKQHDIwp1Wo8tXrnk0wWVFcJA5HRfh9WGBis7qxqTHEwRBUNXDB92JDlxsuVjLmu\n\tDG7XJmUgaT70QlT4Zl7dQYXBjMNK+ADXLorAgxkc2X5/cK8wg6xhe10QngetlIR/NsDA\n\tclJg==","X-Gm-Message-State":"AOAM532ZnIsbdORnOlzi204CovNe4eSMQm3Ff1dn7dTEImnBEPWOKzJS\n\tvYbQSmETdpXckVNbsT1Q3Grm8abLqZsRfQ==","X-Google-Smtp-Source":"ABdhPJyecyBTrFGo9jw/YtQqIW5IR4bUeUIGrtlKLgIB/r6wvh5KKsm79RndHteZqQ/0yxWiwuhtDg==","X-Received":"by 2002:a19:8ac1:: with SMTP id\n\tm184mr883958lfd.199.1602077814560; \n\tWed, 07 Oct 2020 06:36:54 -0700 (PDT)","To":"Laurent Pinchart ","References":"<20201007092239.41704-1-tomi.valkeinen@iki.fi>\n\t<20201007132550.GF3937@pendragon.ideasonboard.com>","From":"Tomi Valkeinen ","Message-ID":"","Date":"Wed, 7 Oct 2020 16:36:53 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201007132550.GF3937@pendragon.ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 1/4] cam: options: fix access to\n\tuninit variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]