[{"id":1383,"web_url":"https://patchwork.libcamera.org/comment/1383/","msgid":"<20190416111618.GE4832@pendragon.ideasonboard.com>","date":"2019-04-16T11:16:18","subject":"Re: [libcamera-devel] [PATCH v5 4/7] libcamera: request: Add\n\tempty() method","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Apr 16, 2019 at 01:18:56AM +0200, Jacopo Mondi wrote:\n> Add method to verify if a request has pending buffers yet to be\n> completed or it is empty and ready from completion.\n> \n> Reviewed-by: Niklas Söderlund \n> Signed-off-by: Jacopo Mondi \n> ---\n> include/libcamera/request.h | 2 ++\n> src/libcamera/request.cpp | 11 +++++++++--\n> 2 files changed, 11 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n> index 0dbd425115e8..6f97aa177ae0 100644\n> --- a/include/libcamera/request.h\n> +++ b/include/libcamera/request.h\n> @@ -37,6 +37,8 @@ public:\n> \n> \tStatus status() const { return status_; }\n> \n> +\tbool empty() const { return pending_.empty(); }\n\nHow about hasPendingBuffers() ?\n\n> +\n> private:\n> \tfriend class Camera;\n> \tfriend class PipelineHandler;\n> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> index e0e77e972411..33055c5ac533 100644\n> --- a/src/libcamera/request.cpp\n> +++ b/src/libcamera/request.cpp\n> @@ -106,6 +106,13 @@ Buffer *Request::findBuffer(Stream *stream) const\n> * \\return The request completion status\n> */\n> \n> +/**\n> + * \\fn Request::empty()\n> + * \\brief Retrieve if a request has buffers yet to be completed\n> + *\n> + * \\return True if no buffer is pending for completion, false otherwise\n> + */\n> +\n> /**\n> * \\brief Prepare the resources for the completion handler\n> */\n> @@ -127,7 +134,7 @@ int Request::prepare()\n> */\n> void Request::complete(Status status)\n> {\n> -\tASSERT(pending_.empty());\n> +\tASSERT(empty());\n> \tstatus_ = status;\n> }\n> \n> @@ -149,7 +156,7 @@ bool Request::completeBuffer(Buffer *buffer)\n> \tint ret = pending_.erase(buffer);\n> \tASSERT(ret == 1);\n> \n> -\treturn pending_.empty();\n> +\treturn empty();\n> }\n> \n> } /* namespace libcamera */","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5A19F60DB4\n\tfor ;\n\tTue, 16 Apr 2019 13:16:27 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E9D03E2;\n\tTue, 16 Apr 2019 13:16:26 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1555413387;\n\tbh=uHB0EG14uF26M1/Fu4el+j2d6A71ep82PqiNgBDbn8w=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=o2mnkeUsK3mg6uiRVf1agwen4KKrFbkk7ryj8br8TKhZT5SMdL5kYY/ElpZjK9Z2h\n\tWom+IFfc2AbhsL+VfX1jrYz5ia4M7KAJlCXo6HDsjaFTBA7kr5iIaPRyQ1nlAZ30wf\n\tuSI8MCt9aHZh9nqBUzrkvVQHddhYEvwO753q6f1k=","Date":"Tue, 16 Apr 2019 14:16:18 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190416111618.GE4832@pendragon.ideasonboard.com>","References":"<20190415231859.9747-1-jacopo@jmondi.org>\n\t<20190415231859.9747-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190415231859.9747-5-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v5 4/7] libcamera: request: Add\n\tempty() method","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 16 Apr 2019 11:16:27 -0000"}}]