[{"id":12983,"web_url":"https://patchwork.libcamera.org/comment/12983/","msgid":"<20201005124449.GP3931@pendragon.ideasonboard.com>","date":"2020-10-05T12:44:49","subject":"Re: [libcamera-devel] [PATCH 15/15] android: camera_device: Clear\n\tstreams_ at stop time","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Mon, Oct 05, 2020 at 01:46:49PM +0300, Laurent Pinchart wrote:\n> From: Jacopo Mondi \n> \n> When the CameraDevice is stopped, we need to clear the vector\n> of CameraStream instances to make sure they get deleted and all the\n> resources they have acquired get released.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_device.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 1a9af2e34340..6bbdfcc4a28b 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -517,6 +517,8 @@ int CameraDevice::open(const hw_module_t *hardwareModule)\n> \n> void CameraDevice::close()\n> {\n> +\tstreams_.clear();\n> +\n> \tcamera_->stop();\n> \tcamera_->release();\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A14BBC3B5C\n\tfor ;\n\tMon, 5 Oct 2020 12:45:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6F1AA63BED;\n\tMon, 5 Oct 2020 14:45:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF93F63BE4\n\tfor ;\n\tMon, 5 Oct 2020 14:45:28 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7F5643B\n\tfor ;\n\tMon, 5 Oct 2020 14:45:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mHJFevSA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601901928;\n\tbh=RzrqmfZbgvQFKmKIfTQAPh+9+piiKN64qr4gX4Flsqg=;\n\th=Date:From:To:Subject:References:In-Reply-To:From;\n\tb=mHJFevSAspNz0bwNkEiyASLNWaWzFWRhFs086HcdmfsWUtsFFxowc3weJGvu9lge2\n\tMrNUXvWVcdELAjOTUFhq2hfahaMC2kylgIvsSjSyzpSSMoq0eVATHpjefHWBpid9bv\n\tkY8tpDU16XI5dTSCBM7UNBoP+vb1crLLpW/PJqYc=","Date":"Mon, 5 Oct 2020 15:44:49 +0300","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20201005124449.GP3931@pendragon.ideasonboard.com>","References":"<20201005104649.10812-1-laurent.pinchart@ideasonboard.com>\n\t<20201005104649.10812-16-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201005104649.10812-16-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 15/15] android: camera_device: Clear\n\tstreams_ at stop time","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]