[{"id":12981,"web_url":"https://patchwork.libcamera.org/comment/12981/","msgid":"<20201005123217.GN3931@pendragon.ideasonboard.com>","date":"2020-10-05T12:32:17","subject":"Re: [libcamera-devel] [PATCH 12/15] android: camera_stream: Add\n\tmethods to get/put buffers","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Mon, Oct 05, 2020 at 01:46:46PM +0300, Laurent Pinchart wrote:\n> From: Jacopo Mondi \n> \n> Add two methods to the CameraStream class to get and put FrameBuffer\n> pointers from the pool of allocated buffers.\n\nYou may want to explain in the commit message that you're actually\ncreating a pool of buffers, and what it is used for.\n\n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/camera_stream.cpp | 35 +++++++++++++++++++++++++++++++++--\n> src/android/camera_stream.h | 4 ++++\n> 2 files changed, 37 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\n> index dbde1e786300..c4b727eee63e 100644\n> --- a/src/android/camera_stream.cpp\n> +++ b/src/android/camera_stream.cpp\n> @@ -19,21 +19,24 @@ LOG_DECLARE_CATEGORY(HAL);\n> CameraStream::CameraStream(CameraDevice *cameraDev, Type type,\n> \t\t\t camera3_stream_t *androidStream, unsigned int index)\n> \t: cameraDevice_(cameraDev), type_(type), androidStream_(androidStream),\n> -\t index_(index), encoder_(nullptr), allocator_(nullptr)\n> +\t index_(index), encoder_(nullptr), allocator_(nullptr), mutex_(nullptr)\n> {\n> \tconfig_ = cameraDevice_->cameraConfiguration();\n> \n> \tif (type_ == Type::Internal || type_ == Type::Mapped)\n> \t\tencoder_ = new EncoderLibJpeg();\n> \n> -\tif (type == Type::Internal)\n> +\tif (type == Type::Internal) {\n> \t\tallocator_ = new FrameBufferAllocator(cameraDevice_->camera());\n> +\t\tmutex_ = new std::mutex();\n\nI'd embed this in the class.\n\n> +\t}\n> }\n> \n> CameraStream::~CameraStream()\n> {\n> \tdelete encoder_;\n> \tdelete allocator_;\n> +\tdelete mutex_;\n> }\n> \n> const StreamConfiguration &CameraStream::streamConfiguration() const\n> @@ -135,3 +138,31 @@ int CameraStream::process(libcamera::FrameBuffer *source, MappedCamera3Buffer *d\n> \n> \treturn 0;\n> }\n> +\n> +FrameBuffer *CameraStream::getBuffer()\n> +{\n> +\tif (!allocator_)\n> +\t\treturn nullptr;\n> +\n> +\tstd::lock_guard locker(*mutex_);\n> +\n> +\tif (buffers_.empty()) {\n> +\t\tLOG(HAL, Error) << \"Buffer underrun\";\n> +\t\treturn nullptr;\n> +\t}\n> +\n> +\tFrameBuffer *buffer = buffers_.back();\n> +\tbuffers_.pop_back();\n> +\n> +\treturn buffer;\n> +}\n> +\n> +void CameraStream::putBuffer(libcamera::FrameBuffer *buffer)\n> +{\n> +\tif (!allocator_)\n> +\t\treturn;\n> +\n> +\tstd::lock_guard locker(*mutex_);\n> +\n> +\tbuffers_.push_back(buffer);\n> +}\n> diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\n> index c6ff79230b7e..b79a97606c60 100644\n> --- a/src/android/camera_stream.h\n> +++ b/src/android/camera_stream.h\n> @@ -8,6 +8,7 @@\n> #define __ANDROID_CAMERA_STREAM_H__\n> \n> #include \n> +#include \n> #include \n> \n> #include \n> @@ -127,6 +128,8 @@ public:\n> \tint process(libcamera::FrameBuffer *source,\n> \t\t MappedCamera3Buffer *dest,\n> \t\t CameraMetadata *metadata);\n> +\tlibcamera::FrameBuffer *getBuffer();\n> +\tvoid putBuffer(libcamera::FrameBuffer *buffer);\n> \n> private:\n> \tCameraDevice *cameraDevice_;\n> @@ -143,6 +146,7 @@ private:\n> \tEncoder *encoder_;\n> \tlibcamera::FrameBufferAllocator *allocator_;\n> \tstd::vector buffers_;\n> +\tstd::mutex *mutex_;\n> };\n> \n> #endif /* __ANDROID_CAMERA_STREAM__ */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1491AC3B5D\n\tfor ;\n\tMon, 5 Oct 2020 12:32:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A84F363BE4;\n\tMon, 5 Oct 2020 14:32:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CA1AE63BD5\n\tfor ;\n\tMon, 5 Oct 2020 14:32:56 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5C9CE3B\n\tfor ;\n\tMon, 5 Oct 2020 14:32:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DdjfO6E2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601901176;\n\tbh=aUdz5RPCI+woiqFS9RFq2TdLYsuRHtvgOtbQi2Vn2ZU=;\n\th=Date:From:To:Subject:References:In-Reply-To:From;\n\tb=DdjfO6E27crF4lfe0pHjEuCauZZdn5ZKOIrYj2dZsIUSgzjBFdGJ2VniYSsKyxV7H\n\toVJeJICLPplHsabVNbxIL84eKfy5bQWdwbiVJJmoC2D2kfFXpa06SLFmnZqTo+BzNa\n\tYbN/u0omvTwaWC21XtLYHNcq0ttBBbxO+f3gQdvQ=","Date":"Mon, 5 Oct 2020 15:32:17 +0300","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20201005123217.GN3931@pendragon.ideasonboard.com>","References":"<20201005104649.10812-1-laurent.pinchart@ideasonboard.com>\n\t<20201005104649.10812-13-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201005104649.10812-13-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 12/15] android: camera_stream: Add\n\tmethods to get/put buffers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":13015,"web_url":"https://patchwork.libcamera.org/comment/13015/","msgid":"","date":"2020-10-06T12:45:46","subject":"Re: [libcamera-devel] [PATCH 12/15] android: camera_stream: Add\n\tmethods to get/put buffers","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 05/10/2020 13:32, Laurent Pinchart wrote:\n> Hi Jacopo,\n> \n> Thank you for the patch.\n> \n> On Mon, Oct 05, 2020 at 01:46:46PM +0300, Laurent Pinchart wrote:\n>> From: Jacopo Mondi \n>>\n>> Add two methods to the CameraStream class to get and put FrameBuffer\n>> pointers from the pool of allocated buffers.\n> \n> You may want to explain in the commit message that you're actually\n> creating a pool of buffers, and what it is used for.\n> \n>> Signed-off-by: Jacopo Mondi \n>> ---\n>> src/android/camera_stream.cpp | 35 +++++++++++++++++++++++++++++++++--\n>> src/android/camera_stream.h | 4 ++++\n>> 2 files changed, 37 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\n>> index dbde1e786300..c4b727eee63e 100644\n>> --- a/src/android/camera_stream.cpp\n>> +++ b/src/android/camera_stream.cpp\n>> @@ -19,21 +19,24 @@ LOG_DECLARE_CATEGORY(HAL);\n>> CameraStream::CameraStream(CameraDevice *cameraDev, Type type,\n>> \t\t\t camera3_stream_t *androidStream, unsigned int index)\n>> \t: cameraDevice_(cameraDev), type_(type), androidStream_(androidStream),\n>> -\t index_(index), encoder_(nullptr), allocator_(nullptr)\n>> +\t index_(index), encoder_(nullptr), allocator_(nullptr), mutex_(nullptr)\n>> {\n>> \tconfig_ = cameraDevice_->cameraConfiguration();\n>> \n>> \tif (type_ == Type::Internal || type_ == Type::Mapped)\n>> \t\tencoder_ = new EncoderLibJpeg();\n>> \n>> -\tif (type == Type::Internal)\n>> +\tif (type == Type::Internal) {\n>> \t\tallocator_ = new FrameBufferAllocator(cameraDevice_->camera());\n>> +\t\tmutex_ = new std::mutex();\n> \n> I'd embed this in the class.\n\nAgreed.\n\nOr - as it only protects the BufferPool - we could bring back a class\nBufferPool(), and have it in there with the allocate/get/put interface ...\n\n\n\nI digress - A full BufferPool object/interface isn't needed right now ;-)\n\nAnyway, with the mutex as part of the class instead of allocated.\n\nReviewed-by: Kieran Bingham \n\n\n> \n>> +\t}\n>> }\n>> \n>> CameraStream::~CameraStream()\n>> {\n>> \tdelete encoder_;\n>> \tdelete allocator_;\n>> +\tdelete mutex_;\n>> }\n>> \n>> const StreamConfiguration &CameraStream::streamConfiguration() const\n>> @@ -135,3 +138,31 @@ int CameraStream::process(libcamera::FrameBuffer *source, MappedCamera3Buffer *d\n>> \n>> \treturn 0;\n>> }\n>> +\n>> +FrameBuffer *CameraStream::getBuffer()\n>> +{\n>> +\tif (!allocator_)\n>> +\t\treturn nullptr;\n>> +\n>> +\tstd::lock_guard locker(*mutex_);\n>> +\n>> +\tif (buffers_.empty()) {\n>> +\t\tLOG(HAL, Error) << \"Buffer underrun\";\n>> +\t\treturn nullptr;\n>> +\t}\n>> +\n>> +\tFrameBuffer *buffer = buffers_.back();\n>> +\tbuffers_.pop_back();\n>> +\n>> +\treturn buffer;\n>> +}\n>> +\n>> +void CameraStream::putBuffer(libcamera::FrameBuffer *buffer)\n>> +{\n>> +\tif (!allocator_)\n>> +\t\treturn;\n>> +\n>> +\tstd::lock_guard locker(*mutex_);\n>> +\n>> +\tbuffers_.push_back(buffer);\n>> +}\n>> diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\n>> index c6ff79230b7e..b79a97606c60 100644\n>> --- a/src/android/camera_stream.h\n>> +++ b/src/android/camera_stream.h\n>> @@ -8,6 +8,7 @@\n>> #define __ANDROID_CAMERA_STREAM_H__\n>> \n>> #include \n>> +#include \n>> #include \n>> \n>> #include \n>> @@ -127,6 +128,8 @@ public:\n>> \tint process(libcamera::FrameBuffer *source,\n>> \t\t MappedCamera3Buffer *dest,\n>> \t\t CameraMetadata *metadata);\n>> +\tlibcamera::FrameBuffer *getBuffer();\n>> +\tvoid putBuffer(libcamera::FrameBuffer *buffer);\n>> \n>> private:\n>> \tCameraDevice *cameraDevice_;\n>> @@ -143,6 +146,7 @@ private:\n>> \tEncoder *encoder_;\n>> \tlibcamera::FrameBufferAllocator *allocator_;\n>> \tstd::vector buffers_;\n>> +\tstd::mutex *mutex_;\n>> };\n>> \n>> #endif /* __ANDROID_CAMERA_STREAM__ */\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 06C21BEEDF\n\tfor ;\n\tTue, 6 Oct 2020 12:45:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 884CB63C13;\n\tTue, 6 Oct 2020 14:45:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C829460363\n\tfor ;\n\tTue, 6 Oct 2020 14:45:49 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 409513B;\n\tTue, 6 Oct 2020 14:45:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aZfzY3Ep\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601988349;\n\tbh=mfJ7tUjBDaxDBYoB6bHqSWBibaONgyZgPXhWUImxCQ0=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=aZfzY3Ep39gzoC9NDJSfGwXTvVAKZi36CbytqpCUL5bBSGS44by9yj9dar7/LF2Sz\n\tP8362J+1X8InixPq9G08okw1iL6iz7lU+d7FpRSSCmcT9HGYJ9p8p+pVEhTlTMRQ5v\n\t58uvxGVmtZSFAaxozcz9YQSjdKXLc4KLbqCqcnTI=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20201005104649.10812-1-laurent.pinchart@ideasonboard.com>\n\t<20201005104649.10812-13-laurent.pinchart@ideasonboard.com>\n\t<20201005123217.GN3931@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Tue, 6 Oct 2020 13:45:46 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201005123217.GN3931@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 12/15] android: camera_stream: Add\n\tmethods to get/put buffers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]