[{"id":12975,"web_url":"https://patchwork.libcamera.org/comment/12975/","msgid":"<20201005121001.GH3931@pendragon.ideasonboard.com>","date":"2020-10-05T12:10:01","subject":"Re: [libcamera-devel] [PATCH 06/15] android: camera_stream:\n\tRetrieve Stream and Configuration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Mon, Oct 05, 2020 at 01:46:40PM +0300, Laurent Pinchart wrote:\n> From: Jacopo Mondi \n> \n> It's a common pattern to access the libcamera::Stream and\n> libcamera::StreamConfiguration using the CameraStream instance's\n> index.\n> \n> Add two methods to the CameraStream to shorten access to the\n> two fields. This allows removing the index() method from the class\n> interface.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/camera_device.cpp | 11 +++--------\n> src/android/camera_stream.cpp | 10 ++++++++++\n> src/android/camera_stream.h | 4 +++-\n> 3 files changed, 16 insertions(+), 9 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index c44904300e0a..4f8f3e5790ca 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1292,7 +1292,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> \tfor (unsigned int i = 0; i < stream_list->num_streams; ++i) {\n> \t\tcamera3_stream_t *stream = stream_list->streams[i];\n> \t\tCameraStream *cameraStream = static_cast(stream->priv);\n> -\t\tStreamConfiguration &cfg = config_->at(cameraStream->index());\n> +\t\tconst StreamConfiguration &cfg = cameraStream->streamConfiguration();\n> \n> \t\tint ret = cameraStream->configure(cfg);\n> \t\tif (ret)\n> @@ -1413,10 +1413,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n> \t\t}\n> \t\tdescriptor->frameBuffers.emplace_back(buffer);\n> \n> -\t\tStreamConfiguration *streamConfiguration = &config_->at(cameraStream->index());\n> -\t\tStream *stream = streamConfiguration->stream();\n> -\n> -\t\trequest->addBuffer(stream, buffer);\n> +\t\trequest->addBuffer(cameraStream->stream(), buffer);\n> \t}\n> \n> \tint ret = camera_->queueRequest(request);\n> @@ -1462,9 +1459,7 @@ void CameraDevice::requestComplete(Request *request)\n> \t\tif (cameraStream->outputFormat() != HAL_PIXEL_FORMAT_BLOB)\n> \t\t\tcontinue;\n> \n> -\t\tStreamConfiguration *streamConfiguration = &config_->at(cameraStream->index());\n> -\t\tStream *stream = streamConfiguration->stream();\n> -\t\tFrameBuffer *buffer = request->findBuffer(stream);\n> +\t\tFrameBuffer *buffer = request->findBuffer(cameraStream->stream());\n> \t\tif (!buffer) {\n> \t\t\tLOG(HAL, Error) << \"Failed to find a source stream buffer\";\n> \t\t\tcontinue;\n> diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\n> index 072edc9457bb..250f0ab0a3b4 100644\n> --- a/src/android/camera_stream.cpp\n> +++ b/src/android/camera_stream.cpp\n> @@ -32,6 +32,16 @@ CameraStream::CameraStream(CameraDevice *cameraDev,\n> \t\tencoder_.reset(new EncoderLibJpeg);\n> }\n> \n> +const StreamConfiguration &CameraStream::streamConfiguration() const\n> +{\n> +\treturn config_->at(index_);\n> +}\n> +\n> +Stream *CameraStream::stream() const\n> +{\n> +\treturn streamConfiguration().stream();\n> +}\n> +\n> int CameraStream::configure(const libcamera::StreamConfiguration &cfg)\n> {\n> \tif (encoder_)\n> diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\n> index dbcd1e53219f..fa295a69404f 100644\n> --- a/src/android/camera_stream.h\n> +++ b/src/android/camera_stream.h\n> @@ -116,7 +116,9 @@ public:\n> \tconst libcamera::PixelFormat &format() const { return format_; }\n> \tconst libcamera::Size &size() const { return size_; }\n> \tType type() const { return type_; }\n> -\tunsigned int index() const { return index_; }\n> +\n> +\tconst libcamera::StreamConfiguration &streamConfiguration() const;\n\nMaybe s/streamConfiguration/configuration/ ?\n\nReviewed-by: Laurent Pinchart \n\n> +\tlibcamera::Stream *stream() const;\n> \n> \tint configure(const libcamera::StreamConfiguration &cfg);\n> \tint process(libcamera::FrameBuffer *source,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D35C3C3B5C\n\tfor ;\n\tMon, 5 Oct 2020 12:10:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9C0CE63BD5;\n\tMon, 5 Oct 2020 14:10:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4292663BD5\n\tfor ;\n\tMon, 5 Oct 2020 14:10:40 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CC92D3B\n\tfor ;\n\tMon, 5 Oct 2020 14:10:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"R9bMLt7C\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601899840;\n\tbh=3jTueKm6LhTOHLAOm8IsO76dQKe1km2mSEO62YQd1Z4=;\n\th=Date:From:To:Subject:References:In-Reply-To:From;\n\tb=R9bMLt7C6fcKhdDJA6SOZtC7ZvaIViljTeSK8kTqBRDgavUiRi5xEqGnn7uQvvKfM\n\t1gwE9Jku2pDWh4glpBk25meJke7yTS3TgQNTZe/QbN7/FYweQnnag9kFyfb2TrjAtA\n\tzxob5vLxJ3DsMF0O5VSGCfOYBD2YDbsHLGtgMJB0=","Date":"Mon, 5 Oct 2020 15:10:01 +0300","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20201005121001.GH3931@pendragon.ideasonboard.com>","References":"<20201005104649.10812-1-laurent.pinchart@ideasonboard.com>\n\t<20201005104649.10812-7-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201005104649.10812-7-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 06/15] android: camera_stream:\n\tRetrieve Stream and Configuration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12998,"web_url":"https://patchwork.libcamera.org/comment/12998/","msgid":"<145a7e09-12ee-54ab-789b-56d477755b48@ideasonboard.com>","date":"2020-10-05T21:46:28","subject":"Re: [libcamera-devel] [PATCH 06/15] android: camera_stream:\n\tRetrieve Stream and Configuration","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo\n\nOn 05/10/2020 13:10, Laurent Pinchart wrote:\n> Hi Jacopo,\n> \n> Thank you for the patch.\n> \n> On Mon, Oct 05, 2020 at 01:46:40PM +0300, Laurent Pinchart wrote:\n>> From: Jacopo Mondi \n>>\n>> It's a common pattern to access the libcamera::Stream and\n>> libcamera::StreamConfiguration using the CameraStream instance's\n>> index.\n>>\n>> Add two methods to the CameraStream to shorten access to the\n>> two fields. This allows removing the index() method from the class\n>> interface.\n\nSounds like a win here too ;-)\n\n>>\n>> Signed-off-by: Jacopo Mondi \n>> ---\n>> src/android/camera_device.cpp | 11 +++--------\n>> src/android/camera_stream.cpp | 10 ++++++++++\n>> src/android/camera_stream.h | 4 +++-\n>> 3 files changed, 16 insertions(+), 9 deletions(-)\n>>\n>> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n>> index c44904300e0a..4f8f3e5790ca 100644\n>> --- a/src/android/camera_device.cpp\n>> +++ b/src/android/camera_device.cpp\n>> @@ -1292,7 +1292,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n>> \tfor (unsigned int i = 0; i < stream_list->num_streams; ++i) {\n>> \t\tcamera3_stream_t *stream = stream_list->streams[i];\n>> \t\tCameraStream *cameraStream = static_cast(stream->priv);\n>> -\t\tStreamConfiguration &cfg = config_->at(cameraStream->index());\n>> +\t\tconst StreamConfiguration &cfg = cameraStream->streamConfiguration();\n>> \n>> \t\tint ret = cameraStream->configure(cfg);\n>> \t\tif (ret)\n>> @@ -1413,10 +1413,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n>> \t\t}\n>> \t\tdescriptor->frameBuffers.emplace_back(buffer);\n>> \n>> -\t\tStreamConfiguration *streamConfiguration = &config_->at(cameraStream->index());\n>> -\t\tStream *stream = streamConfiguration->stream();\n>> -\n>> -\t\trequest->addBuffer(stream, buffer);\n>> +\t\trequest->addBuffer(cameraStream->stream(), buffer);\n>> \t}\n>> \n>> \tint ret = camera_->queueRequest(request);\n>> @@ -1462,9 +1459,7 @@ void CameraDevice::requestComplete(Request *request)\n>> \t\tif (cameraStream->outputFormat() != HAL_PIXEL_FORMAT_BLOB)\n>> \t\t\tcontinue;\n>> \n>> -\t\tStreamConfiguration *streamConfiguration = &config_->at(cameraStream->index());\n>> -\t\tStream *stream = streamConfiguration->stream();\n>> -\t\tFrameBuffer *buffer = request->findBuffer(stream);\n>> +\t\tFrameBuffer *buffer = request->findBuffer(cameraStream->stream());\n>> \t\tif (!buffer) {\n>> \t\t\tLOG(HAL, Error) << \"Failed to find a source stream buffer\";\n>> \t\t\tcontinue;\n>> diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\n>> index 072edc9457bb..250f0ab0a3b4 100644\n>> --- a/src/android/camera_stream.cpp\n>> +++ b/src/android/camera_stream.cpp\n>> @@ -32,6 +32,16 @@ CameraStream::CameraStream(CameraDevice *cameraDev,\n>> \t\tencoder_.reset(new EncoderLibJpeg);\n>> }\n>> \n>> +const StreamConfiguration &CameraStream::streamConfiguration() const\n>> +{\n>> +\treturn config_->at(index_);\n>> +}\n>> +\n>> +Stream *CameraStream::stream() const\n>> +{\n>> +\treturn streamConfiguration().stream();\n>> +}\n>> +\n>> int CameraStream::configure(const libcamera::StreamConfiguration &cfg)\n>> {\n>> \tif (encoder_)\n>> diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\n>> index dbcd1e53219f..fa295a69404f 100644\n>> --- a/src/android/camera_stream.h\n>> +++ b/src/android/camera_stream.h\n>> @@ -116,7 +116,9 @@ public:\n>> \tconst libcamera::PixelFormat &format() const { return format_; }\n>> \tconst libcamera::Size &size() const { return size_; }\n>> \tType type() const { return type_; }\n>> -\tunsigned int index() const { return index_; }\n>> +\n>> +\tconst libcamera::StreamConfiguration &streamConfiguration() const;\n> \n> Maybe s/streamConfiguration/configuration/ ?\n> \n> Reviewed-by: Laurent Pinchart \n\nLikewise.\n\nReviewed-by: Kieran Bingham \n\n> \n>> +\tlibcamera::Stream *stream() const;\n>> \n>> \tint configure(const libcamera::StreamConfiguration &cfg);\n>> \tint process(libcamera::FrameBuffer *source,\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7672DC3B5C\n\tfor ;\n\tMon, 5 Oct 2020 21:46:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC86063C13;\n\tMon, 5 Oct 2020 23:46:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D6DA263BE4\n\tfor ;\n\tMon, 5 Oct 2020 23:46:31 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 458703B;\n\tMon, 5 Oct 2020 23:46:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gIwWRP5k\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601934391;\n\tbh=CTmAT3P+v2S2p64h7Iaa8oLe4C86CleTExQ/5EsnFvY=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=gIwWRP5kjpxR22+k5ldTIxAoeaWMHdujlGS11CpclITmV5icCtAU8QLpdTGLnMcj3\n\t5R8FmBP6tMacy3T+0UkIN6SJksyAhFSD2MObkfrmgx9qM6oPwKZ2Bv86iviEUFfwZe\n\tX1LfxEp9+URLCTz0S3f822yhkcw1lJdxc81tFmkY=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20201005104649.10812-1-laurent.pinchart@ideasonboard.com>\n\t<20201005104649.10812-7-laurent.pinchart@ideasonboard.com>\n\t<20201005121001.GH3931@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<145a7e09-12ee-54ab-789b-56d477755b48@ideasonboard.com>","Date":"Mon, 5 Oct 2020 22:46:28 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201005121001.GH3931@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 06/15] android: camera_stream:\n\tRetrieve Stream and Configuration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]