[{"id":12972,"web_url":"https://patchwork.libcamera.org/comment/12972/","msgid":"<20201005112157.GE3931@pendragon.ideasonboard.com>","date":"2020-10-05T11:21:57","subject":"Re: [libcamera-devel] [PATCH 02/15] android: camera_stream: Add\n\tCameraStream::Type","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Mon, Oct 05, 2020 at 01:46:36PM +0300, Laurent Pinchart wrote:\n> From: Jacopo Mondi \n> \n> Define the CameraStream::Type enumeration and assign it to\n> each CameraStream instance at construction time.\n> \n> The CameraStream type will be used to decide if memory needs to be\n> allocated on its behalf or if the stream is backed by memory externally\n> allocated by the Android framework.\n> \n> Reviewed-by: Laurent Pinchart \n> Reviewed-by: Kieran Bingham \n> Reviewed-by: Hirokazu Honda \n> Reviewed-by: Niklas Söderlund \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/camera_device.cpp | 8 +++-\n> src/android/camera_stream.cpp | 4 +-\n> src/android/camera_stream.h | 86 ++++++++++++++++++++++++++++++++++-\n> 3 files changed, 93 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index bbc692fe109f..0600ebc81c64 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1216,12 +1216,14 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> \n> \t\tconfig_->addConfiguration(streamConfiguration);\n> \t\tunsigned int index = config_->size() - 1;\n> -\t\tstreams_.emplace_back(format, size, index);\n> +\t\tstreams_.emplace_back(format, size, CameraStream::Type::Direct,\n> +\t\t\t\t index);\n> \t\tstream->priv = static_cast(&streams_.back());\n> \t}\n> \n> \t/* Now handle the MJPEG streams, adding a new stream if required. */\n> \tif (jpegStream) {\n> +\t\tCameraStream::Type type;\n> \t\tint index = -1;\n> \n> \t\t/* Search for a compatible stream in the non-JPEG ones. */\n> @@ -1239,6 +1241,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> \t\t\tLOG(HAL, Info)\n> \t\t\t\t<< \"Android JPEG stream mapped to libcamera stream \" << i;\n> \n> +\t\t\ttype = CameraStream::Type::Mapped;\n> \t\t\tindex = i;\n> \t\t\tbreak;\n> \t\t}\n> @@ -1263,6 +1266,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> \t\t\tLOG(HAL, Info) << \"Adding \" << streamConfiguration.toString()\n> \t\t\t\t << \" for MJPEG support\";\n> \n> +\t\t\ttype = CameraStream::Type::Internal;\n> \t\t\tconfig_->addConfiguration(streamConfiguration);\n> \t\t\tindex = config_->size() - 1;\n> \t\t}\n> @@ -1281,7 +1285,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> \t\t\treturn ret;\n> \t\t}\n> \n> -\t\tstreams_.emplace_back(formats::MJPEG, cfg.size, index, encoder);\n> +\t\tstreams_.emplace_back(formats::MJPEG, cfg.size, type, index, encoder);\n> \t\tjpegStream->priv = static_cast(&streams_.back());\n> \t}\n> \n> diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\n> index 01c62978ca3a..585bf2b68f4f 100644\n> --- a/src/android/camera_stream.cpp\n> +++ b/src/android/camera_stream.cpp\n> @@ -10,7 +10,7 @@\n> using namespace libcamera;\n> \n> CameraStream::CameraStream(PixelFormat format, Size size,\n> -\t\t\t unsigned int index, Encoder *encoder)\n> -\t: format_(format), size_(size), index_(index), encoder_(encoder)\n> +\t\t\t Type type, unsigned int index, Encoder *encoder)\n> +\t: format_(format), size_(size), type_(type), index_(index), encoder_(encoder)\n> {\n> }\n> diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\n> index 10dece7beb69..07c714e3a365 100644\n> --- a/src/android/camera_stream.h\n> +++ b/src/android/camera_stream.h\n> @@ -17,17 +17,101 @@\n> class CameraStream\n> {\n> public:\n> +\t/*\n> +\t * Enumeration of CameraStream types.\n> +\t *\n> +\t * A camera stream associates an Android stream to a libcamera stream.\n> +\t * This enumeration describes how the two streams are associated and how\n> +\t * and where data produced from libcamera are delivered to the\n> +\t * Android framework.\n> +\t *\n> +\t * Direct:\n> +\t *\n> +\t * The Android stream is directly mapped onto a libcamera stream: frames\n> +\t * are delivered by the library directly in the memory location\n> +\t * specified by the Android stream (buffer_handle_t->data) and provided\n> +\t * to the framework as they are. The Android stream characteristics are\n> +\t * directly translated to the libcamera stream configuration.\n> +\t *\n> +\t * +-----+ +-----+\n> +\t * | A | | L |\n> +\t * +-----+ +-----+\n> +\t * | |\n> +\t * V V\n> +\t * +-----+ +------+\n> +\t * | B |<---------------| FB |\n> +\t * +-----+ +------+\n> +\t *\n> +\t *\n> +\t * Internal:\n> +\t *\n> +\t * Data for the Android stream is produced by processing a libcamera\n> +\t * stream created by the HAL for that purpose. The libcamera stream\n> +\t * needs to be supplied with intermediate buffers where the library\n> +\t * delivers frames to be processed and then provided to the framework.\n> +\t * The libcamera stream configuration is not a direct translation of the\n> +\t * Android stream characteristics, but it describes the format and size\n> +\t * required for the processing procedure to produce frames in the\n> +\t * Android required format.\n> +\t *\n> +\t * +-----+ +-----+\n> +\t * | A | | L |\n> +\t * +-----+ +-----+\n> +\t * | |\n> +\t * V V\n> +\t * +-----+ +------+\n> +\t * | B | | FB |\n> +\t * +-----+ +------+\n> +\t * ^ |\n> +\t * |-------Processing------|\n> +\t *\n> +\t *\n> +\t * Mapped:\n> +\t *\n> +\t * Data for the Android stream is produced by processing a libcamera\n> +\t * stream associated with another CameraStream. Mapped camera streams do\n> +\t * not need any memory to be reserved for them as they process data\n> +\t * produced by libcamera for a different stream whose format and size\n> +\t * is compatible with the processing procedure requirements to produce\n\ns/is/are/\n\nReviewed-by: Laurent Pinchart \n\n> +\t * frames in the Android required format.\n> +\t *\n> +\t * +-----+ +-----+ +-----+\n> +\t * | A | | A' | | L |\n> +\t * +-----+ +-----+ +-----+\n> +\t * | | |\n> +\t * V V V\n> +\t * +-----+ +-----+ +------+\n> +\t * | B | | B' |<---------| FB |\n> +\t * +-----+ +-----+ +------+\n> +\t * ^ |\n> +\t * |--Processing--|\n> +\t *\n> +\t *\n> +\t * --------------------------------------------------------------------\n> +\t * A = Android stream\n> +\t * L = libcamera stream\n> +\t * B = memory buffer\n> +\t * FB = libcamera FrameBuffer\n> +\t * \"Processing\" = Frame processing procedure (Encoding, scaling etc)\n> +\t */\n> +\tenum class Type {\n> +\t\tDirect,\n> +\t\tInternal,\n> +\t\tMapped,\n> +\t};\n> \tCameraStream(libcamera::PixelFormat format, libcamera::Size size,\n> -\t\t unsigned int index, Encoder *encoder = nullptr);\n> +\t\t Type type, unsigned int index, Encoder *encoder = nullptr);\n> \n> \tconst libcamera::PixelFormat &format() const { return format_; }\n> \tconst libcamera::Size &size() const { return size_; }\n> +\tType type() const { return type_; }\n> \tunsigned int index() const { return index_; }\n> \tEncoder *encoder() const { return encoder_.get(); }\n> \n> private:\n> \tlibcamera::PixelFormat format_;\n> \tlibcamera::Size size_;\n> +\tType type_;\n> \t/*\n> \t * The index of the libcamera StreamConfiguration as added during\n> \t * configureStreams(). A single libcamera Stream may be used to deliver","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E272C3B5C\n\tfor ;\n\tMon, 5 Oct 2020 11:22:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D668963BD5;\n\tMon, 5 Oct 2020 13:22:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9076363BBF\n\tfor ;\n\tMon, 5 Oct 2020 13:22:36 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 02F6F3B\n\tfor ;\n\tMon, 5 Oct 2020 13:22:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"C0bx7bEu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601896956;\n\tbh=YrGuakfFJrSsPGXWr7+x/3Q9dpRzTnc9COmrRzD5FII=;\n\th=Date:From:To:Subject:References:In-Reply-To:From;\n\tb=C0bx7bEuWJ78KvmjOjDpbixYC587KHIgFa6pLJxbjZpVAWZh0UURnaFSx8/lNN9yE\n\t4iDHAX2tnnEePp6a//I1B1Nu3xfMDSq0OMDOGdkt854B/XMtnAq+UqJBIZ3FB9hLHJ\n\tTU9ZcKTwgJrg53YbT+B7sG5k8conww7464FzDFWM=","Date":"Mon, 5 Oct 2020 14:21:57 +0300","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20201005112157.GE3931@pendragon.ideasonboard.com>","References":"<20201005104649.10812-1-laurent.pinchart@ideasonboard.com>\n\t<20201005104649.10812-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201005104649.10812-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 02/15] android: camera_stream: Add\n\tCameraStream::Type","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12986,"web_url":"https://patchwork.libcamera.org/comment/12986/","msgid":"","date":"2020-10-05T15:50:55","subject":"Re: [libcamera-devel] [PATCH 02/15] android: camera_stream: Add\n\tCameraStream::Type","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 05/10/2020 12:21, Laurent Pinchart wrote:\n> Hi Jacopo,\n> \n> Thank you for the patch.\n> \n> On Mon, Oct 05, 2020 at 01:46:36PM +0300, Laurent Pinchart wrote:\n>> From: Jacopo Mondi \n>>\n>> Define the CameraStream::Type enumeration and assign it to\n>> each CameraStream instance at construction time.\n>>\n>> The CameraStream type will be used to decide if memory needs to be\n>> allocated on its behalf or if the stream is backed by memory externally\n>> allocated by the Android framework.\n>>\n>> Reviewed-by: Laurent Pinchart \n>> Reviewed-by: Kieran Bingham \n>> Reviewed-by: Hirokazu Honda \n>> Reviewed-by: Niklas Söderlund \n>> Signed-off-by: Jacopo Mondi \n>> ---\n>> src/android/camera_device.cpp | 8 +++-\n>> src/android/camera_stream.cpp | 4 +-\n>> src/android/camera_stream.h | 86 ++++++++++++++++++++++++++++++++++-\n>> 3 files changed, 93 insertions(+), 5 deletions(-)\n>>\n>> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n>> index bbc692fe109f..0600ebc81c64 100644\n>> --- a/src/android/camera_device.cpp\n>> +++ b/src/android/camera_device.cpp\n>> @@ -1216,12 +1216,14 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n>> \n>> \t\tconfig_->addConfiguration(streamConfiguration);\n>> \t\tunsigned int index = config_->size() - 1;\n>> -\t\tstreams_.emplace_back(format, size, index);\n>> +\t\tstreams_.emplace_back(format, size, CameraStream::Type::Direct,\n>> +\t\t\t\t index);\n>> \t\tstream->priv = static_cast(&streams_.back());\n>> \t}\n>> \n>> \t/* Now handle the MJPEG streams, adding a new stream if required. */\n>> \tif (jpegStream) {\n>> +\t\tCameraStream::Type type;\n>> \t\tint index = -1;\n>> \n>> \t\t/* Search for a compatible stream in the non-JPEG ones. */\n>> @@ -1239,6 +1241,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n>> \t\t\tLOG(HAL, Info)\n>> \t\t\t\t<< \"Android JPEG stream mapped to libcamera stream \" << i;\n>> \n>> +\t\t\ttype = CameraStream::Type::Mapped;\n>> \t\t\tindex = i;\n>> \t\t\tbreak;\n>> \t\t}\n>> @@ -1263,6 +1266,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n>> \t\t\tLOG(HAL, Info) << \"Adding \" << streamConfiguration.toString()\n>> \t\t\t\t << \" for MJPEG support\";\n>> \n>> +\t\t\ttype = CameraStream::Type::Internal;\n>> \t\t\tconfig_->addConfiguration(streamConfiguration);\n>> \t\t\tindex = config_->size() - 1;\n>> \t\t}\n>> @@ -1281,7 +1285,7 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n>> \t\t\treturn ret;\n>> \t\t}\n>> \n>> -\t\tstreams_.emplace_back(formats::MJPEG, cfg.size, index, encoder);\n>> +\t\tstreams_.emplace_back(formats::MJPEG, cfg.size, type, index, encoder);\n>> \t\tjpegStream->priv = static_cast(&streams_.back());\n>> \t}\n>> \n>> diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\n>> index 01c62978ca3a..585bf2b68f4f 100644\n>> --- a/src/android/camera_stream.cpp\n>> +++ b/src/android/camera_stream.cpp\n>> @@ -10,7 +10,7 @@\n>> using namespace libcamera;\n>> \n>> CameraStream::CameraStream(PixelFormat format, Size size,\n>> -\t\t\t unsigned int index, Encoder *encoder)\n>> -\t: format_(format), size_(size), index_(index), encoder_(encoder)\n>> +\t\t\t Type type, unsigned int index, Encoder *encoder)\n>> +\t: format_(format), size_(size), type_(type), index_(index), encoder_(encoder)\n>> {\n>> }\n>> diff --git a/src/android/camera_stream.h b/src/android/camera_stream.h\n>> index 10dece7beb69..07c714e3a365 100644\n>> --- a/src/android/camera_stream.h\n>> +++ b/src/android/camera_stream.h\n>> @@ -17,17 +17,101 @@\n>> class CameraStream\n>> {\n>> public:\n>> +\t/*\n>> +\t * Enumeration of CameraStream types.\n>> +\t *\n>> +\t * A camera stream associates an Android stream to a libcamera stream.\n>> +\t * This enumeration describes how the two streams are associated and how\n>> +\t * and where data produced from libcamera are delivered to the\n\ns/are/is/\n\n>> +\t * Android framework.\n>> +\t *\n>> +\t * Direct:\n>> +\t *\n>> +\t * The Android stream is directly mapped onto a libcamera stream: frames\n\ns/: f/. F/ ?\n\nOr maybe it was supposed to be s/:/;/ ?\n\n>> +\t * are delivered by the library directly in the memory location\n>> +\t * specified by the Android stream (buffer_handle_t->data) and provided\n>> +\t * to the framework as they are. The Android stream characteristics are\n>> +\t * directly translated to the libcamera stream configuration.\n>> +\t *\n>> +\t * +-----+ +-----+\n>> +\t * | A | | L |\n>> +\t * +-----+ +-----+\n>> +\t * | |\n>> +\t * V V\n>> +\t * +-----+ +------+\n>> +\t * | B |<---------------| FB |\n>> +\t * +-----+ +------+\n>> +\t *\n\nMaybe we should expand the initials/acronyms somewhere?\n\nA: Android\nB: Android Buffer\nL: libcamera\nFB: libcamera FrameBuffer ?\n\n(Assuming my assumptions are correct :-D )\n\nIn fact, reading down - FB is actually an FB wrapping B.\n\nMaybe we could express that 'wrapping' in ascii art - but I expect it\nmight be painful too - so don't worry about it.\n\n\n>> +\t *\n>> +\t * Internal:\n>> +\t *\n>> +\t * Data for the Android stream is produced by processing a libcamera\n>> +\t * stream created by the HAL for that purpose. The libcamera stream\n>> +\t * needs to be supplied with intermediate buffers where the library\n>> +\t * delivers frames to be processed and then provided to the framework.\n>> +\t * The libcamera stream configuration is not a direct translation of the\n>> +\t * Android stream characteristics, but it describes the format and size\n>> +\t * required for the processing procedure to produce frames in the\n>> +\t * Android required format.\n>> +\t *\n>> +\t * +-----+ +-----+\n>> +\t * | A | | L |\n>> +\t * +-----+ +-----+\n>> +\t * | |\n>> +\t * V V\n>> +\t * +-----+ +------+\n>> +\t * | B | | FB |\n>> +\t * +-----+ +------+\n>> +\t * ^ |\n>> +\t * |-------Processing------|\n>> +\t *\n>> +\t *\n>> +\t * Mapped:\n>> +\t *\n>> +\t * Data for the Android stream is produced by processing a libcamera\n>> +\t * stream associated with another CameraStream. Mapped camera streams do\n>> +\t * not need any memory to be reserved for them as they process data\n>> +\t * produced by libcamera for a different stream whose format and size\n>> +\t * is compatible with the processing procedure requirements to produce\n> \n> s/is/are/\n> \n> Reviewed-by: Laurent Pinchart \n> \n>> +\t * frames in the Android required format.\n>> +\t *\n>> +\t * +-----+ +-----+ +-----+\n>> +\t * | A | | A' | | L |\n>> +\t * +-----+ +-----+ +-----+\n>> +\t * | | |\n>> +\t * V V V\n>> +\t * +-----+ +-----+ +------+\n>> +\t * | B | | B' |<---------| FB |\n>> +\t * +-----+ +-----+ +------+\n>> +\t * ^ |\n>> +\t * |--Processing--|\n>> +\t *\n>> +\t *\n>> +\t * --------------------------------------------------------------------\n>> +\t * A = Android stream\n>> +\t * L = libcamera stream\n>> +\t * B = memory buffer\n>> +\t * FB = libcamera FrameBuffer\n>> +\t * \"Processing\" = Frame processing procedure (Encoding, scaling etc)\n>> +\t */\n\nAha - here it is.\n\nI wonder if this should be first so we see the definitions before\nthey're used.\n\nBut it's not far to follow down, so it's kind of footnotes - so I don't\nobject to keeping this here.\n\nYou've already got my tag - and you can keep it of course ;-)\n\n\n>> +\tenum class Type {\n>> +\t\tDirect,\n>> +\t\tInternal,\n>> +\t\tMapped,\n>> +\t};\n>> \tCameraStream(libcamera::PixelFormat format, libcamera::Size size,\n>> -\t\t unsigned int index, Encoder *encoder = nullptr);\n>> +\t\t Type type, unsigned int index, Encoder *encoder = nullptr);\n>> \n>> \tconst libcamera::PixelFormat &format() const { return format_; }\n>> \tconst libcamera::Size &size() const { return size_; }\n>> +\tType type() const { return type_; }\n>> \tunsigned int index() const { return index_; }\n>> \tEncoder *encoder() const { return encoder_.get(); }\n>> \n>> private:\n>> \tlibcamera::PixelFormat format_;\n>> \tlibcamera::Size size_;\n>> +\tType type_;\n>> \t/*\n>> \t * The index of the libcamera StreamConfiguration as added during\n>> \t * configureStreams(). A single libcamera Stream may be used to deliver\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E7AA2C3B5C\n\tfor ;\n\tMon, 5 Oct 2020 15:50:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8097663BE4;\n\tMon, 5 Oct 2020 17:50:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 32BFD63BE4\n\tfor ;\n\tMon, 5 Oct 2020 17:50:58 +0200 (CEST)","from [192.168.0.217]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 91E4C3B;\n\tMon, 5 Oct 2020 17:50:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nFJuQk8j\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601913057;\n\tbh=Mh96C6OF/hByob8oc668G0ALQ8/kuQZ/BA9fXPQGbX0=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=nFJuQk8jyvpotjc0DW4LDNoUgvPpGMACvVAqQECbsvNS+Rd1G4XA/SQ8N0XWnLvJv\n\t7WtK0LHuxWyZ3Zf8LJSLWNGK6A67gemeY9dtlDFsCtHNhsyus90rjviylMW0WgKVe/\n\ttHPQ99c7+ppVkGVO+g+hB27S6E5iN7CmrzjN/+Dc=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20201005104649.10812-1-laurent.pinchart@ideasonboard.com>\n\t<20201005104649.10812-3-laurent.pinchart@ideasonboard.com>\n\t<20201005112157.GE3931@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 5 Oct 2020 16:50:55 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20201005112157.GE3931@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 02/15] android: camera_stream: Add\n\tCameraStream::Type","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]