[{"id":12953,"web_url":"https://patchwork.libcamera.org/comment/12953/","msgid":"<20201004085823.GB8774@pendragon.ideasonboard.com>","date":"2020-10-04T08:58:23","subject":"Re: [libcamera-devel] [PATCH v3 38/38] README: Add dependency on\n\tpython3-ply for IPA interface generation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Fri, Oct 02, 2020 at 11:31:54PM +0900, Paul Elder wrote:\n> Specify in the readme that we depend on python3-ply for generating the\n> IPA interface.\n> \n> Signed-off-by: Paul Elder \n> \n> ---\n> New in v3\n> ---\n> README.rst | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/README.rst b/README.rst\n> index 74babaf7..a4279a4b 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -60,6 +60,9 @@ Meson Build system: [required]\n> for the libcamera core: [required]\n> python3-yaml\n> \n> +for generating IPA interfaces: [required]\n> + python3-ply\n> +\n\nDo we need a separate section, can't we add that in the previous section\nwith python3-yaml ?\n\nWe should also add ply to py_modules, in utils/ipc/meson.build. See\nutils/meson.build for an example. I would do so in this patch, and move\nit right after the one that adds the mojo parser (I'd normally ask for\npy_modules to be updated in the patch that creates the dependency, but\nit's best to import mojo as-is).\n\nWith this addressed,\n\nReviewed-by: Laurent Pinchart \n\n> for IPA module signing: [required]\n> libgnutls28-dev openssl\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C588BC3B5B\n\tfor ;\n\tSun, 4 Oct 2020 08:59:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5DBAD60A00;\n\tSun, 4 Oct 2020 10:59:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D7F5E609FF\n\tfor ;\n\tSun, 4 Oct 2020 10:59:01 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4F37743;\n\tSun, 4 Oct 2020 10:59:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"D4uNAq7n\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601801941;\n\tbh=CxqU9G68kskIHNruPDM/1/v+WP2Ejh5RXfdV1jk8lEM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=D4uNAq7ncrGj6JNOYPM3l9SFZZipL0kcqZHNh0UblyDuisb+LG1J5nc8Ta6ZAqVSJ\n\tuNuINk7xIXOY7yylz7jJcBwx14U32iLtQ2gV3mRxoU0LJmUnfObf4qPXcKKJo0pvSo\n\tIMqzc7OTuuggSjfTNIhSnFa2rcwpiHWeoP1Cg4vY=","Date":"Sun, 4 Oct 2020 11:58:23 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"<20201004085823.GB8774@pendragon.ideasonboard.com>","References":"<20201002143154.468162-1-paul.elder@ideasonboard.com>\n\t<20201002143154.468162-39-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201002143154.468162-39-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 38/38] README: Add dependency on\n\tpython3-ply for IPA interface generation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":12955,"web_url":"https://patchwork.libcamera.org/comment/12955/","msgid":"<20201004103134.GA9424@pendragon.ideasonboard.com>","date":"2020-10-04T10:31:34","subject":"Re: [libcamera-devel] [PATCH v3 38/38] README: Add dependency on\n\tpython3-ply for IPA interface generation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Sun, Oct 04, 2020 at 11:58:23AM +0300, Laurent Pinchart wrote:\n> Hi Paul,\n> \n> Thank you for the patch.\n> \n> On Fri, Oct 02, 2020 at 11:31:54PM +0900, Paul Elder wrote:\n> > Specify in the readme that we depend on python3-ply for generating the\n> > IPA interface.\n> > \n> > Signed-off-by: Paul Elder \n> > \n> > ---\n> > New in v3\n> > ---\n> > README.rst | 3 +++\n> > 1 file changed, 3 insertions(+)\n> > \n> > diff --git a/README.rst b/README.rst\n> > index 74babaf7..a4279a4b 100644\n> > --- a/README.rst\n> > +++ b/README.rst\n> > @@ -60,6 +60,9 @@ Meson Build system: [required]\n> > for the libcamera core: [required]\n> > python3-yaml\n> > \n> > +for generating IPA interfaces: [required]\n> > + python3-ply\n> > +\n> \n> Do we need a separate section, can't we add that in the previous section\n> with python3-yaml ?\n> \n> We should also add ply to py_modules, in utils/ipc/meson.build. See\n> utils/meson.build for an example. I would do so in this patch, and move\n> it right after the one that adds the mojo parser (I'd normally ask for\n> py_modules to be updated in the patch that creates the dependency, but\n> it's best to import mojo as-is).\n\nAnd by the way, I think you should also add python3-jinja2. I've checked\nmojo and there are a few other dependencies, but none that are required\nby the code we use (they're for unit tests or ancillary scripts such as\ncompile_typescript.py or gen_data_files_list.py)\n\n> With this addressed,\n> \n> Reviewed-by: Laurent Pinchart \n> \n> > for IPA module signing: [required]\n> > libgnutls28-dev openssl\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AAF57C3B5B\n\tfor ;\n\tSun, 4 Oct 2020 10:32:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2476A63B2B;\n\tSun, 4 Oct 2020 12:32:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 85C6B6035B\n\tfor ;\n\tSun, 4 Oct 2020 12:32:13 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EA9C543;\n\tSun, 4 Oct 2020 12:32:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jjMjnuky\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1601807533;\n\tbh=jLpGnA+vrF3xUyiaNRTdOl5Tg7muFwz+3qDhgDNbDnA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jjMjnukykp7Ji9+9FVSf/y0j1S+tWp4t07V2CVyTzc0vHxkVKAQoVT9lD7/n434in\n\t4VwGN2j05EKvHivDNcP6G6JSkM2lbsQLvwqCLCo/hH2U5FajA30XYx/zpKCR7L7iRc\n\teh/G3Ao8In4sCJ3ZpvSkktOyCbtKGDt3Ro8fZ2S0=","Date":"Sun, 4 Oct 2020 13:31:34 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"<20201004103134.GA9424@pendragon.ideasonboard.com>","References":"<20201002143154.468162-1-paul.elder@ideasonboard.com>\n\t<20201002143154.468162-39-paul.elder@ideasonboard.com>\n\t<20201004085823.GB8774@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20201004085823.GB8774@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v3 38/38] README: Add dependency on\n\tpython3-ply for IPA interface generation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]